[INFO] updating cached repository edelsonc/rusty-transparent [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/edelsonc/rusty-transparent [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/edelsonc/rusty-transparent" "work/ex/clippy-test-run/sources/stable/gh/edelsonc/rusty-transparent"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/edelsonc/rusty-transparent'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/edelsonc/rusty-transparent" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/edelsonc/rusty-transparent"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/edelsonc/rusty-transparent'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 547ef0169ea43aa2836cd1e158953c0935f57710 [INFO] sha for GitHub repo edelsonc/rusty-transparent: 547ef0169ea43aa2836cd1e158953c0935f57710 [INFO] validating manifest of edelsonc/rusty-transparent on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of edelsonc/rusty-transparent on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing edelsonc/rusty-transparent [INFO] finished frobbing edelsonc/rusty-transparent [INFO] frobbed toml for edelsonc/rusty-transparent written to work/ex/clippy-test-run/sources/stable/gh/edelsonc/rusty-transparent/Cargo.toml [INFO] started frobbing edelsonc/rusty-transparent [INFO] finished frobbing edelsonc/rusty-transparent [INFO] frobbed toml for edelsonc/rusty-transparent written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/edelsonc/rusty-transparent/Cargo.toml [INFO] crate edelsonc/rusty-transparent has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting edelsonc/rusty-transparent against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/edelsonc/rusty-transparent:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f62d26f231801d65c87715cc9ed562beb3ae445c078e8c983b1bbc9596e075b8 [INFO] running `"docker" "start" "-a" "f62d26f231801d65c87715cc9ed562beb3ae445c078e8c983b1bbc9596e075b8"` [INFO] [stderr] Checking rusty-transparent v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/main.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | Err(e) => panic!("Not a valid image path or could not open image"), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:20:11 [INFO] [stderr] | [INFO] [stderr] 20 | fn eq (x: &u8, y: &u8) -> bool { x == y } [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:20:19 [INFO] [stderr] | [INFO] [stderr] 20 | fn eq (x: &u8, y: &u8) -> bool { x == y } [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:21:11 [INFO] [stderr] | [INFO] [stderr] 21 | fn gt (x: &u8, y: &u8) -> bool { x > y } [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:21:19 [INFO] [stderr] | [INFO] [stderr] 21 | fn gt (x: &u8, y: &u8) -> bool { x > y } [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:22:11 [INFO] [stderr] | [INFO] [stderr] 22 | fn lt (x: &u8, y: &u8) -> bool { x < y } [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:22:19 [INFO] [stderr] | [INFO] [stderr] 22 | fn lt (x: &u8, y: &u8) -> bool { x < y } [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/main.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | Err(e) => panic!("Not a valid image path or could not open image"), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:20:11 [INFO] [stderr] | [INFO] [stderr] 20 | fn eq (x: &u8, y: &u8) -> bool { x == y } [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:20:19 [INFO] [stderr] | [INFO] [stderr] 20 | fn eq (x: &u8, y: &u8) -> bool { x == y } [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:21:11 [INFO] [stderr] | [INFO] [stderr] 21 | fn gt (x: &u8, y: &u8) -> bool { x > y } [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:21:19 [INFO] [stderr] | [INFO] [stderr] 21 | fn gt (x: &u8, y: &u8) -> bool { x > y } [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:22:11 [INFO] [stderr] | [INFO] [stderr] 22 | fn lt (x: &u8, y: &u8) -> bool { x < y } [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:22:19 [INFO] [stderr] | [INFO] [stderr] 22 | fn lt (x: &u8, y: &u8) -> bool { x < y } [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.94s [INFO] running `"docker" "inspect" "f62d26f231801d65c87715cc9ed562beb3ae445c078e8c983b1bbc9596e075b8"` [INFO] running `"docker" "rm" "-f" "f62d26f231801d65c87715cc9ed562beb3ae445c078e8c983b1bbc9596e075b8"` [INFO] [stdout] f62d26f231801d65c87715cc9ed562beb3ae445c078e8c983b1bbc9596e075b8