[INFO] updating cached repository edelsonc/asciify [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/edelsonc/asciify [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/edelsonc/asciify" "work/ex/clippy-test-run/sources/stable/gh/edelsonc/asciify"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/edelsonc/asciify'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/edelsonc/asciify" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/edelsonc/asciify"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/edelsonc/asciify'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 43c99b5c05052fa8430d6790e9018443ae155f44 [INFO] sha for GitHub repo edelsonc/asciify: 43c99b5c05052fa8430d6790e9018443ae155f44 [INFO] validating manifest of edelsonc/asciify on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of edelsonc/asciify on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing edelsonc/asciify [INFO] finished frobbing edelsonc/asciify [INFO] frobbed toml for edelsonc/asciify written to work/ex/clippy-test-run/sources/stable/gh/edelsonc/asciify/Cargo.toml [INFO] started frobbing edelsonc/asciify [INFO] finished frobbing edelsonc/asciify [INFO] frobbed toml for edelsonc/asciify written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/edelsonc/asciify/Cargo.toml [INFO] crate edelsonc/asciify has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting edelsonc/asciify against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/edelsonc/asciify:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1de69dab8cd680ed77898c338d715ce663975eaa26709376a18427317498b50c [INFO] running `"docker" "start" "-a" "1de69dab8cd680ed77898c338d715ce663975eaa26709376a18427317498b50c"` [INFO] [stderr] Checking rand v0.3.17 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.17.0 [INFO] [stderr] Checking asciify v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/main.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | Err(e) => panic!("Not a valid image path or could no open image"), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | let comp = &step * i; [INFO] [stderr] | -----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `step` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:20:12 [INFO] [stderr] | [INFO] [stderr] 20 | if value < &comp { [INFO] [stderr] | ^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `comp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/main.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | Err(e) => panic!("Not a valid image path or could no open image"), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | let comp = &step * i; [INFO] [stderr] | -----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `step` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:20:12 [INFO] [stderr] | [INFO] [stderr] 20 | if value < &comp { [INFO] [stderr] | ^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `comp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.80s [INFO] running `"docker" "inspect" "1de69dab8cd680ed77898c338d715ce663975eaa26709376a18427317498b50c"` [INFO] running `"docker" "rm" "-f" "1de69dab8cd680ed77898c338d715ce663975eaa26709376a18427317498b50c"` [INFO] [stdout] 1de69dab8cd680ed77898c338d715ce663975eaa26709376a18427317498b50c