[INFO] updating cached repository edanc/katas [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/edanc/katas [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/edanc/katas" "work/ex/clippy-test-run/sources/stable/gh/edanc/katas"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/edanc/katas'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/edanc/katas" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/edanc/katas"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/edanc/katas'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b6d9d30b4b2c1a60d978d4fea883c7ca7a5f611b [INFO] sha for GitHub repo edanc/katas: b6d9d30b4b2c1a60d978d4fea883c7ca7a5f611b [INFO] validating manifest of edanc/katas on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of edanc/katas on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing edanc/katas [INFO] finished frobbing edanc/katas [INFO] frobbed toml for edanc/katas written to work/ex/clippy-test-run/sources/stable/gh/edanc/katas/Cargo.toml [INFO] started frobbing edanc/katas [INFO] finished frobbing edanc/katas [INFO] frobbed toml for edanc/katas written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/edanc/katas/Cargo.toml [INFO] crate edanc/katas has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting edanc/katas against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/edanc/katas:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 64a31b9144dd312e32a493bb756d97eaa0b3aabea182fb4e4adf31c13b6f5036 [INFO] running `"docker" "start" "-a" "64a31b9144dd312e32a493bb756d97eaa0b3aabea182fb4e4adf31c13b6f5036"` [INFO] [stderr] Checking katas v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/count_sheep.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return number; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | return EVEN; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `EVEN` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return ODD; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ODD` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/count_sheep.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return number; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | return EVEN; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `EVEN` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return ODD; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ODD` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/count_sheep.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | / match value { [INFO] [stderr] 5 | | &true => number += 1, [INFO] [stderr] 6 | | _ => number += 0, [INFO] [stderr] 7 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 4 | match *value { [INFO] [stderr] 5 | true => number += 1, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/count_sheep.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | / match value { [INFO] [stderr] 5 | | &true => number += 1, [INFO] [stderr] 6 | | _ => number += 0, [INFO] [stderr] 7 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 4 | match *value { [INFO] [stderr] 5 | true => number += 1, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.89s [INFO] running `"docker" "inspect" "64a31b9144dd312e32a493bb756d97eaa0b3aabea182fb4e4adf31c13b6f5036"` [INFO] running `"docker" "rm" "-f" "64a31b9144dd312e32a493bb756d97eaa0b3aabea182fb4e4adf31c13b6f5036"` [INFO] [stdout] 64a31b9144dd312e32a493bb756d97eaa0b3aabea182fb4e4adf31c13b6f5036