[INFO] updating cached repository ecsumed/Raceplayer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ecsumed/Raceplayer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ecsumed/Raceplayer" "work/ex/clippy-test-run/sources/stable/gh/ecsumed/Raceplayer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ecsumed/Raceplayer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ecsumed/Raceplayer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ecsumed/Raceplayer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ecsumed/Raceplayer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 63ae4d603c8e0ef63b10b5394dfeac3579e05e41 [INFO] sha for GitHub repo ecsumed/Raceplayer: 63ae4d603c8e0ef63b10b5394dfeac3579e05e41 [INFO] validating manifest of ecsumed/Raceplayer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ecsumed/Raceplayer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ecsumed/Raceplayer [INFO] finished frobbing ecsumed/Raceplayer [INFO] frobbed toml for ecsumed/Raceplayer written to work/ex/clippy-test-run/sources/stable/gh/ecsumed/Raceplayer/Cargo.toml [INFO] started frobbing ecsumed/Raceplayer [INFO] finished frobbing ecsumed/Raceplayer [INFO] frobbed toml for ecsumed/Raceplayer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ecsumed/Raceplayer/Cargo.toml [INFO] crate ecsumed/Raceplayer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ecsumed/Raceplayer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ecsumed/Raceplayer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7ec63f7df306c02b723f9f3ffc018c9c9a42145876ec1189fc36399958031031 [INFO] running `"docker" "start" "-a" "7ec63f7df306c02b723f9f3ffc018c9c9a42145876ec1189fc36399958031031"` [INFO] [stderr] Checking nix v0.9.0 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking rexpect v0.3.0 [INFO] [stderr] Checking ctrlc v3.1.0 [INFO] [stderr] Checking acestream_player v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `SubCommand` [INFO] [stderr] --> src/main.rs:6:22 [INFO] [stderr] | [INFO] [stderr] 6 | use clap::{Arg, App, SubCommand}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `rexpect::errors::*` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use rexpect::errors::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `SubCommand` [INFO] [stderr] --> src/main.rs:6:22 [INFO] [stderr] | [INFO] [stderr] 6 | use clap::{Arg, App, SubCommand}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `rexpect::errors::*` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use rexpect::errors::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `player_process` [INFO] [stderr] --> src/main.rs:90:7 [INFO] [stderr] | [INFO] [stderr] 90 | let player_process = run_cmd(&format!("{}", player), args).wait() [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_player_process` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `public_key` [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | public_key: str [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:53:3 [INFO] [stderr] | [INFO] [stderr] 53 | run_cmd("acestreamengine", args).stdout; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `run_cmd("acestreamengine", args);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:59:3 [INFO] [stderr] | [INFO] [stderr] 59 | run_cmd("pkill", args).stdout; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `run_cmd("pkill", args);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:65:3 [INFO] [stderr] | [INFO] [stderr] 65 | p.send_line("HELLOBG version=3"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:79:3 [INFO] [stderr] | [INFO] [stderr] 79 | p.send_line(&format!("READY key={}", resp_key)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:80:3 [INFO] [stderr] | [INFO] [stderr] 80 | p.exp_regex("AUTH.*"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:81:3 [INFO] [stderr] | [INFO] [stderr] 81 | p.send_line("USERDATA [{\"gender\": \"1\"}, {\"age\": \"3\"}]"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:83:3 [INFO] [stderr] | [INFO] [stderr] 83 | p.send_line(&format!("START PID {} 0", stream_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | let url = String::from(p.exp_regex("http://.*") [INFO] [stderr] | ___________________^ [INFO] [stderr] 85 | | .unwrap().1.split(' ') [INFO] [stderr] 86 | | .collect::>()[0] [INFO] [stderr] 87 | | .to_owned()); [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `String::from()` [INFO] [stderr] | [INFO] [stderr] 84 | let url = p.exp_regex("http://.*") [INFO] [stderr] 85 | .unwrap().1.split(' ') [INFO] [stderr] 86 | .collect::>()[0] [INFO] [stderr] 87 | .to_owned(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:89:19 [INFO] [stderr] | [INFO] [stderr] 89 | let args = vec![String::from(url)]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:90:33 [INFO] [stderr] | [INFO] [stderr] 90 | let player_process = run_cmd(&format!("{}", player), args).wait() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `player.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused variable: `player_process` [INFO] [stderr] --> src/main.rs:90:7 [INFO] [stderr] | [INFO] [stderr] 90 | let player_process = run_cmd(&format!("{}", player), args).wait() [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_player_process` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `public_key` [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | public_key: str [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:53:3 [INFO] [stderr] | [INFO] [stderr] 53 | run_cmd("acestreamengine", args).stdout; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `run_cmd("acestreamengine", args);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:59:3 [INFO] [stderr] | [INFO] [stderr] 59 | run_cmd("pkill", args).stdout; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `run_cmd("pkill", args);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:65:3 [INFO] [stderr] | [INFO] [stderr] 65 | p.send_line("HELLOBG version=3"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:79:3 [INFO] [stderr] | [INFO] [stderr] 79 | p.send_line(&format!("READY key={}", resp_key)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:80:3 [INFO] [stderr] | [INFO] [stderr] 80 | p.exp_regex("AUTH.*"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:81:3 [INFO] [stderr] | [INFO] [stderr] 81 | p.send_line("USERDATA [{\"gender\": \"1\"}, {\"age\": \"3\"}]"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:83:3 [INFO] [stderr] | [INFO] [stderr] 83 | p.send_line(&format!("START PID {} 0", stream_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | let url = String::from(p.exp_regex("http://.*") [INFO] [stderr] | ___________________^ [INFO] [stderr] 85 | | .unwrap().1.split(' ') [INFO] [stderr] 86 | | .collect::>()[0] [INFO] [stderr] 87 | | .to_owned()); [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `String::from()` [INFO] [stderr] | [INFO] [stderr] 84 | let url = p.exp_regex("http://.*") [INFO] [stderr] 85 | .unwrap().1.split(' ') [INFO] [stderr] 86 | .collect::>()[0] [INFO] [stderr] 87 | .to_owned(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:89:19 [INFO] [stderr] | [INFO] [stderr] 89 | let args = vec![String::from(url)]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:90:33 [INFO] [stderr] | [INFO] [stderr] 90 | let player_process = run_cmd(&format!("{}", player), args).wait() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `player.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.07s [INFO] running `"docker" "inspect" "7ec63f7df306c02b723f9f3ffc018c9c9a42145876ec1189fc36399958031031"` [INFO] running `"docker" "rm" "-f" "7ec63f7df306c02b723f9f3ffc018c9c9a42145876ec1189fc36399958031031"` [INFO] [stdout] 7ec63f7df306c02b723f9f3ffc018c9c9a42145876ec1189fc36399958031031