[INFO] updating cached repository echorohit/derust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/echorohit/derust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/echorohit/derust" "work/ex/clippy-test-run/sources/stable/gh/echorohit/derust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/echorohit/derust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/echorohit/derust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/echorohit/derust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/echorohit/derust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 388960e0bc81567ce8d8217fcf85284c2fae7ae0 [INFO] sha for GitHub repo echorohit/derust: 388960e0bc81567ce8d8217fcf85284c2fae7ae0 [INFO] validating manifest of echorohit/derust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of echorohit/derust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing echorohit/derust [INFO] finished frobbing echorohit/derust [INFO] frobbed toml for echorohit/derust written to work/ex/clippy-test-run/sources/stable/gh/echorohit/derust/Cargo.toml [INFO] started frobbing echorohit/derust [INFO] finished frobbing echorohit/derust [INFO] frobbed toml for echorohit/derust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/echorohit/derust/Cargo.toml [INFO] crate echorohit/derust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting echorohit/derust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/echorohit/derust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c21159ce43544f7d5e1360de9407d9fc971a76534eaced9aeecbb910bb57d25a [INFO] running `"docker" "start" "-a" "c21159ce43544f7d5e1360de9407d9fc971a76534eaced9aeecbb910bb57d25a"` [INFO] [stderr] Checking derust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:25:23 [INFO] [stderr] | [INFO] [stderr] 25 | const PHI : f64 = 1.6180339; [INFO] [stderr] | ^^^^^^^^^ help: consider: `1.618_033_9` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | let c = (far - 32) as f64 * 0.5556; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(far - 32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:34:23 [INFO] [stderr] | [INFO] [stderr] 34 | fib_n = ((fib_n as f64 * PHI) as f64).round() as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(fib_n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | t = t + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `t += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:25:23 [INFO] [stderr] | [INFO] [stderr] 25 | const PHI : f64 = 1.6180339; [INFO] [stderr] | ^^^^^^^^^ help: consider: `1.618_033_9` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | let c = (far - 32) as f64 * 0.5556; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(far - 32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:34:23 [INFO] [stderr] | [INFO] [stderr] 34 | fib_n = ((fib_n as f64 * PHI) as f64).round() as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(fib_n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | t = t + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `t += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.01s [INFO] running `"docker" "inspect" "c21159ce43544f7d5e1360de9407d9fc971a76534eaced9aeecbb910bb57d25a"` [INFO] running `"docker" "rm" "-f" "c21159ce43544f7d5e1360de9407d9fc971a76534eaced9aeecbb910bb57d25a"` [INFO] [stdout] c21159ce43544f7d5e1360de9407d9fc971a76534eaced9aeecbb910bb57d25a