[INFO] updating cached repository ebobby/chip8-vm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ebobby/chip8-vm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ebobby/chip8-vm" "work/ex/clippy-test-run/sources/stable/gh/ebobby/chip8-vm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ebobby/chip8-vm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ebobby/chip8-vm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ebobby/chip8-vm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ebobby/chip8-vm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 64905d8daa53a076b18395693038486de5f1907e [INFO] sha for GitHub repo ebobby/chip8-vm: 64905d8daa53a076b18395693038486de5f1907e [INFO] validating manifest of ebobby/chip8-vm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ebobby/chip8-vm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ebobby/chip8-vm [INFO] finished frobbing ebobby/chip8-vm [INFO] frobbed toml for ebobby/chip8-vm written to work/ex/clippy-test-run/sources/stable/gh/ebobby/chip8-vm/Cargo.toml [INFO] started frobbing ebobby/chip8-vm [INFO] finished frobbing ebobby/chip8-vm [INFO] frobbed toml for ebobby/chip8-vm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ebobby/chip8-vm/Cargo.toml [INFO] crate ebobby/chip8-vm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ebobby/chip8-vm against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ebobby/chip8-vm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f748df0ab5ffb6e9327a38fb4d07c2e601bc86589e6d822183f8b3249265d03a [INFO] running `"docker" "start" "-a" "f748df0ab5ffb6e9327a38fb4d07c2e601bc86589e6d822183f8b3249265d03a"` [INFO] [stderr] Checking chip8-vm v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: method is never used: `dump_mem` [INFO] [stderr] --> src/chip8/ram.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn dump_mem(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dump_mem` [INFO] [stderr] --> src/chip8/mod.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn dump_mem(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/chip8/ram.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / f.read(&mut self.mem[::chip8::PROGRAM_START..]) [INFO] [stderr] 52 | | .expect("Oh noes!"); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/ram.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | (self.mem[i] as u16) << 8 | self.mem[i + 1] as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mem[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/ram.rs:58:37 [INFO] [stderr] | [INFO] [stderr] 58 | (self.mem[i] as u16) << 8 | self.mem[i + 1] as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mem[i + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/utils.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | (n1 as u16) << 12 | (n2 as u16) << 8 | (n3 as u16) << 4 | (n4 as u16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(n1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/utils.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | (n1 as u16) << 12 | (n2 as u16) << 8 | (n3 as u16) << 4 | (n4 as u16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(n2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/utils.rs:11:44 [INFO] [stderr] | [INFO] [stderr] 11 | (n1 as u16) << 12 | (n2 as u16) << 8 | (n3 as u16) << 4 | (n4 as u16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(n3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/utils.rs:11:63 [INFO] [stderr] | [INFO] [stderr] 11 | (n1 as u16) << 12 | (n2 as u16) << 8 | (n3 as u16) << 4 | (n4 as u16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(n4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/utils.rs:15:6 [INFO] [stderr] | [INFO] [stderr] 15 | ((n1 as u16) << 4 | (n2 as u16) & 0xFF) as u8 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(n1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/utils.rs:15:25 [INFO] [stderr] | [INFO] [stderr] 15 | ((n1 as u16) << 4 | (n2 as u16) & 0xFF) as u8 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(n2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `chip8-vm`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: method is never used: `dump_mem` [INFO] [stderr] --> src/chip8/ram.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn dump_mem(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dump_mem` [INFO] [stderr] --> src/chip8/mod.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn dump_mem(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/chip8/ram.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / f.read(&mut self.mem[::chip8::PROGRAM_START..]) [INFO] [stderr] 52 | | .expect("Oh noes!"); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/ram.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | (self.mem[i] as u16) << 8 | self.mem[i + 1] as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mem[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/ram.rs:58:37 [INFO] [stderr] | [INFO] [stderr] 58 | (self.mem[i] as u16) << 8 | self.mem[i + 1] as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mem[i + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/utils.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | (n1 as u16) << 12 | (n2 as u16) << 8 | (n3 as u16) << 4 | (n4 as u16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(n1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/utils.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | (n1 as u16) << 12 | (n2 as u16) << 8 | (n3 as u16) << 4 | (n4 as u16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(n2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/utils.rs:11:44 [INFO] [stderr] | [INFO] [stderr] 11 | (n1 as u16) << 12 | (n2 as u16) << 8 | (n3 as u16) << 4 | (n4 as u16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(n3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/utils.rs:11:63 [INFO] [stderr] | [INFO] [stderr] 11 | (n1 as u16) << 12 | (n2 as u16) << 8 | (n3 as u16) << 4 | (n4 as u16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(n4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/utils.rs:15:6 [INFO] [stderr] | [INFO] [stderr] 15 | ((n1 as u16) << 4 | (n2 as u16) & 0xFF) as u8 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(n1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/chip8/utils.rs:15:25 [INFO] [stderr] | [INFO] [stderr] 15 | ((n1 as u16) << 4 | (n2 as u16) & 0xFF) as u8 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(n2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `chip8-vm`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f748df0ab5ffb6e9327a38fb4d07c2e601bc86589e6d822183f8b3249265d03a"` [INFO] running `"docker" "rm" "-f" "f748df0ab5ffb6e9327a38fb4d07c2e601bc86589e6d822183f8b3249265d03a"` [INFO] [stdout] f748df0ab5ffb6e9327a38fb4d07c2e601bc86589e6d822183f8b3249265d03a