[INFO] updating cached repository ebkalderon/tq
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ebkalderon/tq
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ebkalderon/tq" "work/ex/clippy-test-run/sources/stable/gh/ebkalderon/tq"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ebkalderon/tq'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ebkalderon/tq" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ebkalderon/tq"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ebkalderon/tq'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 6968432771ec7383316d6fabc5c4288355ad700f
[INFO] sha for GitHub repo ebkalderon/tq: 6968432771ec7383316d6fabc5c4288355ad700f
[INFO] validating manifest of ebkalderon/tq on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ebkalderon/tq on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ebkalderon/tq
[INFO] finished frobbing ebkalderon/tq
[INFO] frobbed toml for ebkalderon/tq written to work/ex/clippy-test-run/sources/stable/gh/ebkalderon/tq/Cargo.toml
[INFO] started frobbing ebkalderon/tq
[INFO] finished frobbing ebkalderon/tq
[INFO] frobbed toml for ebkalderon/tq written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ebkalderon/tq/Cargo.toml
[INFO] crate ebkalderon/tq has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ebkalderon/tq against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ebkalderon/tq:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 190de950ef184eae0fe1fd10358e562a89c838a0d60c2d464b96a6c369935565
[INFO] running `"docker" "start" "-a" "190de950ef184eae0fe1fd10358e562a89c838a0d60c2d464b96a6c369935565"`
[INFO] [stderr]    Compiling structopt-derive v0.2.10
[INFO] [stderr]     Checking regex v1.0.2
[INFO] [stderr]     Checking structopt v0.2.10
[INFO] [stderr]     Checking env_logger v0.5.12
[INFO] [stderr]     Checking tq v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]   --> src/main.rs:11:1
[INFO] [stderr]    |
[INFO] [stderr] 11 | #[macro_use]
[INFO] [stderr]    | ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `failure::ResultExt`
[INFO] [stderr]   --> src/main.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | use failure::ResultExt;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::iter::FromIterator`
[INFO] [stderr]  --> src/opcode.rs:1:5
[INFO] [stderr]   |
[INFO] [stderr] 1 | use std::iter::FromIterator;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `super::Error`
[INFO] [stderr]  --> src/opcode.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use super::Error;
[INFO] [stderr]   |     ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]   --> src/main.rs:11:1
[INFO] [stderr]    |
[INFO] [stderr] 11 | #[macro_use]
[INFO] [stderr]    | ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `failure::ResultExt`
[INFO] [stderr]   --> src/main.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | use failure::ResultExt;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::iter::FromIterator`
[INFO] [stderr]  --> src/opcode.rs:1:5
[INFO] [stderr]   |
[INFO] [stderr] 1 | use std::iter::FromIterator;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `super::Error`
[INFO] [stderr]  --> src/opcode.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use super::Error;
[INFO] [stderr]   |     ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: enum is never used: `SearchStep`
[INFO] [stderr]  --> src/filter.rs:6:1
[INFO] [stderr]   |
[INFO] [stderr] 6 | pub enum SearchStep<'a> {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `Filter`
[INFO] [stderr]   --> src/filter.rs:13:1
[INFO] [stderr]    |
[INFO] [stderr] 13 | pub struct Filter<'s, 't> {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new`
[INFO] [stderr]   --> src/filter.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 | /     pub fn new<V>(steps: &'s [SearchStep], values: &'t mut V) -> Self
[INFO] [stderr] 30 | |     where
[INFO] [stderr] 31 | |         V: Iterator<Item = Option<Value>>,
[INFO] [stderr] 32 | |     {
[INFO] [stderr] ...  |
[INFO] [stderr] 37 | |         }
[INFO] [stderr] 38 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/opcode.rs:51:32
[INFO] [stderr]    |
[INFO] [stderr] 51 |                 let mut toml = toml.into_iter().map(|value| {
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `toml`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/opcode.rs:56:46
[INFO] [stderr]    |
[INFO] [stderr] 56 |                             let end = if end.unwrap_or(inner.len()) >= inner.len() {
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| inner.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/opcode.rs:59:37
[INFO] [stderr]    |
[INFO] [stderr] 59 |                                 end.unwrap_or(inner.len())
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| inner.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/opcode.rs:66:46
[INFO] [stderr]    |
[INFO] [stderr] 66 |                             let end = if end.unwrap_or(inner.len()) >= inner.len() {
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| inner.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/opcode.rs:69:37
[INFO] [stderr]    |
[INFO] [stderr] 69 |                                 end.unwrap_or(inner.len())
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| inner.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: enum is never used: `SearchStep`
[INFO] [stderr]  --> src/filter.rs:6:1
[INFO] [stderr]   |
[INFO] [stderr] 6 | pub enum SearchStep<'a> {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `Filter`
[INFO] [stderr]   --> src/filter.rs:13:1
[INFO] [stderr]    |
[INFO] [stderr] 13 | pub struct Filter<'s, 't> {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new`
[INFO] [stderr]   --> src/filter.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 | /     pub fn new<V>(steps: &'s [SearchStep], values: &'t mut V) -> Self
[INFO] [stderr] 30 | |     where
[INFO] [stderr] 31 | |         V: Iterator<Item = Option<Value>>,
[INFO] [stderr] 32 | |     {
[INFO] [stderr] ...  |
[INFO] [stderr] 37 | |         }
[INFO] [stderr] 38 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/opcode.rs:51:32
[INFO] [stderr]    |
[INFO] [stderr] 51 |                 let mut toml = toml.into_iter().map(|value| {
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `toml`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/opcode.rs:56:46
[INFO] [stderr]    |
[INFO] [stderr] 56 |                             let end = if end.unwrap_or(inner.len()) >= inner.len() {
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| inner.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/opcode.rs:59:37
[INFO] [stderr]    |
[INFO] [stderr] 59 |                                 end.unwrap_or(inner.len())
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| inner.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/opcode.rs:66:46
[INFO] [stderr]    |
[INFO] [stderr] 66 |                             let end = if end.unwrap_or(inner.len()) >= inner.len() {
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| inner.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/opcode.rs:69:37
[INFO] [stderr]    |
[INFO] [stderr] 69 |                                 end.unwrap_or(inner.len())
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| inner.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.42s
[INFO] running `"docker" "inspect" "190de950ef184eae0fe1fd10358e562a89c838a0d60c2d464b96a6c369935565"`
[INFO] running `"docker" "rm" "-f" "190de950ef184eae0fe1fd10358e562a89c838a0d60c2d464b96a6c369935565"`
[INFO] [stdout] 190de950ef184eae0fe1fd10358e562a89c838a0d60c2d464b96a6c369935565