[INFO] updating cached repository eagletmt/idolmap [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/eagletmt/idolmap [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/eagletmt/idolmap" "work/ex/clippy-test-run/sources/stable/gh/eagletmt/idolmap"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/eagletmt/idolmap'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/eagletmt/idolmap" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eagletmt/idolmap"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eagletmt/idolmap'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f3b0dfe96ae9fd829e55296bacec762fc9178340 [INFO] sha for GitHub repo eagletmt/idolmap: f3b0dfe96ae9fd829e55296bacec762fc9178340 [INFO] validating manifest of eagletmt/idolmap on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of eagletmt/idolmap on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing eagletmt/idolmap [INFO] finished frobbing eagletmt/idolmap [INFO] frobbed toml for eagletmt/idolmap written to work/ex/clippy-test-run/sources/stable/gh/eagletmt/idolmap/Cargo.toml [INFO] started frobbing eagletmt/idolmap [INFO] finished frobbing eagletmt/idolmap [INFO] frobbed toml for eagletmt/idolmap written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eagletmt/idolmap/Cargo.toml [INFO] crate eagletmt/idolmap has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting eagletmt/idolmap against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/eagletmt/idolmap:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b7662b14c363611ef9577c611a238c03dacc19e48a6c4330827fa4f774485806 [INFO] running `"docker" "start" "-a" "b7662b14c363611ef9577c611a238c03dacc19e48a6c4330827fa4f774485806"` [INFO] [stderr] Compiling procedural-masquerade v0.1.6 [INFO] [stderr] Checking servo_arc v0.1.1 [INFO] [stderr] Checking crossbeam-epoch v0.4.3 [INFO] [stderr] Compiling serde_json v1.0.21 [INFO] [stderr] Checking csv v1.0.0 [INFO] [stderr] Compiling cssparser v0.23.10 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Compiling string_cache_codegen v0.4.1 [INFO] [stderr] Compiling selectors v0.19.0 [INFO] [stderr] Compiling cssparser-macros v0.3.3 [INFO] [stderr] Checking crossbeam-deque v0.3.1 [INFO] [stderr] Compiling string_cache v0.7.3 [INFO] [stderr] Compiling markup5ever v0.7.2 [INFO] [stderr] Checking tokio-threadpool v0.1.4 [INFO] [stderr] Checking tokio-fs v0.1.1 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking html5ever v0.22.3 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking kuchiki v0.7.0 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.6 [INFO] [stderr] Checking idolmap v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/aikatsu.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/aikatsu.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/aikatsu.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | address: address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/aikatsu.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | address: address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prichan.rs:15:76 [INFO] [stderr] | [INFO] [stderr] 15 | let timestamp = now.as_secs() * 1000 + now.subsec_nanos() as u64 / 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lovelive.rs:76:23 [INFO] [stderr] | [INFO] [stderr] 76 | h.entry(pref).or_insert(vec![]).push(super::Shop { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/prichan.rs:15:48 [INFO] [stderr] | [INFO] [stderr] 15 | let timestamp = now.as_secs() * 1000 + now.subsec_nanos() as u64 / 1000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(now.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/csv.rs:25:42 [INFO] [stderr] | [INFO] [stderr] 25 | csv::Reader::from_path(path).expect(&format!("Unable to read CSV file {}", path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to read CSV file {}", path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/csv.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | result.expect(&format!("Unable to deserialize row in CSV file {}", path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to deserialize row in CSV file {}", path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/csv.rs:46:49 [INFO] [stderr] | [INFO] [stderr] 46 | let mut file = std::fs::File::create(&path).expect(&format!("Unable to open {}", path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to open {}", path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prichan.rs:15:76 [INFO] [stderr] | [INFO] [stderr] 15 | let timestamp = now.as_secs() * 1000 + now.subsec_nanos() as u64 / 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lovelive.rs:76:23 [INFO] [stderr] | [INFO] [stderr] 76 | h.entry(pref).or_insert(vec![]).push(super::Shop { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/prichan.rs:15:48 [INFO] [stderr] | [INFO] [stderr] 15 | let timestamp = now.as_secs() * 1000 + now.subsec_nanos() as u64 / 1000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(now.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/csv.rs:25:42 [INFO] [stderr] | [INFO] [stderr] 25 | csv::Reader::from_path(path).expect(&format!("Unable to read CSV file {}", path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to read CSV file {}", path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/csv.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | result.expect(&format!("Unable to deserialize row in CSV file {}", path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to deserialize row in CSV file {}", path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/csv.rs:46:49 [INFO] [stderr] | [INFO] [stderr] 46 | let mut file = std::fs::File::create(&path).expect(&format!("Unable to open {}", path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to open {}", path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 12s [INFO] running `"docker" "inspect" "b7662b14c363611ef9577c611a238c03dacc19e48a6c4330827fa4f774485806"` [INFO] running `"docker" "rm" "-f" "b7662b14c363611ef9577c611a238c03dacc19e48a6c4330827fa4f774485806"` [INFO] [stdout] b7662b14c363611ef9577c611a238c03dacc19e48a6c4330827fa4f774485806