[INFO] updating cached repository eagletmt/fastladder-twitter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/eagletmt/fastladder-twitter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/eagletmt/fastladder-twitter" "work/ex/clippy-test-run/sources/stable/gh/eagletmt/fastladder-twitter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/eagletmt/fastladder-twitter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/eagletmt/fastladder-twitter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eagletmt/fastladder-twitter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eagletmt/fastladder-twitter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3b36588a7f500c90278a8690fa843fac9810b7a6 [INFO] sha for GitHub repo eagletmt/fastladder-twitter: 3b36588a7f500c90278a8690fa843fac9810b7a6 [INFO] validating manifest of eagletmt/fastladder-twitter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of eagletmt/fastladder-twitter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing eagletmt/fastladder-twitter [INFO] finished frobbing eagletmt/fastladder-twitter [INFO] frobbed toml for eagletmt/fastladder-twitter written to work/ex/clippy-test-run/sources/stable/gh/eagletmt/fastladder-twitter/Cargo.toml [INFO] started frobbing eagletmt/fastladder-twitter [INFO] finished frobbing eagletmt/fastladder-twitter [INFO] frobbed toml for eagletmt/fastladder-twitter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eagletmt/fastladder-twitter/Cargo.toml [INFO] crate eagletmt/fastladder-twitter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting eagletmt/fastladder-twitter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/eagletmt/fastladder-twitter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5d487a9c18033137e47a04c113eb1c32ae736d62a086f6f1849d1bfa384c41e4 [INFO] running `"docker" "start" "-a" "5d487a9c18033137e47a04c113eb1c32ae736d62a086f6f1849d1bfa384c41e4"` [INFO] [stderr] Compiling hyper v0.10.8 [INFO] [stderr] Compiling rayon-core v1.0.0 [INFO] [stderr] Checking env_logger v0.4.2 [INFO] [stderr] Compiling rayon v0.7.0 [INFO] [stderr] Compiling ring v0.7.4 [INFO] [stderr] Checking webpki v0.10.1 [INFO] [stderr] Checking rustls v0.5.8 [INFO] [stderr] Checking webpki-roots v0.7.0 [INFO] [stderr] Checking hyper-rustls v0.3.2 [INFO] [stderr] Checking fastladder-twitter v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:297:13 [INFO] [stderr] | [INFO] [stderr] 297 | fastladder: fastladder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fastladder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:356:20 [INFO] [stderr] | [INFO] [stderr] 356 | base_url: base_url, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `base_url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:357:20 [INFO] [stderr] | [INFO] [stderr] 357 | api_key: api_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `api_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:297:13 [INFO] [stderr] | [INFO] [stderr] 297 | fastladder: fastladder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fastladder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:356:20 [INFO] [stderr] | [INFO] [stderr] 356 | base_url: base_url, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `base_url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:357:20 [INFO] [stderr] | [INFO] [stderr] 357 | api_key: api_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `api_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:355:9 [INFO] [stderr] | [INFO] [stderr] 355 | / return Fastladder { [INFO] [stderr] 356 | | base_url: base_url, [INFO] [stderr] 357 | | api_key: api_key, [INFO] [stderr] 358 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 355 | Fastladder { [INFO] [stderr] 356 | base_url: base_url, [INFO] [stderr] 357 | api_key: api_key, [INFO] [stderr] 358 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:355:9 [INFO] [stderr] | [INFO] [stderr] 355 | / return Fastladder { [INFO] [stderr] 356 | | base_url: base_url, [INFO] [stderr] 357 | | api_key: api_key, [INFO] [stderr] 358 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 355 | Fastladder { [INFO] [stderr] 356 | base_url: base_url, [INFO] [stderr] 357 | api_key: api_key, [INFO] [stderr] 358 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:361:33 [INFO] [stderr] | [INFO] [stderr] 361 | fn post_feeds(&self, feeds: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Feed]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:361:33 [INFO] [stderr] | [INFO] [stderr] 361 | fn post_feeds(&self, feeds: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Feed]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.95s [INFO] running `"docker" "inspect" "5d487a9c18033137e47a04c113eb1c32ae736d62a086f6f1849d1bfa384c41e4"` [INFO] running `"docker" "rm" "-f" "5d487a9c18033137e47a04c113eb1c32ae736d62a086f6f1849d1bfa384c41e4"` [INFO] [stdout] 5d487a9c18033137e47a04c113eb1c32ae736d62a086f6f1849d1bfa384c41e4