[INFO] updating cached repository eadventurous/landscape-generation [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/eadventurous/landscape-generation [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/eadventurous/landscape-generation" "work/ex/clippy-test-run/sources/stable/gh/eadventurous/landscape-generation"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/eadventurous/landscape-generation'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/eadventurous/landscape-generation" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eadventurous/landscape-generation"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eadventurous/landscape-generation'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 568048b66d6c65824a37341a76cd7876365c874e [INFO] sha for GitHub repo eadventurous/landscape-generation: 568048b66d6c65824a37341a76cd7876365c874e [INFO] validating manifest of eadventurous/landscape-generation on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of eadventurous/landscape-generation on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing eadventurous/landscape-generation [INFO] finished frobbing eadventurous/landscape-generation [INFO] frobbed toml for eadventurous/landscape-generation written to work/ex/clippy-test-run/sources/stable/gh/eadventurous/landscape-generation/Cargo.toml [INFO] started frobbing eadventurous/landscape-generation [INFO] finished frobbing eadventurous/landscape-generation [INFO] frobbed toml for eadventurous/landscape-generation written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eadventurous/landscape-generation/Cargo.toml [INFO] crate eadventurous/landscape-generation has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting eadventurous/landscape-generation against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/eadventurous/landscape-generation:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 873addca53977861bedf5bfb95bbb05c976b4043c26b7d4cd2b75e3caa6323cf [INFO] running `"docker" "start" "-a" "873addca53977861bedf5bfb95bbb05c976b4043c26b7d4cd2b75e3caa6323cf"` [INFO] [stderr] Compiling num-complex v0.2.0 [INFO] [stderr] Checking ndarray v0.11.2 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking alga v0.7.1 [INFO] [stderr] Checking nalgebra v0.16.1 [INFO] [stderr] Checking LandscapeGeneration v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | let m = Matrix4::new(1f64, x.0, y.0, x.0 * y.0, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | let v = Vector4::new(1f64, p.0, p.1, (p.0*p.1)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | let b = m.try_inverse().unwrap().transpose() * v; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | let m = Matrix4::new(1f64, x.0, y.0, x.0 * y.0, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | let v = Vector4::new(1f64, p.0, p.1, (p.0*p.1)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | let b = m.try_inverse().unwrap().transpose() * v; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `ndarray::Array2` [INFO] [stderr] --> src/posutils.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use ndarray::Array2; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/posutils.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | return check_point(size, pos.add(direction)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `check_point(size, pos.add(direction))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | return t * t * t * (t * (t * 6f64 - 15f64) + 10f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `t * t * t * (t * (t * 6f64 - 15f64) + 10f64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | return a + x * (b - a); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a + x * (b - a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:106:42 [INFO] [stderr] | [INFO] [stderr] 106 | let v = Vector4::new(1f64, p.0, p.1, (p.0*p.1)); [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Add` [INFO] [stderr] --> src/posutils.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::ops::Add; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `lattice_n` [INFO] [stderr] --> src/main.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | let lattice_n = 10; [INFO] [stderr] | ^^^^^^^^^ help: consider using `_lattice_n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `active_agents` is assigned to, but never used [INFO] [stderr] --> src/agents.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | let mut active_agents = agents.len(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_active_agents` instead [INFO] [stderr] [INFO] [stderr] warning: unused import: `ndarray::Array2` [INFO] [stderr] --> src/posutils.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use ndarray::Array2; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/posutils.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | return check_point(size, pos.add(direction)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `check_point(size, pos.add(direction))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | return t * t * t * (t * (t * 6f64 - 15f64) + 10f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `t * t * t * (t * (t * 6f64 - 15f64) + 10f64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | return a + x * (b - a); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a + x * (b - a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:106:42 [INFO] [stderr] | [INFO] [stderr] 106 | let v = Vector4::new(1f64, p.0, p.1, (p.0*p.1)); [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `gradient_interpolation` [INFO] [stderr] --> src/main.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | fn gradient_interpolation(size: usize, lattice_n: usize) -> Array2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `fade` [INFO] [stderr] --> src/main.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | fn fade(t: f64) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `lerp` [INFO] [stderr] --> src/main.rs:74:1 [INFO] [stderr] | [INFO] [stderr] 74 | fn lerp(a: f64, b: f64, x: f64) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `bilinear_interpolation` [INFO] [stderr] --> src/main.rs:78:1 [INFO] [stderr] | [INFO] [stderr] 78 | fn bilinear_interpolation(size: usize, lattice_n: usize, max_height: usize) -> DMatrix { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `blerp` [INFO] [stderr] --> src/main.rs:101:1 [INFO] [stderr] | [INFO] [stderr] 101 | fn blerp(p:(f64, f64), x: (f64, f64), y: (f64,f64), f:(f64, f64, f64, f64)) -> f64{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: crate `LandscapeGeneration` should have a snake case name such as `landscape_generation` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `agents`. [INFO] [stderr] --> src/agents.rs:44:22 [INFO] [stderr] | [INFO] [stderr] 44 | for i in 0..(agents.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 44 | for in &mut agents { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/agents.rs:102:16 [INFO] [stderr] | [INFO] [stderr] 102 | if neighbors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!neighbors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Add` [INFO] [stderr] --> src/posutils.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::ops::Add; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `lattice_n` [INFO] [stderr] --> src/main.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | let lattice_n = 10; [INFO] [stderr] | ^^^^^^^^^ help: consider using `_lattice_n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `active_agents` is assigned to, but never used [INFO] [stderr] --> src/agents.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | let mut active_agents = agents.len(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_active_agents` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `gradient_interpolation` [INFO] [stderr] --> src/main.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | fn gradient_interpolation(size: usize, lattice_n: usize) -> Array2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `fade` [INFO] [stderr] --> src/main.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | fn fade(t: f64) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `lerp` [INFO] [stderr] --> src/main.rs:74:1 [INFO] [stderr] | [INFO] [stderr] 74 | fn lerp(a: f64, b: f64, x: f64) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `bilinear_interpolation` [INFO] [stderr] --> src/main.rs:78:1 [INFO] [stderr] | [INFO] [stderr] 78 | fn bilinear_interpolation(size: usize, lattice_n: usize, max_height: usize) -> DMatrix { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `blerp` [INFO] [stderr] --> src/main.rs:101:1 [INFO] [stderr] | [INFO] [stderr] 101 | fn blerp(p:(f64, f64), x: (f64, f64), y: (f64,f64), f:(f64, f64, f64, f64)) -> f64{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: crate `LandscapeGeneration` should have a snake case name such as `landscape_generation` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `agents`. [INFO] [stderr] --> src/agents.rs:44:22 [INFO] [stderr] | [INFO] [stderr] 44 | for i in 0..(agents.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 44 | for in &mut agents { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/agents.rs:102:16 [INFO] [stderr] | [INFO] [stderr] 102 | if neighbors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!neighbors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 53.98s [INFO] running `"docker" "inspect" "873addca53977861bedf5bfb95bbb05c976b4043c26b7d4cd2b75e3caa6323cf"` [INFO] running `"docker" "rm" "-f" "873addca53977861bedf5bfb95bbb05c976b4043c26b7d4cd2b75e3caa6323cf"` [INFO] [stdout] 873addca53977861bedf5bfb95bbb05c976b4043c26b7d4cd2b75e3caa6323cf