[INFO] updating cached repository eHealthExperts/dowser [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/eHealthExperts/dowser [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/eHealthExperts/dowser" "work/ex/clippy-test-run/sources/stable/gh/eHealthExperts/dowser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/eHealthExperts/dowser'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/eHealthExperts/dowser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eHealthExperts/dowser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eHealthExperts/dowser'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1e51d5da8d9207e927ff3c73871900ad16319a2a [INFO] sha for GitHub repo eHealthExperts/dowser: 1e51d5da8d9207e927ff3c73871900ad16319a2a [INFO] validating manifest of eHealthExperts/dowser on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of eHealthExperts/dowser on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing eHealthExperts/dowser [INFO] finished frobbing eHealthExperts/dowser [INFO] frobbed toml for eHealthExperts/dowser written to work/ex/clippy-test-run/sources/stable/gh/eHealthExperts/dowser/Cargo.toml [INFO] started frobbing eHealthExperts/dowser [INFO] finished frobbing eHealthExperts/dowser [INFO] frobbed toml for eHealthExperts/dowser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eHealthExperts/dowser/Cargo.toml [INFO] crate eHealthExperts/dowser has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting eHealthExperts/dowser against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/eHealthExperts/dowser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f6662ea25789875f8639d0f5d17e44e229051c74bc0d517ae5123a3fb4997ac9 [INFO] running `"docker" "start" "-a" "f6662ea25789875f8639d0f5d17e44e229051c74bc0d517ae5123a3fb4997ac9"` [INFO] [stderr] Compiling nom v3.2.1 [INFO] [stderr] Compiling syn v0.13.11 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Compiling askama_shared v0.6.2 [INFO] [stderr] Compiling askama_shared v0.5.0 [INFO] [stderr] Compiling askama_derive v0.6.4 [INFO] [stderr] Compiling askama_derive v0.5.0 [INFO] [stderr] Compiling askama v0.5.0 [INFO] [stderr] Compiling dowser v0.2.1 (/opt/crater/workdir) [INFO] [stderr] Checking askama v0.6.4 [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ike_scan/mod.rs:10:26 [INFO] [stderr] | [INFO] [stderr] 10 | pub const IKE_SCAN_BIN: &'static str = "./ike-scan"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ike_scan/mod.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | const SUCCESS_MSG: &'static str = "[✓] Reached endpoint"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ike_scan/mod.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | const FAILURE_MSG: &'static str = "[!] Unable to reach endpoint"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/report/scan_report.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/report/scan_report.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | let result = ScanReport { [INFO] [stderr] | ______________________^ [INFO] [stderr] 29 | | ..Default::default() [INFO] [stderr] 30 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ike_scan/mod.rs:10:26 [INFO] [stderr] | [INFO] [stderr] 10 | pub const IKE_SCAN_BIN: &'static str = "./ike-scan"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ike_scan/mod.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | const SUCCESS_MSG: &'static str = "[✓] Reached endpoint"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ike_scan/mod.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | const FAILURE_MSG: &'static str = "[!] Unable to reach endpoint"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/report/scan_report.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/report/scan_report.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | let result = ScanReport { [INFO] [stderr] | ______________________^ [INFO] [stderr] 29 | | ..Default::default() [INFO] [stderr] 30 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/ike_scan/mod.rs:55:31 [INFO] [stderr] | [INFO] [stderr] 55 | let output = cmd.output().expect(&format!( [INFO] [stderr] | _______________________________^ [INFO] [stderr] 56 | | "Failed to connect using ike-scan with parameters --sport {} to endpoint {}", [INFO] [stderr] 57 | | &conf.source_port.to_string(), [INFO] [stderr] 58 | | &conf.vpn_endpoint_ip [INFO] [stderr] 59 | | )); [INFO] [stderr] | |______^ help: try this: `unwrap_or_else(|_| panic!("Failed to connect using ike-scan with parameters --sport {} to endpoint {}", &conf.source_port.to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/ike_scan/mod.rs:55:31 [INFO] [stderr] | [INFO] [stderr] 55 | let output = cmd.output().expect(&format!( [INFO] [stderr] | _______________________________^ [INFO] [stderr] 56 | | "Failed to connect using ike-scan with parameters --sport {} to endpoint {}", [INFO] [stderr] 57 | | &conf.source_port.to_string(), [INFO] [stderr] 58 | | &conf.vpn_endpoint_ip [INFO] [stderr] 59 | | )); [INFO] [stderr] | |______^ help: try this: `unwrap_or_else(|_| panic!("Failed to connect using ike-scan with parameters --sport {} to endpoint {}", &conf.source_port.to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.84s [INFO] running `"docker" "inspect" "f6662ea25789875f8639d0f5d17e44e229051c74bc0d517ae5123a3fb4997ac9"` [INFO] running `"docker" "rm" "-f" "f6662ea25789875f8639d0f5d17e44e229051c74bc0d517ae5123a3fb4997ac9"` [INFO] [stdout] f6662ea25789875f8639d0f5d17e44e229051c74bc0d517ae5123a3fb4997ac9