[INFO] updating cached repository e14tech/rmonopoly [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/e14tech/rmonopoly [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/e14tech/rmonopoly" "work/ex/clippy-test-run/sources/stable/gh/e14tech/rmonopoly"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/e14tech/rmonopoly'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/e14tech/rmonopoly" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/e14tech/rmonopoly"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/e14tech/rmonopoly'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 877cb4844ba04afbccc7610bb2be256654da06a9 [INFO] sha for GitHub repo e14tech/rmonopoly: 877cb4844ba04afbccc7610bb2be256654da06a9 [INFO] validating manifest of e14tech/rmonopoly on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of e14tech/rmonopoly on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing e14tech/rmonopoly [INFO] finished frobbing e14tech/rmonopoly [INFO] frobbed toml for e14tech/rmonopoly written to work/ex/clippy-test-run/sources/stable/gh/e14tech/rmonopoly/Cargo.toml [INFO] started frobbing e14tech/rmonopoly [INFO] finished frobbing e14tech/rmonopoly [INFO] frobbed toml for e14tech/rmonopoly written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/e14tech/rmonopoly/Cargo.toml [INFO] crate e14tech/rmonopoly has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting e14tech/rmonopoly against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/e14tech/rmonopoly:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d63ef75e28b094d616f122f371aa2c9b64139cf691040f79f38df6b2558a1b59 [INFO] running `"docker" "start" "-a" "d63ef75e28b094d616f122f371aa2c9b64139cf691040f79f38df6b2558a1b59"` [INFO] [stderr] Checking monolopy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/game.rs:20:14 [INFO] [stderr] | [INFO] [stderr] 20 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 21 | | if current_player.doubles < 3 { [INFO] [stderr] 22 | | println!("You rolled doubles, play again."); [INFO] [stderr] 23 | | [INFO] [stderr] ... | [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 20 | else if current_player.doubles < 3 { [INFO] [stderr] 21 | println!("You rolled doubles, play again."); [INFO] [stderr] 22 | [INFO] [stderr] 23 | if current_player.doubles == 2 { [INFO] [stderr] 24 | println!("Get doubles one more time and you'll go to jail!"); [INFO] [stderr] 25 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/game.rs:20:14 [INFO] [stderr] | [INFO] [stderr] 20 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 21 | | if current_player.doubles < 3 { [INFO] [stderr] 22 | | println!("You rolled doubles, play again."); [INFO] [stderr] 23 | | [INFO] [stderr] ... | [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 20 | else if current_player.doubles < 3 { [INFO] [stderr] 21 | println!("You rolled doubles, play again."); [INFO] [stderr] 22 | [INFO] [stderr] 23 | if current_player.doubles == 2 { [INFO] [stderr] 24 | println!("Get doubles one more time and you'll go to jail!"); [INFO] [stderr] 25 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.11s [INFO] running `"docker" "inspect" "d63ef75e28b094d616f122f371aa2c9b64139cf691040f79f38df6b2558a1b59"` [INFO] running `"docker" "rm" "-f" "d63ef75e28b094d616f122f371aa2c9b64139cf691040f79f38df6b2558a1b59"` [INFO] [stdout] d63ef75e28b094d616f122f371aa2c9b64139cf691040f79f38df6b2558a1b59