[INFO] updating cached repository e14tech/largest [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/e14tech/largest [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/e14tech/largest" "work/ex/clippy-test-run/sources/stable/gh/e14tech/largest"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/e14tech/largest'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/e14tech/largest" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/e14tech/largest"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/e14tech/largest'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1efaaa5b970fb4594cb4050aaea6636c0659bbcf [INFO] sha for GitHub repo e14tech/largest: 1efaaa5b970fb4594cb4050aaea6636c0659bbcf [INFO] validating manifest of e14tech/largest on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of e14tech/largest on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing e14tech/largest [INFO] finished frobbing e14tech/largest [INFO] frobbed toml for e14tech/largest written to work/ex/clippy-test-run/sources/stable/gh/e14tech/largest/Cargo.toml [INFO] started frobbing e14tech/largest [INFO] finished frobbing e14tech/largest [INFO] frobbed toml for e14tech/largest written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/e14tech/largest/Cargo.toml [INFO] crate e14tech/largest has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting e14tech/largest against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/e14tech/largest:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 938f9f0da45306874b761498e4b879ca0a5b2cb18d4f1984104b29d91ec5f431 [INFO] running `"docker" "start" "-a" "938f9f0da45306874b761498e4b879ca0a5b2cb18d4f1984104b29d91ec5f431"` [INFO] [stderr] Checking largest v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:22:54 [INFO] [stderr] | [INFO] [stderr] 22 | numbers.push(rand::thread_rng().gen_range(0, 100000000000001)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `100_000_000_000_001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:22:54 [INFO] [stderr] | [INFO] [stderr] 22 | numbers.push(rand::thread_rng().gen_range(0, 100000000000001)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `100_000_000_000_001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/biggest.rs:1:25 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn biggest(numbers: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/smallest.rs:1:26 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn smallest(numbers: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/adder.rs:1:23 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn adder(numbers: &Vec) -> u128 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/adder.rs:5:26 [INFO] [stderr] | [INFO] [stderr] 5 | number_holder += item as u128; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u128::from(item)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mean.rs:1:22 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn mean(numbers: &Vec, input: &u64) -> f64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mean.rs:1:40 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn mean(numbers: &Vec, input: &u64) -> f64 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/mean.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | adder += item as u128; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u128::from(item)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/biggest.rs:1:25 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn biggest(numbers: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/smallest.rs:1:26 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn smallest(numbers: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/adder.rs:1:23 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn adder(numbers: &Vec) -> u128 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/adder.rs:5:26 [INFO] [stderr] | [INFO] [stderr] 5 | number_holder += item as u128; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u128::from(item)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mean.rs:1:22 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn mean(numbers: &Vec, input: &u64) -> f64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mean.rs:1:40 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn mean(numbers: &Vec, input: &u64) -> f64 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/mean.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | adder += item as u128; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u128::from(item)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.18s [INFO] running `"docker" "inspect" "938f9f0da45306874b761498e4b879ca0a5b2cb18d4f1984104b29d91ec5f431"` [INFO] running `"docker" "rm" "-f" "938f9f0da45306874b761498e4b879ca0a5b2cb18d4f1984104b29d91ec5f431"` [INFO] [stdout] 938f9f0da45306874b761498e4b879ca0a5b2cb18d4f1984104b29d91ec5f431