[INFO] updating cached repository dylanz/parser [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dylanz/parser [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dylanz/parser" "work/ex/clippy-test-run/sources/stable/gh/dylanz/parser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dylanz/parser'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dylanz/parser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dylanz/parser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dylanz/parser'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5a47ced5f0069a252b1d9df08c29ca8fcf2d640e [INFO] sha for GitHub repo dylanz/parser: 5a47ced5f0069a252b1d9df08c29ca8fcf2d640e [INFO] validating manifest of dylanz/parser on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dylanz/parser on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dylanz/parser [INFO] finished frobbing dylanz/parser [INFO] frobbed toml for dylanz/parser written to work/ex/clippy-test-run/sources/stable/gh/dylanz/parser/Cargo.toml [INFO] started frobbing dylanz/parser [INFO] finished frobbing dylanz/parser [INFO] frobbed toml for dylanz/parser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dylanz/parser/Cargo.toml [INFO] crate dylanz/parser has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dylanz/parser against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dylanz/parser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9c7853c7bdbcf8b90bc503bf3e232c777c30f2e74fd8f97b68b22f70590dc496 [INFO] running `"docker" "start" "-a" "9c7853c7bdbcf8b90bc503bf3e232c777c30f2e74fd8f97b68b22f70590dc496"` [INFO] [stderr] Checking regex v0.2.3 [INFO] [stderr] Checking gurnal v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:1:19 [INFO] [stderr] | [INFO] [stderr] 1 | const RECURRING: &'static [&'static str] = &["every", "*"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:1:29 [INFO] [stderr] | [INFO] [stderr] 1 | const RECURRING: &'static [&'static str] = &["every", "*"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:15:3 [INFO] [stderr] | [INFO] [stderr] 15 | return recurring; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `recurring` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:39:3 [INFO] [stderr] | [INFO] [stderr] 39 | return config.recurring; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `config.recurring` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: function is never used: `month_for_number` [INFO] [stderr] --> src/constants.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn month_for_number(text: &str) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:24:34 [INFO] [stderr] | [INFO] [stderr] 24 | let v: Vec<&str> = email.split("@").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:1:19 [INFO] [stderr] | [INFO] [stderr] 1 | const RECURRING: &'static [&'static str] = &["every", "*"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:1:29 [INFO] [stderr] | [INFO] [stderr] 1 | const RECURRING: &'static [&'static str] = &["every", "*"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:15:3 [INFO] [stderr] | [INFO] [stderr] 15 | return recurring; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `recurring` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:39:3 [INFO] [stderr] | [INFO] [stderr] 39 | return config.recurring; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `config.recurring` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: function is never used: `month_for_number` [INFO] [stderr] --> src/constants.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn month_for_number(text: &str) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:24:34 [INFO] [stderr] | [INFO] [stderr] 24 | let v: Vec<&str> = email.split("@").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.83s [INFO] running `"docker" "inspect" "9c7853c7bdbcf8b90bc503bf3e232c777c30f2e74fd8f97b68b22f70590dc496"` [INFO] running `"docker" "rm" "-f" "9c7853c7bdbcf8b90bc503bf3e232c777c30f2e74fd8f97b68b22f70590dc496"` [INFO] [stdout] 9c7853c7bdbcf8b90bc503bf3e232c777c30f2e74fd8f97b68b22f70590dc496