[INFO] updating cached repository dylanmckay/rubic [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dylanmckay/rubic [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dylanmckay/rubic" "work/ex/clippy-test-run/sources/stable/gh/dylanmckay/rubic"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dylanmckay/rubic'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dylanmckay/rubic" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dylanmckay/rubic"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dylanmckay/rubic'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c93cc2983bbad75ea5b164958ee082541821d817 [INFO] sha for GitHub repo dylanmckay/rubic: c93cc2983bbad75ea5b164958ee082541821d817 [INFO] validating manifest of dylanmckay/rubic on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dylanmckay/rubic on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dylanmckay/rubic [INFO] finished frobbing dylanmckay/rubic [INFO] frobbed toml for dylanmckay/rubic written to work/ex/clippy-test-run/sources/stable/gh/dylanmckay/rubic/Cargo.toml [INFO] started frobbing dylanmckay/rubic [INFO] finished frobbing dylanmckay/rubic [INFO] frobbed toml for dylanmckay/rubic written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dylanmckay/rubic/Cargo.toml [INFO] crate dylanmckay/rubic has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dylanmckay/rubic against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dylanmckay/rubic:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 11cac8744d29e6ed8f408a58feb0e520d6bf0d1dc7cf8971902671d586e2acdd [INFO] running `"docker" "start" "-a" "11cac8744d29e6ed8f408a58feb0e520d6bf0d1dc7cf8971902671d586e2acdd"` [INFO] [stderr] Compiling backtrace-sys v0.1.5 [INFO] [stderr] Checking backtrace v0.3.0 [INFO] [stderr] Checking error-chain v0.7.1 [INFO] [stderr] Checking rubic v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/parser.rs:33:27 [INFO] [stderr] | [INFO] [stderr] 33 | Ok(ast::Program { items: items }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/parser.rs:73:25 [INFO] [stderr] | [INFO] [stderr] 73 | Ok(ast::Class { name: name, items: items, superclass: superclass }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/parser.rs:73:37 [INFO] [stderr] | [INFO] [stderr] 73 | Ok(ast::Class { name: name, items: items, superclass: superclass }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/parser.rs:73:51 [INFO] [stderr] | [INFO] [stderr] 73 | Ok(ast::Class { name: name, items: items, superclass: superclass }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `superclass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/parser.rs:91:26 [INFO] [stderr] | [INFO] [stderr] 91 | Ok(ast::Module { name: name, items: items }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/parser.rs:91:38 [INFO] [stderr] | [INFO] [stderr] 91 | Ok(ast::Module { name: name, items: items }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/parser.rs:111:28 [INFO] [stderr] | [INFO] [stderr] 111 | Ok(ast::Function { name: name, statements: statements }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/parser.rs:111:40 [INFO] [stderr] | [INFO] [stderr] 111 | Ok(ast::Function { name: name, statements: statements }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `statements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/parser.rs:151:33 [INFO] [stderr] | [INFO] [stderr] 151 | Ok(ast::Parameter { name: name, default: None }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/parser.rs:186:29 [INFO] [stderr] | [INFO] [stderr] 186 | arguments: arguments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/parser.rs:285:30 [INFO] [stderr] | [INFO] [stderr] 285 | Ok(ast::SymbolExpr { name: name }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/parser.rs:33:27 [INFO] [stderr] | [INFO] [stderr] 33 | Ok(ast::Program { items: items }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/parser.rs:73:25 [INFO] [stderr] | [INFO] [stderr] 73 | Ok(ast::Class { name: name, items: items, superclass: superclass }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/parser.rs:73:37 [INFO] [stderr] | [INFO] [stderr] 73 | Ok(ast::Class { name: name, items: items, superclass: superclass }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/parser.rs:73:51 [INFO] [stderr] | [INFO] [stderr] 73 | Ok(ast::Class { name: name, items: items, superclass: superclass }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `superclass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/parser.rs:91:26 [INFO] [stderr] | [INFO] [stderr] 91 | Ok(ast::Module { name: name, items: items }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/parser.rs:91:38 [INFO] [stderr] | [INFO] [stderr] 91 | Ok(ast::Module { name: name, items: items }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/parser.rs:111:28 [INFO] [stderr] | [INFO] [stderr] 111 | Ok(ast::Function { name: name, statements: statements }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/parser.rs:111:40 [INFO] [stderr] | [INFO] [stderr] 111 | Ok(ast::Function { name: name, statements: statements }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `statements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/parser.rs:151:33 [INFO] [stderr] | [INFO] [stderr] 151 | Ok(ast::Parameter { name: name, default: None }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/parser.rs:186:29 [INFO] [stderr] | [INFO] [stderr] 186 | arguments: arguments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/parser.rs:285:30 [INFO] [stderr] | [INFO] [stderr] 285 | Ok(ast::SymbolExpr { name: name }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse/tokenize.rs:5:17 [INFO] [stderr] | [INFO] [stderr] 5 | const SYMBOLS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse/tokenize.rs:5:27 [INFO] [stderr] | [INFO] [stderr] 5 | const SYMBOLS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parse/tokenize.rs:154:16 [INFO] [stderr] | [INFO] [stderr] 154 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 155 | | if self.sent_last_new_line { [INFO] [stderr] 156 | | None [INFO] [stderr] 157 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 160 | | } [INFO] [stderr] 161 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 154 | } else if self.sent_last_new_line { [INFO] [stderr] 155 | None [INFO] [stderr] 156 | } else { [INFO] [stderr] 157 | self.sent_last_new_line = true; [INFO] [stderr] 158 | Some(Token::EndOfLine) [INFO] [stderr] 159 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse/tokenize.rs:5:17 [INFO] [stderr] | [INFO] [stderr] 5 | const SYMBOLS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse/tokenize.rs:5:27 [INFO] [stderr] | [INFO] [stderr] 5 | const SYMBOLS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parse/tokenize.rs:154:16 [INFO] [stderr] | [INFO] [stderr] 154 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 155 | | if self.sent_last_new_line { [INFO] [stderr] 156 | | None [INFO] [stderr] 157 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 160 | | } [INFO] [stderr] 161 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 154 | } else if self.sent_last_new_line { [INFO] [stderr] 155 | None [INFO] [stderr] 156 | } else { [INFO] [stderr] 157 | self.sent_last_new_line = true; [INFO] [stderr] 158 | Some(Token::EndOfLine) [INFO] [stderr] 159 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ast::Program` [INFO] [stderr] --> src/ast/mod.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / pub fn new() -> Self { [INFO] [stderr] 116 | | Program { items: Vec::new() } [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ast::Program` [INFO] [stderr] --> src/ast/mod.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / pub fn new() -> Self { [INFO] [stderr] 116 | | Program { items: Vec::new() } [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parse/parser.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / let mut superclass = None; [INFO] [stderr] 57 | | [INFO] [stderr] 58 | | // Check if we have a superclass specified. [INFO] [stderr] 59 | | if self.peek().unwrap() == Token::less_than() { [INFO] [stderr] ... | [INFO] [stderr] 62 | | superclass = Some(self.parse_path()?); [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let superclass = if self.peek().unwrap() == Token::less_than() { ..; Some(self.parse_path()?) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parse/parser.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / let mut superclass = None; [INFO] [stderr] 57 | | [INFO] [stderr] 58 | | // Check if we have a superclass specified. [INFO] [stderr] 59 | | if self.peek().unwrap() == Token::less_than() { [INFO] [stderr] ... | [INFO] [stderr] 62 | | superclass = Some(self.parse_path()?); [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let superclass = if self.peek().unwrap() == Token::less_than() { ..; Some(self.parse_path()?) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/parse/parser.rs:350:15 [INFO] [stderr] | [INFO] [stderr] 350 | fn is_eof(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parse/parser.rs:359:9 [INFO] [stderr] | [INFO] [stderr] 359 | / loop { [INFO] [stderr] 360 | | match self.peek() { [INFO] [stderr] 361 | | Some(Token::EndOfLine) => { [INFO] [stderr] 362 | | self.eat(); [INFO] [stderr] ... | [INFO] [stderr] 365 | | } [INFO] [stderr] 366 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(Token::EndOfLine) = self.peek() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/parse/parser.rs:350:15 [INFO] [stderr] | [INFO] [stderr] 350 | fn is_eof(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parse/parser.rs:359:9 [INFO] [stderr] | [INFO] [stderr] 359 | / loop { [INFO] [stderr] 360 | | match self.peek() { [INFO] [stderr] 361 | | Some(Token::EndOfLine) => { [INFO] [stderr] 362 | | self.eat(); [INFO] [stderr] ... | [INFO] [stderr] 365 | | } [INFO] [stderr] 366 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(Token::EndOfLine) = self.peek() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> tools/parse.rs:24:30 [INFO] [stderr] | [INFO] [stderr] 24 | if let Some(file_path) = env::args().skip(1).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> tools/parse.rs:24:30 [INFO] [stderr] | [INFO] [stderr] 24 | if let Some(file_path) = env::args().skip(1).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> tools/tokenize.rs:25:30 [INFO] [stderr] | [INFO] [stderr] 25 | if let Some(file_path) = env::args().skip(1).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> tools/tokenize.rs:25:30 [INFO] [stderr] | [INFO] [stderr] 25 | if let Some(file_path) = env::args().skip(1).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.67s [INFO] running `"docker" "inspect" "11cac8744d29e6ed8f408a58feb0e520d6bf0d1dc7cf8971902671d586e2acdd"` [INFO] running `"docker" "rm" "-f" "11cac8744d29e6ed8f408a58feb0e520d6bf0d1dc7cf8971902671d586e2acdd"` [INFO] [stdout] 11cac8744d29e6ed8f408a58feb0e520d6bf0d1dc7cf8971902671d586e2acdd