[INFO] updating cached repository dylanhart/roll [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dylanhart/roll [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dylanhart/roll" "work/ex/clippy-test-run/sources/stable/gh/dylanhart/roll"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dylanhart/roll'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dylanhart/roll" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dylanhart/roll"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dylanhart/roll'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ae105e9f3634453d23cfc39627f212c989c0c587 [INFO] sha for GitHub repo dylanhart/roll: ae105e9f3634453d23cfc39627f212c989c0c587 [INFO] validating manifest of dylanhart/roll on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dylanhart/roll on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dylanhart/roll [INFO] finished frobbing dylanhart/roll [INFO] frobbed toml for dylanhart/roll written to work/ex/clippy-test-run/sources/stable/gh/dylanhart/roll/Cargo.toml [INFO] started frobbing dylanhart/roll [INFO] finished frobbing dylanhart/roll [INFO] frobbed toml for dylanhart/roll written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dylanhart/roll/Cargo.toml [INFO] crate dylanhart/roll has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dylanhart/roll against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dylanhart/roll:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cf44dd15c0f65329c5de193edf604bdce8716692cefc1e2a6bea67dd285cba83 [INFO] running `"docker" "start" "-a" "cf44dd15c0f65329c5de193edf604bdce8716692cefc1e2a6bea67dd285cba83"` [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Compiling debugtrace v0.1.0 [INFO] [stderr] Checking debug-builders v0.1.0 [INFO] [stderr] Checking either v0.1.7 [INFO] [stderr] Checking conv v0.3.3 [INFO] [stderr] Compiling dbghelp-sys v0.2.0 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Checking backtrace v0.1.8 [INFO] [stderr] Checking chomp v0.3.1 [INFO] [stderr] Checking roll v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/dice.rs:159:56 [INFO] [stderr] | [INFO] [stderr] 159 | Dice::Die(n) => Roll::Die(rng.gen_range(1, (n as i64)+1)), [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/dice.rs:161:29 [INFO] [stderr] | [INFO] [stderr] 161 | let rolls = (0..n).into_iter().map(|_| dice.roll()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/dice.rs:213:17 [INFO] [stderr] | [INFO] [stderr] 213 | / if let &Dice::Die(sides) = dice.deref() { [INFO] [stderr] 214 | | write!(f, "{}d{}", n, sides) [INFO] [stderr] 215 | | } else { [INFO] [stderr] 216 | | write!(f, "{}({})", n, dice) [INFO] [stderr] 217 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 213 | if let Dice::Die(sides) = *dice.deref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/dice.rs:220:17 [INFO] [stderr] | [INFO] [stderr] 220 | / if let &Dice::Die(sides) = dice.deref() { [INFO] [stderr] 221 | | write!(f, "{}d{}{}", n, sides, modifier) [INFO] [stderr] 222 | | } else { [INFO] [stderr] 223 | | write!(f, "{}({}){}", n, dice, modifier) [INFO] [stderr] 224 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 220 | if let Dice::Die(sides) = *dice.deref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/dice.rs:309:34 [INFO] [stderr] | [INFO] [stderr] 309 | Roll::Constant(n) => n as i64, [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/dice.rs:405:50 [INFO] [stderr] | [INFO] [stderr] 405 | ret chars.fold(0, |acc, ch| 10*acc + (ch as u8 - b'0') as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(ch as u8 - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:454:9 [INFO] [stderr] | [INFO] [stderr] 454 | / parse!{ input; [INFO] [stderr] 455 | | keep_high() <|> keep_low() [INFO] [stderr] 456 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:454:9 [INFO] [stderr] | [INFO] [stderr] 454 | / parse!{ input; [INFO] [stderr] 455 | | keep_high() <|> keep_low() [INFO] [stderr] 456 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:471:9 [INFO] [stderr] | [INFO] [stderr] 471 | / parse!{ input; [INFO] [stderr] 472 | | let a = repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 473 | | spaces(); [INFO] [stderr] 474 | | token('+'); [INFO] [stderr] ... | [INFO] [stderr] 477 | | ret a + b; [INFO] [stderr] 478 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:471:9 [INFO] [stderr] | [INFO] [stderr] 471 | / parse!{ input; [INFO] [stderr] 472 | | let a = repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 473 | | spaces(); [INFO] [stderr] 474 | | token('+'); [INFO] [stderr] ... | [INFO] [stderr] 477 | | ret a + b; [INFO] [stderr] 478 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:471:9 [INFO] [stderr] | [INFO] [stderr] 471 | / parse!{ input; [INFO] [stderr] 472 | | let a = repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 473 | | spaces(); [INFO] [stderr] 474 | | token('+'); [INFO] [stderr] ... | [INFO] [stderr] 477 | | ret a + b; [INFO] [stderr] 478 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:471:9 [INFO] [stderr] | [INFO] [stderr] 471 | / parse!{ input; [INFO] [stderr] 472 | | let a = repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 473 | | spaces(); [INFO] [stderr] 474 | | token('+'); [INFO] [stderr] ... | [INFO] [stderr] 477 | | ret a + b; [INFO] [stderr] 478 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:483:9 [INFO] [stderr] | [INFO] [stderr] 483 | / parse!{ input; [INFO] [stderr] 484 | | let a = repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 485 | | spaces(); [INFO] [stderr] 486 | | token('-'); [INFO] [stderr] ... | [INFO] [stderr] 489 | | ret a - b; [INFO] [stderr] 490 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:483:9 [INFO] [stderr] | [INFO] [stderr] 483 | / parse!{ input; [INFO] [stderr] 484 | | let a = repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 485 | | spaces(); [INFO] [stderr] 486 | | token('-'); [INFO] [stderr] ... | [INFO] [stderr] 489 | | ret a - b; [INFO] [stderr] 490 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:483:9 [INFO] [stderr] | [INFO] [stderr] 483 | / parse!{ input; [INFO] [stderr] 484 | | let a = repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 485 | | spaces(); [INFO] [stderr] 486 | | token('-'); [INFO] [stderr] ... | [INFO] [stderr] 489 | | ret a - b; [INFO] [stderr] 490 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:483:9 [INFO] [stderr] | [INFO] [stderr] 483 | / parse!{ input; [INFO] [stderr] 484 | | let a = repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 485 | | spaces(); [INFO] [stderr] 486 | | token('-'); [INFO] [stderr] ... | [INFO] [stderr] 489 | | ret a - b; [INFO] [stderr] 490 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:495:9 [INFO] [stderr] | [INFO] [stderr] 495 | / parse!{ input; [INFO] [stderr] 496 | | let d = sum() <|> diff() <|> repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 497 | | ret d; [INFO] [stderr] 498 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:495:9 [INFO] [stderr] | [INFO] [stderr] 495 | / parse!{ input; [INFO] [stderr] 496 | | let d = sum() <|> diff() <|> repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 497 | | ret d; [INFO] [stderr] 498 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:495:9 [INFO] [stderr] | [INFO] [stderr] 495 | / parse!{ input; [INFO] [stderr] 496 | | let d = sum() <|> diff() <|> repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 497 | | ret d; [INFO] [stderr] 498 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:495:9 [INFO] [stderr] | [INFO] [stderr] 495 | / parse!{ input; [INFO] [stderr] 496 | | let d = sum() <|> diff() <|> repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 497 | | ret d; [INFO] [stderr] 498 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:495:9 [INFO] [stderr] | [INFO] [stderr] 495 | / parse!{ input; [INFO] [stderr] 496 | | let d = sum() <|> diff() <|> repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 497 | | ret d; [INFO] [stderr] 498 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:495:9 [INFO] [stderr] | [INFO] [stderr] 495 | / parse!{ input; [INFO] [stderr] 496 | | let d = sum() <|> diff() <|> repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 497 | | ret d; [INFO] [stderr] 498 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/dice.rs:159:56 [INFO] [stderr] | [INFO] [stderr] 159 | Dice::Die(n) => Roll::Die(rng.gen_range(1, (n as i64)+1)), [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/dice.rs:161:29 [INFO] [stderr] | [INFO] [stderr] 161 | let rolls = (0..n).into_iter().map(|_| dice.roll()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/dice.rs:213:17 [INFO] [stderr] | [INFO] [stderr] 213 | / if let &Dice::Die(sides) = dice.deref() { [INFO] [stderr] 214 | | write!(f, "{}d{}", n, sides) [INFO] [stderr] 215 | | } else { [INFO] [stderr] 216 | | write!(f, "{}({})", n, dice) [INFO] [stderr] 217 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 213 | if let Dice::Die(sides) = *dice.deref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/dice.rs:220:17 [INFO] [stderr] | [INFO] [stderr] 220 | / if let &Dice::Die(sides) = dice.deref() { [INFO] [stderr] 221 | | write!(f, "{}d{}{}", n, sides, modifier) [INFO] [stderr] 222 | | } else { [INFO] [stderr] 223 | | write!(f, "{}({}){}", n, dice, modifier) [INFO] [stderr] 224 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 220 | if let Dice::Die(sides) = *dice.deref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/dice.rs:309:34 [INFO] [stderr] | [INFO] [stderr] 309 | Roll::Constant(n) => n as i64, [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/dice.rs:405:50 [INFO] [stderr] | [INFO] [stderr] 405 | ret chars.fold(0, |acc, ch| 10*acc + (ch as u8 - b'0') as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(ch as u8 - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:454:9 [INFO] [stderr] | [INFO] [stderr] 454 | / parse!{ input; [INFO] [stderr] 455 | | keep_high() <|> keep_low() [INFO] [stderr] 456 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:454:9 [INFO] [stderr] | [INFO] [stderr] 454 | / parse!{ input; [INFO] [stderr] 455 | | keep_high() <|> keep_low() [INFO] [stderr] 456 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:471:9 [INFO] [stderr] | [INFO] [stderr] 471 | / parse!{ input; [INFO] [stderr] 472 | | let a = repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 473 | | spaces(); [INFO] [stderr] 474 | | token('+'); [INFO] [stderr] ... | [INFO] [stderr] 477 | | ret a + b; [INFO] [stderr] 478 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:471:9 [INFO] [stderr] | [INFO] [stderr] 471 | / parse!{ input; [INFO] [stderr] 472 | | let a = repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 473 | | spaces(); [INFO] [stderr] 474 | | token('+'); [INFO] [stderr] ... | [INFO] [stderr] 477 | | ret a + b; [INFO] [stderr] 478 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:471:9 [INFO] [stderr] | [INFO] [stderr] 471 | / parse!{ input; [INFO] [stderr] 472 | | let a = repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 473 | | spaces(); [INFO] [stderr] 474 | | token('+'); [INFO] [stderr] ... | [INFO] [stderr] 477 | | ret a + b; [INFO] [stderr] 478 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:471:9 [INFO] [stderr] | [INFO] [stderr] 471 | / parse!{ input; [INFO] [stderr] 472 | | let a = repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 473 | | spaces(); [INFO] [stderr] 474 | | token('+'); [INFO] [stderr] ... | [INFO] [stderr] 477 | | ret a + b; [INFO] [stderr] 478 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:483:9 [INFO] [stderr] | [INFO] [stderr] 483 | / parse!{ input; [INFO] [stderr] 484 | | let a = repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 485 | | spaces(); [INFO] [stderr] 486 | | token('-'); [INFO] [stderr] ... | [INFO] [stderr] 489 | | ret a - b; [INFO] [stderr] 490 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:483:9 [INFO] [stderr] | [INFO] [stderr] 483 | / parse!{ input; [INFO] [stderr] 484 | | let a = repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 485 | | spaces(); [INFO] [stderr] 486 | | token('-'); [INFO] [stderr] ... | [INFO] [stderr] 489 | | ret a - b; [INFO] [stderr] 490 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:483:9 [INFO] [stderr] | [INFO] [stderr] 483 | / parse!{ input; [INFO] [stderr] 484 | | let a = repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 485 | | spaces(); [INFO] [stderr] 486 | | token('-'); [INFO] [stderr] ... | [INFO] [stderr] 489 | | ret a - b; [INFO] [stderr] 490 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:483:9 [INFO] [stderr] | [INFO] [stderr] 483 | / parse!{ input; [INFO] [stderr] 484 | | let a = repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 485 | | spaces(); [INFO] [stderr] 486 | | token('-'); [INFO] [stderr] ... | [INFO] [stderr] 489 | | ret a - b; [INFO] [stderr] 490 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:495:9 [INFO] [stderr] | [INFO] [stderr] 495 | / parse!{ input; [INFO] [stderr] 496 | | let d = sum() <|> diff() <|> repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 497 | | ret d; [INFO] [stderr] 498 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:495:9 [INFO] [stderr] | [INFO] [stderr] 495 | / parse!{ input; [INFO] [stderr] 496 | | let d = sum() <|> diff() <|> repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 497 | | ret d; [INFO] [stderr] 498 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:495:9 [INFO] [stderr] | [INFO] [stderr] 495 | / parse!{ input; [INFO] [stderr] 496 | | let d = sum() <|> diff() <|> repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 497 | | ret d; [INFO] [stderr] 498 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:495:9 [INFO] [stderr] | [INFO] [stderr] 495 | / parse!{ input; [INFO] [stderr] 496 | | let d = sum() <|> diff() <|> repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 497 | | ret d; [INFO] [stderr] 498 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:495:9 [INFO] [stderr] | [INFO] [stderr] 495 | / parse!{ input; [INFO] [stderr] 496 | | let d = sum() <|> diff() <|> repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 497 | | ret d; [INFO] [stderr] 498 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dice.rs:495:9 [INFO] [stderr] | [INFO] [stderr] 495 | / parse!{ input; [INFO] [stderr] 496 | | let d = sum() <|> diff() <|> repeat() <|> term() <|> die() <|> constant(); [INFO] [stderr] 497 | | ret d; [INFO] [stderr] 498 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.91s [INFO] running `"docker" "inspect" "cf44dd15c0f65329c5de193edf604bdce8716692cefc1e2a6bea67dd285cba83"` [INFO] running `"docker" "rm" "-f" "cf44dd15c0f65329c5de193edf604bdce8716692cefc1e2a6bea67dd285cba83"` [INFO] [stdout] cf44dd15c0f65329c5de193edf604bdce8716692cefc1e2a6bea67dd285cba83