[INFO] updating cached repository dy-dx/rust-tictactoe-console
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/dy-dx/rust-tictactoe-console
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/dy-dx/rust-tictactoe-console" "work/ex/clippy-test-run/sources/stable/gh/dy-dx/rust-tictactoe-console"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dy-dx/rust-tictactoe-console'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/dy-dx/rust-tictactoe-console" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dy-dx/rust-tictactoe-console"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dy-dx/rust-tictactoe-console'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a11fb64c235618dd127ae8e5c02f36b9199b6e24
[INFO] sha for GitHub repo dy-dx/rust-tictactoe-console: a11fb64c235618dd127ae8e5c02f36b9199b6e24
[INFO] validating manifest of dy-dx/rust-tictactoe-console on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dy-dx/rust-tictactoe-console on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dy-dx/rust-tictactoe-console
[INFO] finished frobbing dy-dx/rust-tictactoe-console
[INFO] frobbed toml for dy-dx/rust-tictactoe-console written to work/ex/clippy-test-run/sources/stable/gh/dy-dx/rust-tictactoe-console/Cargo.toml
[INFO] started frobbing dy-dx/rust-tictactoe-console
[INFO] finished frobbing dy-dx/rust-tictactoe-console
[INFO] frobbed toml for dy-dx/rust-tictactoe-console written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dy-dx/rust-tictactoe-console/Cargo.toml
[INFO] crate dy-dx/rust-tictactoe-console has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting dy-dx/rust-tictactoe-console against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dy-dx/rust-tictactoe-console:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b4accfc3c781744cb90a922db6a5a0d1e1ef4870d5ff8130ae020825132c0003
[INFO] running `"docker" "start" "-a" "b4accfc3c781744cb90a922db6a5a0d1e1ef4870d5ff8130ae020825132c0003"`
[INFO] [stderr]     Checking tictactoe v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 |     return is_filled;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `is_filled`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:69:5
[INFO] [stderr]    |
[INFO] [stderr] 69 |     return true;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:116:5
[INFO] [stderr]     |
[INFO] [stderr] 116 |     return false;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:149:5
[INFO] [stderr]     |
[INFO] [stderr] 149 |     return did_player_win(player, board);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `did_player_win(player, board)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 |     return is_filled;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `is_filled`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:69:5
[INFO] [stderr]    |
[INFO] [stderr] 69 |     return true;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:116:5
[INFO] [stderr]     |
[INFO] [stderr] 116 |     return false;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:149:5
[INFO] [stderr]     |
[INFO] [stderr] 149 |     return did_player_win(player, board);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `did_player_win(player, board)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `board`.
[INFO] [stderr]  --> src/main.rs:5:14
[INFO] [stderr]   |
[INFO] [stderr] 5 |     for i in 0..board.len() {
[INFO] [stderr]   |              ^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]   |
[INFO] [stderr] 5 |     for <item> in &board {
[INFO] [stderr]   |         ^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `list`.
[INFO] [stderr]   --> src/main.rs:53:14
[INFO] [stderr]    |
[INFO] [stderr] 53 |     for i in 0..list.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 53 |     for <item> in &list {
[INFO] [stderr]    |         ^^^^^^    ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]   --> src/main.rs:54:12
[INFO] [stderr]    |
[INFO] [stderr] 54 |         if &list[i] != &player {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]    |
[INFO] [stderr] 54 |         if list[i] != player {
[INFO] [stderr]    |            ^^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `board`.
[INFO] [stderr]   --> src/main.rs:62:14
[INFO] [stderr]    |
[INFO] [stderr] 62 |     for i in 0..board.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 62 |     for <item> in &board {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `board`.
[INFO] [stderr]  --> src/main.rs:5:14
[INFO] [stderr]   |
[INFO] [stderr] 5 |     for i in 0..board.len() {
[INFO] [stderr]   |              ^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]   |
[INFO] [stderr] 5 |     for <item> in &board {
[INFO] [stderr]   |         ^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `list`.
[INFO] [stderr]   --> src/main.rs:53:14
[INFO] [stderr]    |
[INFO] [stderr] 53 |     for i in 0..list.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 53 |     for <item> in &list {
[INFO] [stderr]    |         ^^^^^^    ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]   --> src/main.rs:54:12
[INFO] [stderr]    |
[INFO] [stderr] 54 |         if &list[i] != &player {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]    |
[INFO] [stderr] 54 |         if list[i] != player {
[INFO] [stderr]    |            ^^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `board`.
[INFO] [stderr]   --> src/main.rs:62:14
[INFO] [stderr]    |
[INFO] [stderr] 62 |     for i in 0..board.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 62 |     for <item> in &board {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.69s
[INFO] running `"docker" "inspect" "b4accfc3c781744cb90a922db6a5a0d1e1ef4870d5ff8130ae020825132c0003"`
[INFO] running `"docker" "rm" "-f" "b4accfc3c781744cb90a922db6a5a0d1e1ef4870d5ff8130ae020825132c0003"`
[INFO] [stdout] b4accfc3c781744cb90a922db6a5a0d1e1ef4870d5ff8130ae020825132c0003