[INFO] updating cached repository dusty-phillips/rust-rsa [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dusty-phillips/rust-rsa [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dusty-phillips/rust-rsa" "work/ex/clippy-test-run/sources/stable/gh/dusty-phillips/rust-rsa"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dusty-phillips/rust-rsa'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dusty-phillips/rust-rsa" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dusty-phillips/rust-rsa"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dusty-phillips/rust-rsa'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4e717b77994d8db55a07bd7ebd02a86d7b6d1afa [INFO] sha for GitHub repo dusty-phillips/rust-rsa: 4e717b77994d8db55a07bd7ebd02a86d7b6d1afa [INFO] validating manifest of dusty-phillips/rust-rsa on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dusty-phillips/rust-rsa on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dusty-phillips/rust-rsa [INFO] finished frobbing dusty-phillips/rust-rsa [INFO] frobbed toml for dusty-phillips/rust-rsa written to work/ex/clippy-test-run/sources/stable/gh/dusty-phillips/rust-rsa/Cargo.toml [INFO] started frobbing dusty-phillips/rust-rsa [INFO] finished frobbing dusty-phillips/rust-rsa [INFO] frobbed toml for dusty-phillips/rust-rsa written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dusty-phillips/rust-rsa/Cargo.toml [INFO] crate dusty-phillips/rust-rsa has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dusty-phillips/rust-rsa against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dusty-phillips/rust-rsa:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 32afad9968e510c6c804fe86dafc4d5b742dcecfcdb24af9f32d5c9b99cabc40 [INFO] running `"docker" "start" "-a" "32afad9968e510c6c804fe86dafc4d5b742dcecfcdb24af9f32d5c9b99cabc40"` [INFO] [stderr] Compiling num-bigint v0.2.0 [INFO] [stderr] Checking rsa_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | let mut r: BigInt; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | let mut s: BigInt; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | let f = u.bits() - v.bits(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | let mut r: BigInt; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | let mut s: BigInt; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | let f = u.bits() - v.bits(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | odd_factor = odd_factor / two; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `odd_factor /= two` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/main.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | modulus: modulus, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `modulus` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/main.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | pub_exponent: pub_exponent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pub_exponent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/main.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | priv_exponent: priv_exponent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `priv_exponent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/main.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | modulus: modulus, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `modulus` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/main.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | pub_exponent: pub_exponent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pub_exponent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/main.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | priv_exponent: priv_exponent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `priv_exponent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | odd_factor = odd_factor / two; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `odd_factor /= two` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.07s [INFO] running `"docker" "inspect" "32afad9968e510c6c804fe86dafc4d5b742dcecfcdb24af9f32d5c9b99cabc40"` [INFO] running `"docker" "rm" "-f" "32afad9968e510c6c804fe86dafc4d5b742dcecfcdb24af9f32d5c9b99cabc40"` [INFO] [stdout] 32afad9968e510c6c804fe86dafc4d5b742dcecfcdb24af9f32d5c9b99cabc40