[INFO] updating cached repository dsxragnarok/rusty-dice [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dsxragnarok/rusty-dice [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dsxragnarok/rusty-dice" "work/ex/clippy-test-run/sources/stable/gh/dsxragnarok/rusty-dice"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dsxragnarok/rusty-dice'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dsxragnarok/rusty-dice" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dsxragnarok/rusty-dice"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dsxragnarok/rusty-dice'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a24654115d20c7eff03f3dd2fb6ac40642bf27d5 [INFO] sha for GitHub repo dsxragnarok/rusty-dice: a24654115d20c7eff03f3dd2fb6ac40642bf27d5 [INFO] validating manifest of dsxragnarok/rusty-dice on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dsxragnarok/rusty-dice on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dsxragnarok/rusty-dice [INFO] finished frobbing dsxragnarok/rusty-dice [INFO] frobbed toml for dsxragnarok/rusty-dice written to work/ex/clippy-test-run/sources/stable/gh/dsxragnarok/rusty-dice/Cargo.toml [INFO] started frobbing dsxragnarok/rusty-dice [INFO] finished frobbing dsxragnarok/rusty-dice [INFO] frobbed toml for dsxragnarok/rusty-dice written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dsxragnarok/rusty-dice/Cargo.toml [INFO] crate dsxragnarok/rusty-dice has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dsxragnarok/rusty-dice against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dsxragnarok/rusty-dice:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e39e00152a797f91934997c02b52f137e5214a4dcc8b6f05f172240806c1ce91 [INFO] running `"docker" "start" "-a" "e39e00152a797f91934997c02b52f137e5214a4dcc8b6f05f172240806c1ce91"` [INFO] [stderr] Checking rustydice v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dice.rs:67:22 [INFO] [stderr] | [INFO] [stderr] 67 | Ok(i) => return Self::try_from(i), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self::try_from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dice.rs:68:23 [INFO] [stderr] | [INFO] [stderr] 68 | Err(e) => return Err(Error::from(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::from(e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dice.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / return match sides { [INFO] [stderr] 76 | | 2 => Die::D2, [INFO] [stderr] 77 | | 4 => Die::D4, [INFO] [stderr] 78 | | 6 => Die::D6, [INFO] [stderr] ... | [INFO] [stderr] 84 | | _ => panic!("Unable to match the die type"), [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 75 | match sides { [INFO] [stderr] 76 | 2 => Die::D2, [INFO] [stderr] 77 | 4 => Die::D4, [INFO] [stderr] 78 | 6 => Die::D6, [INFO] [stderr] 79 | 8 => Die::D8, [INFO] [stderr] 80 | 10 => Die::D10, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `TimeZone` [INFO] [stderr] --> src/logger.rs:1:31 [INFO] [stderr] | [INFO] [stderr] 1 | use chrono::{DateTime, Local, TimeZone}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dice.rs:67:22 [INFO] [stderr] | [INFO] [stderr] 67 | Ok(i) => return Self::try_from(i), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self::try_from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dice.rs:68:23 [INFO] [stderr] | [INFO] [stderr] 68 | Err(e) => return Err(Error::from(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::from(e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dice.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / return match sides { [INFO] [stderr] 76 | | 2 => Die::D2, [INFO] [stderr] 77 | | 4 => Die::D4, [INFO] [stderr] 78 | | 6 => Die::D6, [INFO] [stderr] ... | [INFO] [stderr] 84 | | _ => panic!("Unable to match the die type"), [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 75 | match sides { [INFO] [stderr] 76 | 2 => Die::D2, [INFO] [stderr] 77 | 4 => Die::D4, [INFO] [stderr] 78 | 6 => Die::D6, [INFO] [stderr] 79 | 8 => Die::D8, [INFO] [stderr] 80 | 10 => Die::D10, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `TimeZone` [INFO] [stderr] --> src/logger.rs:1:31 [INFO] [stderr] | [INFO] [stderr] 1 | use chrono::{DateTime, Local, TimeZone}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/bin/main.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | fn single_process_mode(ref mut args: env::Args) { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bin/main.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | let ref mut file_result = match logfile { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 41 | let file_result = &mut (match logfile { [INFO] [stderr] 42 | Some(path) => Ok(File::create(path).expect("Unable to create file")), [INFO] [stderr] 43 | None => Err("No file specified"), [INFO] [stderr] 44 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/main.rs:84:24 [INFO] [stderr] | [INFO] [stderr] 84 | fn execute_roll(query: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/bin/main.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | fn single_process_mode(ref mut args: env::Args) { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bin/main.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | let ref mut file_result = match logfile { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 41 | let file_result = &mut (match logfile { [INFO] [stderr] 42 | Some(path) => Ok(File::create(path).expect("Unable to create file")), [INFO] [stderr] 43 | None => Err("No file specified"), [INFO] [stderr] 44 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/main.rs:84:24 [INFO] [stderr] | [INFO] [stderr] 84 | fn execute_roll(query: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.57s [INFO] running `"docker" "inspect" "e39e00152a797f91934997c02b52f137e5214a4dcc8b6f05f172240806c1ce91"` [INFO] running `"docker" "rm" "-f" "e39e00152a797f91934997c02b52f137e5214a4dcc8b6f05f172240806c1ce91"` [INFO] [stdout] e39e00152a797f91934997c02b52f137e5214a4dcc8b6f05f172240806c1ce91