[INFO] updating cached repository dsvensson/sparsnas-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dsvensson/sparsnas-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dsvensson/sparsnas-rs" "work/ex/clippy-test-run/sources/stable/gh/dsvensson/sparsnas-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dsvensson/sparsnas-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dsvensson/sparsnas-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dsvensson/sparsnas-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dsvensson/sparsnas-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f43337a066c6bb0659c189e582f9ffcafe1ca79e [INFO] sha for GitHub repo dsvensson/sparsnas-rs: f43337a066c6bb0659c189e582f9ffcafe1ca79e [INFO] validating manifest of dsvensson/sparsnas-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dsvensson/sparsnas-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dsvensson/sparsnas-rs [INFO] finished frobbing dsvensson/sparsnas-rs [INFO] frobbed toml for dsvensson/sparsnas-rs written to work/ex/clippy-test-run/sources/stable/gh/dsvensson/sparsnas-rs/Cargo.toml [INFO] started frobbing dsvensson/sparsnas-rs [INFO] finished frobbing dsvensson/sparsnas-rs [INFO] frobbed toml for dsvensson/sparsnas-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dsvensson/sparsnas-rs/Cargo.toml [INFO] crate dsvensson/sparsnas-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dsvensson/sparsnas-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dsvensson/sparsnas-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8db58f3e9a080d93cd94473b892d5ed1a0685de7049783322a4d9a1adb728583 [INFO] running `"docker" "start" "-a" "8db58f3e9a080d93cd94473b892d5ed1a0685de7049783322a4d9a1adb728583"` [INFO] [stderr] Checking nb v0.1.1 [INFO] [stderr] Checking cast v0.2.2 [INFO] [stderr] Compiling serde v1.0.68 [INFO] [stderr] Compiling nix v0.6.0 [INFO] [stderr] Compiling syn v0.14.3 [INFO] [stderr] Checking nix v0.10.0 [INFO] [stderr] Compiling error-chain v0.11.0 [INFO] [stderr] Checking embedded-hal v0.2.1 [INFO] [stderr] Checking cc1101 v0.0.3 [INFO] [stderr] Checking spidev v0.3.0 [INFO] [stderr] Compiling serde_derive v1.0.68 [INFO] [stderr] Checking sysfs_gpio v0.5.3 [INFO] [stderr] Compiling serde_json v1.0.22 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling cargo_metadata v0.5.6 [INFO] [stderr] Compiling skeptic v0.13.3 [INFO] [stderr] Compiling i2cdev v0.3.2 [INFO] [stderr] Checking linux-embedded-hal v0.2.0 [INFO] [stderr] Checking sparsnas v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | 3686400 / avg as u32 [INFO] [stderr] | ^^^^^^^ help: consider: `3_686_400` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/iterreader.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 8 | for in &mut buf { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:74:19 [INFO] [stderr] | [INFO] [stderr] 74 | 3686400 / avg as u32 [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(avg)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | 3686400 / avg as u32 [INFO] [stderr] | ^^^^^^^ help: consider: `3_686_400` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/iterreader.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 8 | for in &mut buf { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:74:19 [INFO] [stderr] | [INFO] [stderr] 74 | 3686400 / avg as u32 [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(avg)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 44.58s [INFO] running `"docker" "inspect" "8db58f3e9a080d93cd94473b892d5ed1a0685de7049783322a4d9a1adb728583"` [INFO] running `"docker" "rm" "-f" "8db58f3e9a080d93cd94473b892d5ed1a0685de7049783322a4d9a1adb728583"` [INFO] [stdout] 8db58f3e9a080d93cd94473b892d5ed1a0685de7049783322a4d9a1adb728583