[INFO] updating cached repository drozdziak1/rust-junk [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/drozdziak1/rust-junk [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/drozdziak1/rust-junk" "work/ex/clippy-test-run/sources/stable/gh/drozdziak1/rust-junk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/drozdziak1/rust-junk'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/drozdziak1/rust-junk" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/drozdziak1/rust-junk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/drozdziak1/rust-junk'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 527cc9d9cedeb469e8ed9101161c088b5967661a [INFO] sha for GitHub repo drozdziak1/rust-junk: 527cc9d9cedeb469e8ed9101161c088b5967661a [INFO] validating manifest of drozdziak1/rust-junk on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of drozdziak1/rust-junk on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing drozdziak1/rust-junk [INFO] finished frobbing drozdziak1/rust-junk [INFO] frobbed toml for drozdziak1/rust-junk written to work/ex/clippy-test-run/sources/stable/gh/drozdziak1/rust-junk/Cargo.toml [INFO] started frobbing drozdziak1/rust-junk [INFO] finished frobbing drozdziak1/rust-junk [INFO] frobbed toml for drozdziak1/rust-junk written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/drozdziak1/rust-junk/Cargo.toml [INFO] crate drozdziak1/rust-junk has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting drozdziak1/rust-junk against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/drozdziak1/rust-junk:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b404959a9e2d8d6c9ff9ee88e1109fd3d4a07f6ed01b848e77f4aba90b616278 [INFO] running `"docker" "start" "-a" "b404959a9e2d8d6c9ff9ee88e1109fd3d4a07f6ed01b848e77f4aba90b616278"` [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking net2 v0.2.29 [INFO] [stderr] Compiling libsqlite3-sys v0.8.1 [INFO] [stderr] Checking tokio-timer v0.1.2 [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking rpassword v0.4.0 [INFO] [stderr] Checking mio v0.6.9 [INFO] [stderr] Checking rusqlite v0.12.0 [INFO] [stderr] Checking tokio-core v0.1.8 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking rust-junk v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/fizzbuzz/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/sdencrypt/main.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/sdencrypt/main.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/sdencrypt/main.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/sdencrypt/main.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/sdencrypt/main.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/sdencrypt/main.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/fizzbuzz/main.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | / let mut done = false; [INFO] [stderr] 4 | | if i % 3 == 0 { [INFO] [stderr] 5 | | print!("Fizz"); [INFO] [stderr] 6 | | done = true; [INFO] [stderr] 7 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let done = if i % 3 == 0 { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/rock_paper_scissors/main.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/fizzbuzz/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/sdencrypt/main.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/sdencrypt/main.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/sdencrypt/main.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/sdencrypt/main.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/sdencrypt/main.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/sdencrypt/main.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ff_stats/reports.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn ten_last_visits<'a>(conn: &'a Connection) -> Statement { [INFO] [stderr] 10 | | [INFO] [stderr] 11 | | conn.prepare( [INFO] [stderr] 12 | | " [INFO] [stderr] ... | [INFO] [stderr] 25 | | }) [INFO] [stderr] 26 | | } [INFO] [stderr] | |_^ [INFO] [stderr] warning: The function/method `extend_from_slice` doesn't need a mutable reference [INFO] [stderr] --> src/sdencrypt/pkcs7.rs:45:48 [INFO] [stderr] | [INFO] [stderr] 45 | data.extend_from_slice(&mut popped_bytes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `extend_from_slice` doesn't need a mutable reference [INFO] [stderr] --> src/sdencrypt/pkcs7.rs:65:48 [INFO] [stderr] | [INFO] [stderr] 65 | data.extend_from_slice(&mut popped_bytes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: The function/method `extend_from_slice` doesn't need a mutable reference [INFO] [stderr] --> src/sdencrypt/main.rs:104:37 [INFO] [stderr] | [INFO] [stderr] 104 | encrypted.extend_from_slice(&mut current_cipher_block); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `extend_from_slice` doesn't need a mutable reference [INFO] [stderr] --> src/sdencrypt/main.rs:118:37 [INFO] [stderr] | [INFO] [stderr] 118 | decrypted.extend_from_slice(&mut current_plain_block); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/sdencrypt/main.rs:125:12 [INFO] [stderr] | [INFO] [stderr] 125 | if let Err(_) = unpad_pkcs7(&mut decrypted, block_size) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 126 | | println!("Malformed ciphertext padding! Exiting..."); [INFO] [stderr] 127 | | process::exit(1); [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____- help: try this: `if unpad_pkcs7(&mut decrypted, block_size).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/fizzbuzz/main.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | / let mut done = false; [INFO] [stderr] 4 | | if i % 3 == 0 { [INFO] [stderr] 5 | | print!("Fizz"); [INFO] [stderr] 6 | | done = true; [INFO] [stderr] 7 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let done = if i % 3 == 0 { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/rock_paper_scissors/main.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ff_stats/reports.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn ten_last_visits<'a>(conn: &'a Connection) -> Statement { [INFO] [stderr] 10 | | [INFO] [stderr] 11 | | conn.prepare( [INFO] [stderr] 12 | | " [INFO] [stderr] ... | [INFO] [stderr] 25 | | }) [INFO] [stderr] 26 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: The function/method `extend_from_slice` doesn't need a mutable reference [INFO] [stderr] --> src/sdencrypt/pkcs7.rs:45:48 [INFO] [stderr] | [INFO] [stderr] 45 | data.extend_from_slice(&mut popped_bytes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `extend_from_slice` doesn't need a mutable reference [INFO] [stderr] --> src/sdencrypt/pkcs7.rs:65:48 [INFO] [stderr] | [INFO] [stderr] 65 | data.extend_from_slice(&mut popped_bytes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `extend_from_slice` doesn't need a mutable reference [INFO] [stderr] --> src/sdencrypt/main.rs:104:37 [INFO] [stderr] | [INFO] [stderr] 104 | encrypted.extend_from_slice(&mut current_cipher_block); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `extend_from_slice` doesn't need a mutable reference [INFO] [stderr] --> src/sdencrypt/main.rs:118:37 [INFO] [stderr] | [INFO] [stderr] 118 | decrypted.extend_from_slice(&mut current_plain_block); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/sdencrypt/main.rs:125:12 [INFO] [stderr] | [INFO] [stderr] 125 | if let Err(_) = unpad_pkcs7(&mut decrypted, block_size) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 126 | | println!("Malformed ciphertext padding! Exiting..."); [INFO] [stderr] 127 | | process::exit(1); [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____- help: try this: `if unpad_pkcs7(&mut decrypted, block_size).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.33s [INFO] running `"docker" "inspect" "b404959a9e2d8d6c9ff9ee88e1109fd3d4a07f6ed01b848e77f4aba90b616278"` [INFO] running `"docker" "rm" "-f" "b404959a9e2d8d6c9ff9ee88e1109fd3d4a07f6ed01b848e77f4aba90b616278"` [INFO] [stdout] b404959a9e2d8d6c9ff9ee88e1109fd3d4a07f6ed01b848e77f4aba90b616278