[INFO] updating cached repository drgomesp/oxiboy [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/drgomesp/oxiboy [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/drgomesp/oxiboy" "work/ex/clippy-test-run/sources/stable/gh/drgomesp/oxiboy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/drgomesp/oxiboy'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/drgomesp/oxiboy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/drgomesp/oxiboy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/drgomesp/oxiboy'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0401ef759769a2a95ad33ae16453c8642262d64c [INFO] sha for GitHub repo drgomesp/oxiboy: 0401ef759769a2a95ad33ae16453c8642262d64c [INFO] validating manifest of drgomesp/oxiboy on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of drgomesp/oxiboy on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing drgomesp/oxiboy [INFO] finished frobbing drgomesp/oxiboy [INFO] frobbed toml for drgomesp/oxiboy written to work/ex/clippy-test-run/sources/stable/gh/drgomesp/oxiboy/Cargo.toml [INFO] started frobbing drgomesp/oxiboy [INFO] finished frobbing drgomesp/oxiboy [INFO] frobbed toml for drgomesp/oxiboy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/drgomesp/oxiboy/Cargo.toml [INFO] crate drgomesp/oxiboy has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting drgomesp/oxiboy against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/drgomesp/oxiboy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1fa9732ecb19973e443d3b943f3a1c4eef9c94aefd45d54a0355bcc984dfc47f [INFO] running `"docker" "start" "-a" "1fa9732ecb19973e443d3b943f3a1c4eef9c94aefd45d54a0355bcc984dfc47f"` [INFO] [stderr] Checking oxiboy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:76:21 [INFO] [stderr] | [INFO] [stderr] 76 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:93:21 [INFO] [stderr] | [INFO] [stderr] 93 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:102:21 [INFO] [stderr] | [INFO] [stderr] 102 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:110:21 [INFO] [stderr] | [INFO] [stderr] 110 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:118:21 [INFO] [stderr] | [INFO] [stderr] 118 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:127:21 [INFO] [stderr] | [INFO] [stderr] 127 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:136:21 [INFO] [stderr] | [INFO] [stderr] 136 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:145:21 [INFO] [stderr] | [INFO] [stderr] 145 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:154:21 [INFO] [stderr] | [INFO] [stderr] 154 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:163:21 [INFO] [stderr] | [INFO] [stderr] 163 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:171:21 [INFO] [stderr] | [INFO] [stderr] 171 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:180:21 [INFO] [stderr] | [INFO] [stderr] 180 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:189:21 [INFO] [stderr] | [INFO] [stderr] 189 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:198:21 [INFO] [stderr] | [INFO] [stderr] 198 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:206:21 [INFO] [stderr] | [INFO] [stderr] 206 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:215:21 [INFO] [stderr] | [INFO] [stderr] 215 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:224:21 [INFO] [stderr] | [INFO] [stderr] 224 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:233:21 [INFO] [stderr] | [INFO] [stderr] 233 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:241:21 [INFO] [stderr] | [INFO] [stderr] 241 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:250:21 [INFO] [stderr] | [INFO] [stderr] 250 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:259:21 [INFO] [stderr] | [INFO] [stderr] 259 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:267:21 [INFO] [stderr] | [INFO] [stderr] 267 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:275:21 [INFO] [stderr] | [INFO] [stderr] 275 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:283:21 [INFO] [stderr] | [INFO] [stderr] 283 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:292:21 [INFO] [stderr] | [INFO] [stderr] 292 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:300:21 [INFO] [stderr] | [INFO] [stderr] 300 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:309:21 [INFO] [stderr] | [INFO] [stderr] 309 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:318:21 [INFO] [stderr] | [INFO] [stderr] 318 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:326:21 [INFO] [stderr] | [INFO] [stderr] 326 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:334:21 [INFO] [stderr] | [INFO] [stderr] 334 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:342:21 [INFO] [stderr] | [INFO] [stderr] 342 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:350:21 [INFO] [stderr] | [INFO] [stderr] 350 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:359:21 [INFO] [stderr] | [INFO] [stderr] 359 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:368:21 [INFO] [stderr] | [INFO] [stderr] 368 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:377:21 [INFO] [stderr] | [INFO] [stderr] 377 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:386:21 [INFO] [stderr] | [INFO] [stderr] 386 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:394:21 [INFO] [stderr] | [INFO] [stderr] 394 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:416:21 [INFO] [stderr] | [INFO] [stderr] 416 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:425:21 [INFO] [stderr] | [INFO] [stderr] 425 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/interconnect.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | bootrom: bootrom, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `bootrom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:76:21 [INFO] [stderr] | [INFO] [stderr] 76 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:93:21 [INFO] [stderr] | [INFO] [stderr] 93 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:102:21 [INFO] [stderr] | [INFO] [stderr] 102 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:110:21 [INFO] [stderr] | [INFO] [stderr] 110 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:118:21 [INFO] [stderr] | [INFO] [stderr] 118 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:127:21 [INFO] [stderr] | [INFO] [stderr] 127 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:136:21 [INFO] [stderr] | [INFO] [stderr] 136 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:145:21 [INFO] [stderr] | [INFO] [stderr] 145 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:154:21 [INFO] [stderr] | [INFO] [stderr] 154 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:163:21 [INFO] [stderr] | [INFO] [stderr] 163 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:171:21 [INFO] [stderr] | [INFO] [stderr] 171 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:180:21 [INFO] [stderr] | [INFO] [stderr] 180 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:189:21 [INFO] [stderr] | [INFO] [stderr] 189 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:198:21 [INFO] [stderr] | [INFO] [stderr] 198 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:206:21 [INFO] [stderr] | [INFO] [stderr] 206 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:215:21 [INFO] [stderr] | [INFO] [stderr] 215 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:224:21 [INFO] [stderr] | [INFO] [stderr] 224 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:233:21 [INFO] [stderr] | [INFO] [stderr] 233 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:241:21 [INFO] [stderr] | [INFO] [stderr] 241 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:250:21 [INFO] [stderr] | [INFO] [stderr] 250 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:259:21 [INFO] [stderr] | [INFO] [stderr] 259 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:267:21 [INFO] [stderr] | [INFO] [stderr] 267 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:275:21 [INFO] [stderr] | [INFO] [stderr] 275 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:283:21 [INFO] [stderr] | [INFO] [stderr] 283 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:292:21 [INFO] [stderr] | [INFO] [stderr] 292 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:300:21 [INFO] [stderr] | [INFO] [stderr] 300 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:309:21 [INFO] [stderr] | [INFO] [stderr] 309 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:318:21 [INFO] [stderr] | [INFO] [stderr] 318 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:326:21 [INFO] [stderr] | [INFO] [stderr] 326 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:334:21 [INFO] [stderr] | [INFO] [stderr] 334 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:342:21 [INFO] [stderr] | [INFO] [stderr] 342 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:350:21 [INFO] [stderr] | [INFO] [stderr] 350 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:359:21 [INFO] [stderr] | [INFO] [stderr] 359 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:368:21 [INFO] [stderr] | [INFO] [stderr] 368 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:377:21 [INFO] [stderr] | [INFO] [stderr] 377 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:386:21 [INFO] [stderr] | [INFO] [stderr] 386 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:394:21 [INFO] [stderr] | [INFO] [stderr] 394 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:416:21 [INFO] [stderr] | [INFO] [stderr] 416 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:425:21 [INFO] [stderr] | [INFO] [stderr] 425 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy/hardware/interconnect.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | bootrom: bootrom, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `bootrom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `AF` [INFO] [stderr] --> src/gameboy/hardware/cpu/registers.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | AF, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `VBlank` [INFO] [stderr] --> src/gameboy/hardware/ppu/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | VBlank, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `scroll_x` [INFO] [stderr] --> src/gameboy/hardware/ppu/mod.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | scroll_x: u8, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_scroll_y` [INFO] [stderr] --> src/gameboy/hardware/ppu/mod.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn get_scroll_y(&self) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gameboy/hardware/cpu/instructions.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn check(&self, flags: Flags) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gameboy/hardware/cpu/registers.rs:13:26 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn self_or_empty(&self, test: bool) -> Flags { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/registers.rs:107:20 [INFO] [stderr] | [INFO] [stderr] 107 | AF => ((self.a as u16) << 8) | (self.f.bits() as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/registers.rs:107:44 [INFO] [stderr] | [INFO] [stderr] 107 | AF => ((self.a as u16) << 8) | (self.f.bits() as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.f.bits())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/registers.rs:108:20 [INFO] [stderr] | [INFO] [stderr] 108 | BC => ((self.b as u16) << 8) | (self.c as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/registers.rs:108:44 [INFO] [stderr] | [INFO] [stderr] 108 | BC => ((self.b as u16) << 8) | (self.c as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/registers.rs:109:20 [INFO] [stderr] | [INFO] [stderr] 109 | DE => ((self.d as u16) << 8) | (self.e as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/registers.rs:109:44 [INFO] [stderr] | [INFO] [stderr] 109 | DE => ((self.d as u16) << 8) | (self.e as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/registers.rs:110:20 [INFO] [stderr] | [INFO] [stderr] 110 | HL => ((self.h as u16) << 8) | (self.l as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/registers.rs:110:44 [INFO] [stderr] | [INFO] [stderr] 110 | HL => ((self.h as u16) << 8) | (self.l as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:41:10 [INFO] [stderr] | [INFO] [stderr] 41 | ((h as u16) << 8) | (l as u16) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:41:29 [INFO] [stderr] | [INFO] [stderr] 41 | ((h as u16) << 8) | (l as u16) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:65:10 [INFO] [stderr] | [INFO] [stderr] 65 | ((h as u16) << 8 | (l as u16)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:65:28 [INFO] [stderr] | [INFO] [stderr] 65 | ((h as u16) << 8 | (l as u16)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:476:47 [INFO] [stderr] | [INFO] [stderr] 476 | | Flags::HALF_CARRY.self_or_empty(val & 0xf == 0) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `val.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] error: this boolean expression contains a logic bug [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:503:28 [INFO] [stderr] | [INFO] [stderr] 503 | let carry_val = if false && cpu.registers.f.contains(Flags::CARRY) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: it would look like the following: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::logic_bug)] on by default [INFO] [stderr] help: this expression can be optimized out by applying boolean operations to the outer expression [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:503:37 [INFO] [stderr] | [INFO] [stderr] 503 | let carry_val = if false && cpu.registers.f.contains(Flags::CARRY) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:513:42 [INFO] [stderr] | [INFO] [stderr] 513 | | Flags::CARRY.self_or_empty((reg_val as u16) < (val as u16) + (carry_val as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(reg_val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:513:61 [INFO] [stderr] | [INFO] [stderr] 513 | | Flags::CARRY.self_or_empty((reg_val as u16) < (val as u16) + (carry_val as u16)) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:513:76 [INFO] [stderr] | [INFO] [stderr] 513 | | Flags::CARRY.self_or_empty((reg_val as u16) < (val as u16) + (carry_val as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(carry_val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:521:34 [INFO] [stderr] | [INFO] [stderr] 521 | Src::PagedA8(val) => bus.read(0xFF00u16 | (val as u16)) as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(bus.read(0xFF00u16 | (val as u16)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:521:55 [INFO] [stderr] | [INFO] [stderr] 521 | Src::PagedA8(val) => bus.read(0xFF00u16 | (val as u16)) as u16, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:522:29 [INFO] [stderr] | [INFO] [stderr] 522 | Src::D8(val) => val as u16, [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:524:31 [INFO] [stderr] | [INFO] [stderr] 524 | Src::Reg8(reg) => cpu.registers.read8(reg) as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.registers.read8(reg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:530:40 [INFO] [stderr] | [INFO] [stderr] 530 | let addr = 0xFF00u16 | val as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:535:40 [INFO] [stderr] | [INFO] [stderr] 535 | let addr = 0xFF00u16 | cpu.registers.read8(reg) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.registers.read8(reg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `^` [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:556:35 [INFO] [stderr] | [INFO] [stderr] 556 | cpu.registers.write8(reg, v ^ v); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `AF` [INFO] [stderr] --> src/gameboy/hardware/cpu/registers.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | AF, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `VBlank` [INFO] [stderr] --> src/gameboy/hardware/ppu/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | VBlank, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `scroll_x` [INFO] [stderr] --> src/gameboy/hardware/ppu/mod.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | scroll_x: u8, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_scroll_y` [INFO] [stderr] --> src/gameboy/hardware/ppu/mod.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn get_scroll_y(&self) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gameboy/hardware/cpu/instructions.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn check(&self, flags: Flags) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `oxiboy`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gameboy/hardware/cpu/registers.rs:13:26 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn self_or_empty(&self, test: bool) -> Flags { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/registers.rs:107:20 [INFO] [stderr] | [INFO] [stderr] 107 | AF => ((self.a as u16) << 8) | (self.f.bits() as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/registers.rs:107:44 [INFO] [stderr] | [INFO] [stderr] 107 | AF => ((self.a as u16) << 8) | (self.f.bits() as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.f.bits())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/registers.rs:108:20 [INFO] [stderr] | [INFO] [stderr] 108 | BC => ((self.b as u16) << 8) | (self.c as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/registers.rs:108:44 [INFO] [stderr] | [INFO] [stderr] 108 | BC => ((self.b as u16) << 8) | (self.c as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/registers.rs:109:20 [INFO] [stderr] | [INFO] [stderr] 109 | DE => ((self.d as u16) << 8) | (self.e as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/registers.rs:109:44 [INFO] [stderr] | [INFO] [stderr] 109 | DE => ((self.d as u16) << 8) | (self.e as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/registers.rs:110:20 [INFO] [stderr] | [INFO] [stderr] 110 | HL => ((self.h as u16) << 8) | (self.l as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/registers.rs:110:44 [INFO] [stderr] | [INFO] [stderr] 110 | HL => ((self.h as u16) << 8) | (self.l as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:41:10 [INFO] [stderr] | [INFO] [stderr] 41 | ((h as u16) << 8) | (l as u16) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:41:29 [INFO] [stderr] | [INFO] [stderr] 41 | ((h as u16) << 8) | (l as u16) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:65:10 [INFO] [stderr] | [INFO] [stderr] 65 | ((h as u16) << 8 | (l as u16)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:65:28 [INFO] [stderr] | [INFO] [stderr] 65 | ((h as u16) << 8 | (l as u16)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:476:47 [INFO] [stderr] | [INFO] [stderr] 476 | | Flags::HALF_CARRY.self_or_empty(val & 0xf == 0) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `val.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] error: this boolean expression contains a logic bug [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:503:28 [INFO] [stderr] | [INFO] [stderr] 503 | let carry_val = if false && cpu.registers.f.contains(Flags::CARRY) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: it would look like the following: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::logic_bug)] on by default [INFO] [stderr] help: this expression can be optimized out by applying boolean operations to the outer expression [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:503:37 [INFO] [stderr] | [INFO] [stderr] 503 | let carry_val = if false && cpu.registers.f.contains(Flags::CARRY) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:513:42 [INFO] [stderr] | [INFO] [stderr] 513 | | Flags::CARRY.self_or_empty((reg_val as u16) < (val as u16) + (carry_val as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(reg_val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:513:61 [INFO] [stderr] | [INFO] [stderr] 513 | | Flags::CARRY.self_or_empty((reg_val as u16) < (val as u16) + (carry_val as u16)) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:513:76 [INFO] [stderr] | [INFO] [stderr] 513 | | Flags::CARRY.self_or_empty((reg_val as u16) < (val as u16) + (carry_val as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(carry_val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:521:34 [INFO] [stderr] | [INFO] [stderr] 521 | Src::PagedA8(val) => bus.read(0xFF00u16 | (val as u16)) as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(bus.read(0xFF00u16 | (val as u16)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:521:55 [INFO] [stderr] | [INFO] [stderr] 521 | Src::PagedA8(val) => bus.read(0xFF00u16 | (val as u16)) as u16, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:522:29 [INFO] [stderr] | [INFO] [stderr] 522 | Src::D8(val) => val as u16, [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:524:31 [INFO] [stderr] | [INFO] [stderr] 524 | Src::Reg8(reg) => cpu.registers.read8(reg) as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.registers.read8(reg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:530:40 [INFO] [stderr] | [INFO] [stderr] 530 | let addr = 0xFF00u16 | val as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:535:40 [INFO] [stderr] | [INFO] [stderr] 535 | let addr = 0xFF00u16 | cpu.registers.read8(reg) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.registers.read8(reg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `^` [INFO] [stderr] --> src/gameboy/hardware/cpu/mod.rs:556:35 [INFO] [stderr] | [INFO] [stderr] 556 | cpu.registers.write8(reg, v ^ v); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `oxiboy`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "1fa9732ecb19973e443d3b943f3a1c4eef9c94aefd45d54a0355bcc984dfc47f"` [INFO] running `"docker" "rm" "-f" "1fa9732ecb19973e443d3b943f3a1c4eef9c94aefd45d54a0355bcc984dfc47f"` [INFO] [stdout] 1fa9732ecb19973e443d3b943f3a1c4eef9c94aefd45d54a0355bcc984dfc47f