[INFO] updating cached repository drew-wallace/sudoku-solver-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/drew-wallace/sudoku-solver-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/drew-wallace/sudoku-solver-rust" "work/ex/clippy-test-run/sources/stable/gh/drew-wallace/sudoku-solver-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/drew-wallace/sudoku-solver-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/drew-wallace/sudoku-solver-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/drew-wallace/sudoku-solver-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/drew-wallace/sudoku-solver-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e34672316843f53dd4c955efd5cc2ad71f67c0cc [INFO] sha for GitHub repo drew-wallace/sudoku-solver-rust: e34672316843f53dd4c955efd5cc2ad71f67c0cc [INFO] validating manifest of drew-wallace/sudoku-solver-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of drew-wallace/sudoku-solver-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing drew-wallace/sudoku-solver-rust [INFO] finished frobbing drew-wallace/sudoku-solver-rust [INFO] frobbed toml for drew-wallace/sudoku-solver-rust written to work/ex/clippy-test-run/sources/stable/gh/drew-wallace/sudoku-solver-rust/Cargo.toml [INFO] started frobbing drew-wallace/sudoku-solver-rust [INFO] finished frobbing drew-wallace/sudoku-solver-rust [INFO] frobbed toml for drew-wallace/sudoku-solver-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/drew-wallace/sudoku-solver-rust/Cargo.toml [INFO] crate drew-wallace/sudoku-solver-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting drew-wallace/sudoku-solver-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/drew-wallace/sudoku-solver-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a3aac56af4b667c14ed7b2d8237acd8842fe084a39d2e40854f3925a0e777e9b [INFO] running `"docker" "start" "-a" "a3aac56af4b667c14ed7b2d8237acd8842fe084a39d2e40854f3925a0e777e9b"` [INFO] [stderr] Checking sudoku-solver-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | grid: grid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(file, "")` [INFO] [stderr] --> src/lib.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | writeln!(file, "").expect("Couldn't write"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(file)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | grid: grid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(file, "")` [INFO] [stderr] --> src/lib.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | writeln!(file, "").expect("Couldn't write"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(file)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | return 1; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:311:9 [INFO] [stderr] | [INFO] [stderr] 311 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:335:9 [INFO] [stderr] | [INFO] [stderr] 335 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | return 1; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:311:9 [INFO] [stderr] | [INFO] [stderr] 311 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:335:9 [INFO] [stderr] | [INFO] [stderr] 335 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | / match cell.to_digit(10) { [INFO] [stderr] 15 | | Some(number) => ints.push(number as u8), [INFO] [stderr] 16 | | None => {} [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(number) = cell.to_digit(10) { ints.push(number as u8) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | / match cell.to_digit(10) { [INFO] [stderr] 15 | | Some(number) => ints.push(number as u8), [INFO] [stderr] 16 | | None => {} [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(number) = cell.to_digit(10) { ints.push(number as u8) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 43 [INFO] [stderr] --> src/lib.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | / fn set_cell_loop(&mut self) { [INFO] [stderr] 161 | | let mut count = 0; //counts possible [INFO] [stderr] 162 | | let mut sd: u8 = 0; //singles possibility var. [INFO] [stderr] 163 | | let mut changed = true; [INFO] [stderr] ... | [INFO] [stderr] 299 | | [INFO] [stderr] 300 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 43 [INFO] [stderr] --> src/lib.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | / fn set_cell_loop(&mut self) { [INFO] [stderr] 161 | | let mut count = 0; //counts possible [INFO] [stderr] 162 | | let mut sd: u8 = 0; //singles possibility var. [INFO] [stderr] 163 | | let mut changed = true; [INFO] [stderr] ... | [INFO] [stderr] 299 | | [INFO] [stderr] 300 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lib.rs:234:80 [INFO] [stderr] | [INFO] [stderr] 234 | } else if cr != r && self.grid[cr][cc][0] == 0 { [INFO] [stderr] | ________________________________________________________________________________^ [INFO] [stderr] 235 | | for cd in 1..10 { [INFO] [stderr] 236 | | if self.grid[cr][cc][cd] != 0 { [INFO] [stderr] 237 | | //stores value of possibility into index of tmp. this prevents multiple of same value [INFO] [stderr] ... | [INFO] [stderr] 240 | | } [INFO] [stderr] 241 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lib.rs:227:84 [INFO] [stderr] | [INFO] [stderr] 227 | if cr == r && cc != c && self.grid[cr][cc][0] == 0 { [INFO] [stderr] | ____________________________________________________________________________________^ [INFO] [stderr] 228 | | for cd in 1..10 { [INFO] [stderr] 229 | | if self.grid[cr][cc][cd] != 0 { [INFO] [stderr] 230 | | //stores value of possibility into index of tmp. this prevents multiple of same value [INFO] [stderr] ... | [INFO] [stderr] 233 | | } [INFO] [stderr] 234 | | } else if cr != r && self.grid[cr][cc][0] == 0 { [INFO] [stderr] | |_________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:302:18 [INFO] [stderr] | [INFO] [stderr] 302 | fn is_solved(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:314:19 [INFO] [stderr] | [INFO] [stderr] 314 | fn is_correct(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lib.rs:234:80 [INFO] [stderr] | [INFO] [stderr] 234 | } else if cr != r && self.grid[cr][cc][0] == 0 { [INFO] [stderr] | ________________________________________________________________________________^ [INFO] [stderr] 235 | | for cd in 1..10 { [INFO] [stderr] 236 | | if self.grid[cr][cc][cd] != 0 { [INFO] [stderr] 237 | | //stores value of possibility into index of tmp. this prevents multiple of same value [INFO] [stderr] ... | [INFO] [stderr] 240 | | } [INFO] [stderr] 241 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lib.rs:227:84 [INFO] [stderr] | [INFO] [stderr] 227 | if cr == r && cc != c && self.grid[cr][cc][0] == 0 { [INFO] [stderr] | ____________________________________________________________________________________^ [INFO] [stderr] 228 | | for cd in 1..10 { [INFO] [stderr] 229 | | if self.grid[cr][cc][cd] != 0 { [INFO] [stderr] 230 | | //stores value of possibility into index of tmp. this prevents multiple of same value [INFO] [stderr] ... | [INFO] [stderr] 233 | | } [INFO] [stderr] 234 | | } else if cr != r && self.grid[cr][cc][0] == 0 { [INFO] [stderr] | |_________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:302:18 [INFO] [stderr] | [INFO] [stderr] 302 | fn is_solved(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:314:19 [INFO] [stderr] | [INFO] [stderr] 314 | fn is_correct(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: Could not compile `sudoku-solver-rust`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `sudoku-solver-rust`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a3aac56af4b667c14ed7b2d8237acd8842fe084a39d2e40854f3925a0e777e9b"` [INFO] running `"docker" "rm" "-f" "a3aac56af4b667c14ed7b2d8237acd8842fe084a39d2e40854f3925a0e777e9b"` [INFO] [stdout] a3aac56af4b667c14ed7b2d8237acd8842fe084a39d2e40854f3925a0e777e9b