[INFO] updating cached repository drbawb/megumin [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/drbawb/megumin [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/drbawb/megumin" "work/ex/clippy-test-run/sources/stable/gh/drbawb/megumin"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/drbawb/megumin'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/drbawb/megumin" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/drbawb/megumin"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/drbawb/megumin'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 89054c709d7bb12f5edab066b85a90dfa6406a65 [INFO] sha for GitHub repo drbawb/megumin: 89054c709d7bb12f5edab066b85a90dfa6406a65 [INFO] validating manifest of drbawb/megumin on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of drbawb/megumin on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing drbawb/megumin [INFO] finished frobbing drbawb/megumin [INFO] frobbed toml for drbawb/megumin written to work/ex/clippy-test-run/sources/stable/gh/drbawb/megumin/Cargo.toml [INFO] started frobbing drbawb/megumin [INFO] finished frobbing drbawb/megumin [INFO] frobbed toml for drbawb/megumin written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/drbawb/megumin/Cargo.toml [INFO] crate drbawb/megumin has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting drbawb/megumin against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/drbawb/megumin:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 93ab3b578e37de2960f8a5941aa275de1046c672ba60605ccff47ea828e8a791 [INFO] running `"docker" "start" "-a" "93ab3b578e37de2960f8a5941aa275de1046c672ba60605ccff47ea828e8a791"` [INFO] [stderr] Checking num_cpus v1.2.1 [INFO] [stderr] Checking deflate v0.7.1 [INFO] [stderr] Checking rayon v0.6.0 [INFO] [stderr] Checking png v0.6.0 [INFO] [stderr] Checking jpeg-decoder v0.1.10 [INFO] [stderr] Checking image v0.12.0 [INFO] [stderr] Checking megumin v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/units/linear/vec.rs:10:46 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn at(x: f32, y: f32) -> Self { V2 { x: x, y: y } } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/units/linear/vec.rs:10:52 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn at(x: f32, y: f32) -> Self { V2 { x: x, y: y } } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/render.rs:297:60 [INFO] [stderr] | [INFO] [stderr] 297 | pub fn from(id: usize, x: f32, y: f32, z: f32, w: f32, h: f32) -> TexRect { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:298:47 [INFO] [stderr] | [INFO] [stderr] 298 | TexRect { texture_id: id, dim: Rect { x: x, y: y, z: z, w: w, h: h } } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:298:53 [INFO] [stderr] | [INFO] [stderr] 298 | TexRect { texture_id: id, dim: Rect { x: x, y: y, z: z, w: w, h: h } } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:298:59 [INFO] [stderr] | [INFO] [stderr] 298 | TexRect { texture_id: id, dim: Rect { x: x, y: y, z: z, w: w, h: h } } [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:298:65 [INFO] [stderr] | [INFO] [stderr] 298 | TexRect { texture_id: id, dim: Rect { x: x, y: y, z: z, w: w, h: h } } [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:298:71 [INFO] [stderr] | [INFO] [stderr] 298 | TexRect { texture_id: id, dim: Rect { x: x, y: y, z: z, w: w, h: h } } [INFO] [stderr] | ^^^^ help: replace it with: `h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/units/linear/vec.rs:10:46 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn at(x: f32, y: f32) -> Self { V2 { x: x, y: y } } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/units/linear/vec.rs:10:52 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn at(x: f32, y: f32) -> Self { V2 { x: x, y: y } } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/render.rs:297:60 [INFO] [stderr] | [INFO] [stderr] 297 | pub fn from(id: usize, x: f32, y: f32, z: f32, w: f32, h: f32) -> TexRect { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:298:47 [INFO] [stderr] | [INFO] [stderr] 298 | TexRect { texture_id: id, dim: Rect { x: x, y: y, z: z, w: w, h: h } } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:298:53 [INFO] [stderr] | [INFO] [stderr] 298 | TexRect { texture_id: id, dim: Rect { x: x, y: y, z: z, w: w, h: h } } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:298:59 [INFO] [stderr] | [INFO] [stderr] 298 | TexRect { texture_id: id, dim: Rect { x: x, y: y, z: z, w: w, h: h } } [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:298:65 [INFO] [stderr] | [INFO] [stderr] 298 | TexRect { texture_id: id, dim: Rect { x: x, y: y, z: z, w: w, h: h } } [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:298:71 [INFO] [stderr] | [INFO] [stderr] 298 | TexRect { texture_id: id, dim: Rect { x: x, y: y, z: z, w: w, h: h } } [INFO] [stderr] | ^^^^ help: replace it with: `h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/entities/map.rs:62:58 [INFO] [stderr] | [INFO] [stderr] 62 | self.entropy.reseed([x as u32, y as u32, 0xDEADBEEF, 0xCAFEBABE]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xDEAD_BEEF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/entities/map.rs:62:70 [INFO] [stderr] | [INFO] [stderr] 62 | self.entropy.reseed([x as u32, y as u32, 0xDEADBEEF, 0xCAFEBABE]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xCAFE_BABE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/render.rs:57:65 [INFO] [stderr] | [INFO] [stderr] 57 | let verts_buffer = VertexBuffer::empty_dynamic(display, (MAX_RECTS * 6)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/render.rs:60:94 [INFO] [stderr] | [INFO] [stderr] 60 | let index_buffer = IndexBuffer::empty_dynamic(display, PrimitiveType::TrianglesList, (MAX_RECTS * 6)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/entities/map.rs:62:58 [INFO] [stderr] | [INFO] [stderr] 62 | self.entropy.reseed([x as u32, y as u32, 0xDEADBEEF, 0xCAFEBABE]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xDEAD_BEEF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/entities/map.rs:62:70 [INFO] [stderr] | [INFO] [stderr] 62 | self.entropy.reseed([x as u32, y as u32, 0xDEADBEEF, 0xCAFEBABE]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xCAFE_BABE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/render.rs:57:65 [INFO] [stderr] | [INFO] [stderr] 57 | let verts_buffer = VertexBuffer::empty_dynamic(display, (MAX_RECTS * 6)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/render.rs:60:94 [INFO] [stderr] | [INFO] [stderr] 60 | let index_buffer = IndexBuffer::empty_dynamic(display, PrimitiveType::TrianglesList, (MAX_RECTS * 6)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused variable: `w` [INFO] [stderr] --> src/entities/sprite.rs:148:14 [INFO] [stderr] | [INFO] [stderr] 148 | let (w,h) = (0.035, 0.035); [INFO] [stderr] | ^ help: consider using `_w` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `h` [INFO] [stderr] --> src/entities/sprite.rs:148:16 [INFO] [stderr] | [INFO] [stderr] 148 | let (w,h) = (0.035, 0.035); [INFO] [stderr] | ^ help: consider using `_h` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `w` [INFO] [stderr] --> src/entities/sprite.rs:148:14 [INFO] [stderr] | [INFO] [stderr] 148 | let (w,h) = (0.035, 0.035); [INFO] [stderr] | ^ help: consider using `_w` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `h` [INFO] [stderr] --> src/entities/sprite.rs:148:16 [INFO] [stderr] | [INFO] [stderr] 148 | let (w,h) = (0.035, 0.035); [INFO] [stderr] | ^ help: consider using `_h` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `tx_star_bg` [INFO] [stderr] --> src/entities/map.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | tx_star_bg: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/drawing.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | Tile((a / TILE_SIZE as f64) as usize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(TILE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: field is never used: `tx_star_bg` [INFO] [stderr] --> src/entities/map.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | tx_star_bg: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/units/physics.rs:7:30 [INFO] [stderr] | [INFO] [stderr] 7 | (dt.as_secs() * 1000) + (dt.subsec_nanos() as u64 / 1_000_000) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dt.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/units/physics.rs:50:2 [INFO] [stderr] | [INFO] [stderr] 50 | fn deref<'a>(&'a self) -> &'a f64 { let Velocity(ref inner_val) = *self; inner_val } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/drawing.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | Tile((a / TILE_SIZE as f64) as usize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(TILE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/units/physics.rs:126:2 [INFO] [stderr] | [INFO] [stderr] 126 | fn deref<'a>(&'a self) -> &'a f64 { let Degrees(ref inner_val) = *self; inner_val } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/units/physics.rs:7:30 [INFO] [stderr] | [INFO] [stderr] 7 | (dt.as_secs() * 1000) + (dt.subsec_nanos() as u64 / 1_000_000) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dt.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is only used to index `buf`. [INFO] [stderr] --> src/render.rs:80:24 [INFO] [stderr] | [INFO] [stderr] 80 | for row in y..(y+32) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 80 | for in buf.iter_mut().skip(y).take(32) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/units/physics.rs:50:2 [INFO] [stderr] | [INFO] [stderr] 50 | fn deref<'a>(&'a self) -> &'a f64 { let Velocity(ref inner_val) = *self; inner_val } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/units/physics.rs:126:2 [INFO] [stderr] | [INFO] [stderr] 126 | fn deref<'a>(&'a self) -> &'a f64 { let Degrees(ref inner_val) = *self; inner_val } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is only used to index `buf`. [INFO] [stderr] --> src/render.rs:236:18 [INFO] [stderr] | [INFO] [stderr] 236 | for y in 0..dim_y { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 236 | for in buf.iter_mut().take(dim_y) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is only used to index `buf`. [INFO] [stderr] --> src/render.rs:80:24 [INFO] [stderr] | [INFO] [stderr] 80 | for row in y..(y+32) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 80 | for in buf.iter_mut().skip(y).take(32) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is only used to index `buf`. [INFO] [stderr] --> src/render.rs:236:18 [INFO] [stderr] | [INFO] [stderr] 236 | for y in 0..dim_y { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 236 | for in buf.iter_mut().take(dim_y) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.12s [INFO] running `"docker" "inspect" "93ab3b578e37de2960f8a5941aa275de1046c672ba60605ccff47ea828e8a791"` [INFO] running `"docker" "rm" "-f" "93ab3b578e37de2960f8a5941aa275de1046c672ba60605ccff47ea828e8a791"` [INFO] [stdout] 93ab3b578e37de2960f8a5941aa275de1046c672ba60605ccff47ea828e8a791