[INFO] updating cached repository drbawb/koko [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/drbawb/koko [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/drbawb/koko" "work/ex/clippy-test-run/sources/stable/gh/drbawb/koko"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/drbawb/koko'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/drbawb/koko" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/drbawb/koko"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/drbawb/koko'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7aed3c94ff6c27ee8d6d5097b4b1e458c351e999 [INFO] sha for GitHub repo drbawb/koko: 7aed3c94ff6c27ee8d6d5097b4b1e458c351e999 [INFO] validating manifest of drbawb/koko on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of drbawb/koko on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing drbawb/koko [INFO] finished frobbing drbawb/koko [INFO] frobbed toml for drbawb/koko written to work/ex/clippy-test-run/sources/stable/gh/drbawb/koko/Cargo.toml [INFO] started frobbing drbawb/koko [INFO] finished frobbing drbawb/koko [INFO] frobbed toml for drbawb/koko written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/drbawb/koko/Cargo.toml [INFO] crate drbawb/koko has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting drbawb/koko against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/drbawb/koko:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 00baa4337f48f9614f526df562e040f0c6f516c23695cf3527760775b1348cdf [INFO] running `"docker" "start" "-a" "00baa4337f48f9614f526df562e040f0c6f516c23695cf3527760775b1348cdf"` [INFO] [stderr] Compiling x11-dl v2.18.3 [INFO] [stderr] Compiling wayland-scanner v0.20.12 [INFO] [stderr] Checking smallvec v0.6.4 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking wayland-sys v0.20.12 [INFO] [stderr] Checking wayland-commons v0.20.12 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Compiling wayland-client v0.20.12 [INFO] [stderr] Compiling wayland-protocols v0.20.12 [INFO] [stderr] Checking parking_lot v0.6.3 [INFO] [stderr] Compiling glutin v0.17.0 [INFO] [stderr] Compiling glium v0.22.0 [INFO] [stderr] Checking smithay-client-toolkit v0.2.6 [INFO] [stderr] Checking winit v0.16.2 [INFO] [stderr] Checking koko v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | atlas_array: atlas_array, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `atlas_array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | atlas_array: atlas_array, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `atlas_array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `DeviceEvent` [INFO] [stderr] --> src/engine.rs:5:21 [INFO] [stderr] | [INFO] [stderr] 5 | use glium::glutin::{DeviceEvent, WindowEvent, Event, EventsLoop}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `DeviceEvent` [INFO] [stderr] --> src/engine.rs:5:21 [INFO] [stderr] | [INFO] [stderr] 5 | use glium::glutin::{DeviceEvent, WindowEvent, Event, EventsLoop}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ofs` [INFO] [stderr] --> src/engine.rs:96:24 [INFO] [stderr] | [INFO] [stderr] 96 | writer.set(ofs + 0, Vert2 { pos: [ wx-fudge_x, wy+fudge_y, 0.0], color: [0.75, 0.0, 0.5] }); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/engine.rs:206:17 [INFO] [stderr] | [INFO] [stderr] 206 | / match evt { [INFO] [stderr] 207 | | Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 208 | | WindowEvent::CloseRequested => self.is_running = false, [INFO] [stderr] 209 | | WindowEvent::Resized(new_size) => { [INFO] [stderr] ... | [INFO] [stderr] 251 | | _ => {}, [INFO] [stderr] 252 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 206 | if let Event::WindowEvent { event, .. } = evt { match event { [INFO] [stderr] 207 | WindowEvent::CloseRequested => self.is_running = false, [INFO] [stderr] 208 | WindowEvent::Resized(new_size) => { [INFO] [stderr] 209 | self.window_dim = ( [INFO] [stderr] 210 | new_size.width as u32, [INFO] [stderr] 211 | new_size.height as u32, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/engine.rs:382:24 [INFO] [stderr] | [INFO] [stderr] 382 | time_ms += time.subsec_nanos() as u64 / 1000 / 1000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(time.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/graphics.rs:70:32 [INFO] [stderr] | [INFO] [stderr] 70 | let row: Vec = (&image[start..end]).iter().cloned().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/units.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / match length <= 0.0 { [INFO] [stderr] 20 | | true => V2f(0.0, 0.0), [INFO] [stderr] 21 | | false => V2f(self.0 / length, self.1 / length), [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if length <= 0.0 { V2f(0.0, 0.0) } else { V2f(self.0 / length, self.1 / length) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | let x_origin = (buf[ofs + 0] as u16) << 8 | buf[ofs + 1] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[ofs + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ofs` [INFO] [stderr] --> src/util.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | let x_origin = (buf[ofs + 0] as u16) << 8 | buf[ofs + 1] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:23:49 [INFO] [stderr] | [INFO] [stderr] 23 | let x_origin = (buf[ofs + 0] as u16) << 8 | buf[ofs + 1] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[ofs + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | let y_origin = (buf[ofs + 0] as u16) << 8 | buf[ofs + 1] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[ofs + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ofs` [INFO] [stderr] --> src/util.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | let y_origin = (buf[ofs + 0] as u16) << 8 | buf[ofs + 1] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:24:49 [INFO] [stderr] | [INFO] [stderr] 24 | let y_origin = (buf[ofs + 0] as u16) << 8 | buf[ofs + 1] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[ofs + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | let width = (buf[ofs + 1] as u16) << 8 | buf[ofs + 0] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[ofs + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:26:47 [INFO] [stderr] | [INFO] [stderr] 26 | let width = (buf[ofs + 1] as u16) << 8 | buf[ofs + 0] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[ofs + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ofs` [INFO] [stderr] --> src/util.rs:26:51 [INFO] [stderr] | [INFO] [stderr] 26 | let width = (buf[ofs + 1] as u16) << 8 | buf[ofs + 0] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | let height = (buf[ofs + 1] as u16) << 8 | buf[ofs + 0] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[ofs + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:27:47 [INFO] [stderr] | [INFO] [stderr] 27 | let height = (buf[ofs + 1] as u16) << 8 | buf[ofs + 0] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[ofs + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ofs` [INFO] [stderr] --> src/util.rs:27:51 [INFO] [stderr] | [INFO] [stderr] 27 | let height = (buf[ofs + 1] as u16) << 8 | buf[ofs + 0] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ofs + px_ofs` [INFO] [stderr] --> src/util.rs:51:31 [INFO] [stderr] | [INFO] [stderr] 51 | rgba.push(buf[ofs + px_ofs + 0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ofs` [INFO] [stderr] --> src/engine.rs:96:24 [INFO] [stderr] | [INFO] [stderr] 96 | writer.set(ofs + 0, Vert2 { pos: [ wx-fudge_x, wy+fudge_y, 0.0], color: [0.75, 0.0, 0.5] }); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/engine.rs:206:17 [INFO] [stderr] | [INFO] [stderr] 206 | / match evt { [INFO] [stderr] 207 | | Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 208 | | WindowEvent::CloseRequested => self.is_running = false, [INFO] [stderr] 209 | | WindowEvent::Resized(new_size) => { [INFO] [stderr] ... | [INFO] [stderr] 251 | | _ => {}, [INFO] [stderr] 252 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 206 | if let Event::WindowEvent { event, .. } = evt { match event { [INFO] [stderr] 207 | WindowEvent::CloseRequested => self.is_running = false, [INFO] [stderr] 208 | WindowEvent::Resized(new_size) => { [INFO] [stderr] 209 | self.window_dim = ( [INFO] [stderr] 210 | new_size.width as u32, [INFO] [stderr] 211 | new_size.height as u32, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/engine.rs:382:24 [INFO] [stderr] | [INFO] [stderr] 382 | time_ms += time.subsec_nanos() as u64 / 1000 / 1000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(time.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/graphics.rs:70:32 [INFO] [stderr] | [INFO] [stderr] 70 | let row: Vec = (&image[start..end]).iter().cloned().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/units.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / match length <= 0.0 { [INFO] [stderr] 20 | | true => V2f(0.0, 0.0), [INFO] [stderr] 21 | | false => V2f(self.0 / length, self.1 / length), [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if length <= 0.0 { V2f(0.0, 0.0) } else { V2f(self.0 / length, self.1 / length) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | let x_origin = (buf[ofs + 0] as u16) << 8 | buf[ofs + 1] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[ofs + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ofs` [INFO] [stderr] --> src/util.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | let x_origin = (buf[ofs + 0] as u16) << 8 | buf[ofs + 1] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:23:49 [INFO] [stderr] | [INFO] [stderr] 23 | let x_origin = (buf[ofs + 0] as u16) << 8 | buf[ofs + 1] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[ofs + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | let y_origin = (buf[ofs + 0] as u16) << 8 | buf[ofs + 1] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[ofs + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ofs` [INFO] [stderr] --> src/util.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | let y_origin = (buf[ofs + 0] as u16) << 8 | buf[ofs + 1] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:24:49 [INFO] [stderr] | [INFO] [stderr] 24 | let y_origin = (buf[ofs + 0] as u16) << 8 | buf[ofs + 1] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[ofs + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | let width = (buf[ofs + 1] as u16) << 8 | buf[ofs + 0] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[ofs + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:26:47 [INFO] [stderr] | [INFO] [stderr] 26 | let width = (buf[ofs + 1] as u16) << 8 | buf[ofs + 0] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[ofs + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ofs` [INFO] [stderr] --> src/util.rs:26:51 [INFO] [stderr] | [INFO] [stderr] 26 | let width = (buf[ofs + 1] as u16) << 8 | buf[ofs + 0] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | let height = (buf[ofs + 1] as u16) << 8 | buf[ofs + 0] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[ofs + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:27:47 [INFO] [stderr] | [INFO] [stderr] 27 | let height = (buf[ofs + 1] as u16) << 8 | buf[ofs + 0] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[ofs + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ofs` [INFO] [stderr] --> src/util.rs:27:51 [INFO] [stderr] | [INFO] [stderr] 27 | let height = (buf[ofs + 1] as u16) << 8 | buf[ofs + 0] as u16; ofs += 2; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ofs + px_ofs` [INFO] [stderr] --> src/util.rs:51:31 [INFO] [stderr] | [INFO] [stderr] 51 | rgba.push(buf[ofs + px_ofs + 0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 53.63s [INFO] running `"docker" "inspect" "00baa4337f48f9614f526df562e040f0c6f516c23695cf3527760775b1348cdf"` [INFO] running `"docker" "rm" "-f" "00baa4337f48f9614f526df562e040f0c6f516c23695cf3527760775b1348cdf"` [INFO] [stdout] 00baa4337f48f9614f526df562e040f0c6f516c23695cf3527760775b1348cdf