[INFO] updating cached repository drbawb/advent2016 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/drbawb/advent2016 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/drbawb/advent2016" "work/ex/clippy-test-run/sources/stable/gh/drbawb/advent2016"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/drbawb/advent2016'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/drbawb/advent2016" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/drbawb/advent2016"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/drbawb/advent2016'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cd76cd1dbee36b71a5bd0da598a4c80aa7209f6b [INFO] sha for GitHub repo drbawb/advent2016: cd76cd1dbee36b71a5bd0da598a4c80aa7209f6b [INFO] validating manifest of drbawb/advent2016 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of drbawb/advent2016 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing drbawb/advent2016 [INFO] finished frobbing drbawb/advent2016 [INFO] frobbed toml for drbawb/advent2016 written to work/ex/clippy-test-run/sources/stable/gh/drbawb/advent2016/Cargo.toml [INFO] started frobbing drbawb/advent2016 [INFO] finished frobbing drbawb/advent2016 [INFO] frobbed toml for drbawb/advent2016 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/drbawb/advent2016/Cargo.toml [INFO] crate drbawb/advent2016 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting drbawb/advent2016 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/drbawb/advent2016:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 07e40d038bfd383b25f696b7e5fc0d3cb52551dc841f76a335ae3431a242aa25 [INFO] running `"docker" "start" "-a" "07e40d038bfd383b25f696b7e5fc0d3cb52551dc841f76a335ae3431a242aa25"` [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking advent2016 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/day8/mod.rs:65:4 [INFO] [stderr] | [INFO] [stderr] 65 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/day8/mod.rs:65:4 [INFO] [stderr] | [INFO] [stderr] 65 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is used to index `buf` [INFO] [stderr] --> src/day8/mod.rs:55:14 [INFO] [stderr] | [INFO] [stderr] 55 | for row in 0..6 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 55 | for (row, ) in buf.iter().enumerate().take(6) { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day8/mod.rs:83:32 [INFO] [stderr] | [INFO] [stderr] 83 | let spec = &line[5..].split("x") [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is used to index `buf` [INFO] [stderr] --> src/day8/mod.rs:55:14 [INFO] [stderr] | [INFO] [stderr] 55 | for row in 0..6 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 55 | for (row, ) in buf.iter().enumerate().take(6) { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day8/mod.rs:83:32 [INFO] [stderr] | [INFO] [stderr] 83 | let spec = &line[5..].split("x") [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.19s [INFO] running `"docker" "inspect" "07e40d038bfd383b25f696b7e5fc0d3cb52551dc841f76a335ae3431a242aa25"` [INFO] running `"docker" "rm" "-f" "07e40d038bfd383b25f696b7e5fc0d3cb52551dc841f76a335ae3431a242aa25"` [INFO] [stdout] 07e40d038bfd383b25f696b7e5fc0d3cb52551dc841f76a335ae3431a242aa25