[INFO] updating cached repository doy/lastfm-query [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/doy/lastfm-query [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/doy/lastfm-query" "work/ex/clippy-test-run/sources/stable/gh/doy/lastfm-query"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/doy/lastfm-query'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/doy/lastfm-query" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/doy/lastfm-query"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/doy/lastfm-query'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c22141ea46b406003eb889a8408d9b87e6b488fa [INFO] sha for GitHub repo doy/lastfm-query: c22141ea46b406003eb889a8408d9b87e6b488fa [INFO] validating manifest of doy/lastfm-query on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of doy/lastfm-query on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing doy/lastfm-query [INFO] finished frobbing doy/lastfm-query [INFO] frobbed toml for doy/lastfm-query written to work/ex/clippy-test-run/sources/stable/gh/doy/lastfm-query/Cargo.toml [INFO] started frobbing doy/lastfm-query [INFO] finished frobbing doy/lastfm-query [INFO] frobbed toml for doy/lastfm-query written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/doy/lastfm-query/Cargo.toml [INFO] crate doy/lastfm-query has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting doy/lastfm-query against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/doy/lastfm-query:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7bd3319b17a29a0fd91b3147fd2e042f2b66cb32bdfd11c5fb19b261b758cc9c [INFO] running `"docker" "start" "-a" "7bd3319b17a29a0fd91b3147fd2e042f2b66cb32bdfd11c5fb19b261b758cc9c"` [INFO] [stderr] Checking rpassword v2.0.0 [INFO] [stderr] Checking tokio-threadpool v0.1.8 [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Checking regex v1.0.6 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking console v0.6.2 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Checking hyper v0.12.13 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking reqwest v0.9.4 [INFO] [stderr] Checking lastfm-query v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cmd/mod.rs:5:27 [INFO] [stderr] | [INFO] [stderr] 5 | const _DUMMY_DEPENDENCY: &'static str = include_str!("../../Cargo.toml"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/db.rs:5:16 [INFO] [stderr] | [INFO] [stderr] 5 | const SCHEMA: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | return Ok(DB { conn }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(DB { conn })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lastfm/mod.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | const API_ROOT: &'static str = "https://ws.audioscrobbler.com/2.0/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cmd/mod.rs:5:27 [INFO] [stderr] | [INFO] [stderr] 5 | const _DUMMY_DEPENDENCY: &'static str = include_str!("../../Cargo.toml"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/db.rs:5:16 [INFO] [stderr] | [INFO] [stderr] 5 | const SCHEMA: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | return Ok(DB { conn }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(DB { conn })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lastfm/mod.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | const API_ROOT: &'static str = "https://ws.audioscrobbler.com/2.0/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cmd/sql.rs:82:47 [INFO] [stderr] | [INFO] [stderr] 82 | rusqlite::types::ValueRef::Text(s) => format!("{}", s), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `s.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/cmd/sync.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | let bar = indicatif::ProgressBar::new(to_fetch); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/db.rs:239:25 [INFO] [stderr] | [INFO] [stderr] 239 | fn timewindow_table(tw: &TimeWindow) -> String { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `TimeWindow` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lastfm/mod.rs:41:12 [INFO] [stderr] | [INFO] [stderr] 41 | if !self.page.is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.page.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lastfm/mod.rs:95:12 [INFO] [stderr] | [INFO] [stderr] 95 | if self.buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cmd/sql.rs:82:47 [INFO] [stderr] | [INFO] [stderr] 82 | rusqlite::types::ValueRef::Text(s) => format!("{}", s), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `s.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/cmd/sync.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | let bar = indicatif::ProgressBar::new(to_fetch); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/db.rs:239:25 [INFO] [stderr] | [INFO] [stderr] 239 | fn timewindow_table(tw: &TimeWindow) -> String { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `TimeWindow` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lastfm/mod.rs:41:12 [INFO] [stderr] | [INFO] [stderr] 41 | if !self.page.is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.page.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lastfm/mod.rs:95:12 [INFO] [stderr] | [INFO] [stderr] 95 | if self.buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 44.46s [INFO] running `"docker" "inspect" "7bd3319b17a29a0fd91b3147fd2e042f2b66cb32bdfd11c5fb19b261b758cc9c"` [INFO] running `"docker" "rm" "-f" "7bd3319b17a29a0fd91b3147fd2e042f2b66cb32bdfd11c5fb19b261b758cc9c"` [INFO] [stdout] 7bd3319b17a29a0fd91b3147fd2e042f2b66cb32bdfd11c5fb19b261b758cc9c