[INFO] updating cached repository doy/fancy-prompt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/doy/fancy-prompt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/doy/fancy-prompt" "work/ex/clippy-test-run/sources/stable/gh/doy/fancy-prompt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/doy/fancy-prompt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/doy/fancy-prompt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/doy/fancy-prompt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/doy/fancy-prompt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bc3d923b12476b8807e073555968de657864ad1d [INFO] sha for GitHub repo doy/fancy-prompt: bc3d923b12476b8807e073555968de657864ad1d [INFO] validating manifest of doy/fancy-prompt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of doy/fancy-prompt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing doy/fancy-prompt [INFO] finished frobbing doy/fancy-prompt [INFO] frobbed toml for doy/fancy-prompt written to work/ex/clippy-test-run/sources/stable/gh/doy/fancy-prompt/Cargo.toml [INFO] started frobbing doy/fancy-prompt [INFO] finished frobbing doy/fancy-prompt [INFO] frobbed toml for doy/fancy-prompt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/doy/fancy-prompt/Cargo.toml [INFO] crate doy/fancy-prompt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting doy/fancy-prompt against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/doy/fancy-prompt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c44bdb44f12dead7e67a8fcc5f7ba611b4f5fd413569982f85a1970a4e80523b [INFO] running `"docker" "start" "-a" "c44bdb44f12dead7e67a8fcc5f7ba611b4f5fd413569982f85a1970a4e80523b"` [INFO] [stderr] Checking hostname v0.1.4 [INFO] [stderr] Checking users v0.6.0 [INFO] [stderr] Checking term_size v0.3.1 [INFO] [stderr] Checking walkdir v2.1.3 [INFO] [stderr] Checking libz-sys v1.0.18 [INFO] [stderr] Compiling curl-sys v0.4.1 [INFO] [stderr] Compiling libssh2-sys v0.2.6 [INFO] [stderr] Compiling libgit2-sys v0.6.19 [INFO] [stderr] Checking git2 v0.6.11 [INFO] [stderr] Checking fancy-prompt v0.1.6 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/colors.rs:120:25 [INFO] [stderr] | [INFO] [stderr] 120 | write!(t, "{}", "\n").unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/colors.rs:201:30 [INFO] [stderr] | [INFO] [stderr] 201 | print!("{}", "\\["); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/colors.rs:204:30 [INFO] [stderr] | [INFO] [stderr] 204 | print!("{}", "%{"); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/colors.rs:213:30 [INFO] [stderr] | [INFO] [stderr] 213 | print!("{}", "\\]"); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/colors.rs:216:30 [INFO] [stderr] | [INFO] [stderr] 216 | print!("{}", "%}"); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/colors.rs:120:25 [INFO] [stderr] | [INFO] [stderr] 120 | write!(t, "{}", "\n").unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/colors.rs:201:30 [INFO] [stderr] | [INFO] [stderr] 201 | print!("{}", "\\["); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/colors.rs:204:30 [INFO] [stderr] | [INFO] [stderr] 204 | print!("{}", "%{"); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/colors.rs:213:30 [INFO] [stderr] | [INFO] [stderr] 213 | print!("{}", "\\]"); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/colors.rs:216:30 [INFO] [stderr] | [INFO] [stderr] 216 | print!("{}", "%}"); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/prompt.rs:266:26 [INFO] [stderr] | [INFO] [stderr] 266 | else if usage >= 0.4 { [INFO] [stderr] | __________________________^ [INFO] [stderr] 267 | | "default" [INFO] [stderr] 268 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/prompt.rs:263:22 [INFO] [stderr] | [INFO] [stderr] 263 | else if charging { [INFO] [stderr] | ______________________^ [INFO] [stderr] 264 | | "default" [INFO] [stderr] 265 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/sys/unix.rs:20:68 [INFO] [stderr] | [INFO] [stderr] 20 | else if (file_uid == euid) && (file_mode & 0o200 != 0) { [INFO] [stderr] | ____________________________________________________________________^ [INFO] [stderr] 21 | | super::PathWritability::Writable [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/sys/unix.rs:17:26 [INFO] [stderr] | [INFO] [stderr] 17 | if euid == 0 { [INFO] [stderr] | __________________________^ [INFO] [stderr] 18 | | super::PathWritability::Writable [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/vcs/mod.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / self.has_modified_files() || self.has_staged_files() [INFO] [stderr] 31 | | || self.has_new_files() || !diff.is_some() [INFO] [stderr] 32 | | || diff.map(|(local, remote)| local > 0 || remote > 0) [INFO] [stderr] 33 | | .unwrap_or(false) [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 30 | self.has_modified_files() || self.has_staged_files() || self.has_new_files() || diff.is_none() || diff.map(|(local, remote)| local > 0 || remote > 0) [INFO] [stderr] 31 | .unwrap_or(false) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `fancy-prompt`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/prompt.rs:266:26 [INFO] [stderr] | [INFO] [stderr] 266 | else if usage >= 0.4 { [INFO] [stderr] | __________________________^ [INFO] [stderr] 267 | | "default" [INFO] [stderr] 268 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/prompt.rs:263:22 [INFO] [stderr] | [INFO] [stderr] 263 | else if charging { [INFO] [stderr] | ______________________^ [INFO] [stderr] 264 | | "default" [INFO] [stderr] 265 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/sys/unix.rs:20:68 [INFO] [stderr] | [INFO] [stderr] 20 | else if (file_uid == euid) && (file_mode & 0o200 != 0) { [INFO] [stderr] | ____________________________________________________________________^ [INFO] [stderr] 21 | | super::PathWritability::Writable [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/sys/unix.rs:17:26 [INFO] [stderr] | [INFO] [stderr] 17 | if euid == 0 { [INFO] [stderr] | __________________________^ [INFO] [stderr] 18 | | super::PathWritability::Writable [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/vcs/mod.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / self.has_modified_files() || self.has_staged_files() [INFO] [stderr] 31 | | || self.has_new_files() || !diff.is_some() [INFO] [stderr] 32 | | || diff.map(|(local, remote)| local > 0 || remote > 0) [INFO] [stderr] 33 | | .unwrap_or(false) [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 30 | self.has_modified_files() || self.has_staged_files() || self.has_new_files() || diff.is_none() || diff.map(|(local, remote)| local > 0 || remote > 0) [INFO] [stderr] 31 | .unwrap_or(false) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `fancy-prompt`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c44bdb44f12dead7e67a8fcc5f7ba611b4f5fd413569982f85a1970a4e80523b"` [INFO] running `"docker" "rm" "-f" "c44bdb44f12dead7e67a8fcc5f7ba611b4f5fd413569982f85a1970a4e80523b"` [INFO] [stdout] c44bdb44f12dead7e67a8fcc5f7ba611b4f5fd413569982f85a1970a4e80523b