[INFO] updating cached repository dovahcrow/sidekiq-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dovahcrow/sidekiq-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dovahcrow/sidekiq-rs" "work/ex/clippy-test-run/sources/stable/gh/dovahcrow/sidekiq-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dovahcrow/sidekiq-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dovahcrow/sidekiq-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dovahcrow/sidekiq-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dovahcrow/sidekiq-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dec03bb7cd32d39260cc874329e1b20bd1c089c7 [INFO] sha for GitHub repo dovahcrow/sidekiq-rs: dec03bb7cd32d39260cc874329e1b20bd1c089c7 [INFO] validating manifest of dovahcrow/sidekiq-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dovahcrow/sidekiq-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dovahcrow/sidekiq-rs [INFO] finished frobbing dovahcrow/sidekiq-rs [INFO] frobbed toml for dovahcrow/sidekiq-rs written to work/ex/clippy-test-run/sources/stable/gh/dovahcrow/sidekiq-rs/Cargo.toml [INFO] started frobbing dovahcrow/sidekiq-rs [INFO] finished frobbing dovahcrow/sidekiq-rs [INFO] frobbed toml for dovahcrow/sidekiq-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dovahcrow/sidekiq-rs/Cargo.toml [INFO] crate dovahcrow/sidekiq-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dovahcrow/sidekiq-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dovahcrow/sidekiq-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 142b0312d5296131fab09a5f4f0c9053b9f70107b19da26075514436610c5861 [INFO] running `"docker" "start" "-a" "142b0312d5296131fab09a5f4f0c9053b9f70107b19da26075514436610c5861"` [INFO] [stderr] Checking hado v0.1.0 [INFO] [stderr] Checking r2d2 v0.7.1 [INFO] [stderr] Checking futures v0.1.10 [INFO] [stderr] Checking chan v0.1.19 [INFO] [stderr] Checking random_choice v0.3.2 [INFO] [stderr] Checking backtrace-sys v0.1.10 [INFO] [stderr] Checking structopt v0.0.3 [INFO] [stderr] Compiling structopt-derive v0.0.3 [INFO] [stderr] Checking redis v0.8.0 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Checking env_logger v0.4.1 [INFO] [stderr] Checking backtrace v0.3.0 [INFO] [stderr] Checking chan-signal v0.2.0 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking futures-cpupool v0.1.3 [INFO] [stderr] Checking r2d2_redis v0.6.0 [INFO] [stderr] Checking sidekiq-rs v0.7.1-pre (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | concurrency: concurrency, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `concurrency` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | class: class, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | queue: queue, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | jid: jid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `jid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | retry: retry, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `retry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | created_at: created_at, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `created_at` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | enqueued_at: enqueued_at, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `enqueued_at` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | at: at, [INFO] [stderr] | ^^^^^^ help: replace it with: `at` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | retry_info: retry_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `retry_info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/worker.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | pool: pool, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/worker.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | namespace: namespace, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `namespace` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/worker.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | queues: queues, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `queues` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/worker.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | weights: weights, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `weights` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/worker.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | handlers: handlers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `handlers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/worker.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | middlewares: middlewares, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `middlewares` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/worker.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | tx: tx, [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/worker.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | rx: rx, [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | concurrency: concurrency, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `concurrency` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | class: class, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | queue: queue, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | jid: jid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `jid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | retry: retry, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `retry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | created_at: created_at, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `created_at` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | enqueued_at: enqueued_at, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `enqueued_at` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | at: at, [INFO] [stderr] | ^^^^^^ help: replace it with: `at` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | retry_info: retry_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `retry_info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/worker.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | pool: pool, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/worker.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | namespace: namespace, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `namespace` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/worker.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | queues: queues, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `queues` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/worker.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | weights: weights, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `weights` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/worker.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | handlers: handlers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `handlers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/worker.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | middlewares: middlewares, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `middlewares` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/worker.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | tx: tx, [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/worker.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | rx: rx, [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/server.rs:75:89 [INFO] [stderr] | [INFO] [stderr] 75 | started_at: now.timestamp() as f64 + now.timestamp_subsec_micros() as f64 / 1000000f64, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/server.rs:282:69 [INFO] [stderr] | [INFO] [stderr] 282 | now.timestamp_subsec_micros() as f64 / 1000000f64) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/server.rs:75:89 [INFO] [stderr] | [INFO] [stderr] 75 | started_at: now.timestamp() as f64 + now.timestamp_subsec_micros() as f64 / 1000000f64, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/server.rs:282:69 [INFO] [stderr] | [INFO] [stderr] 282 | now.timestamp_subsec_micros() as f64 / 1000000f64) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/middleware.rs:28:57 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn peek_middleware(job: &mut Job, redis: RedisPool, mut next: NextFunc) -> MiddleWareResult { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/middleware.rs:35:58 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn retry_middleware(job: &mut Job, redis: RedisPool, mut next: NextFunc) -> MiddleWareResult { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/middleware.rs:71:31 [INFO] [stderr] | [INFO] [stderr] 71 | mut next: NextFunc) [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/server.rs:75:50 [INFO] [stderr] | [INFO] [stderr] 75 | started_at: now.timestamp() as f64 + now.timestamp_subsec_micros() as f64 / 1000000f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(now.timestamp_subsec_micros())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server.rs:102:12 [INFO] [stderr] | [INFO] [stderr] 102 | if self.queues.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.queues.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server.rs:210:24 [INFO] [stderr] | [INFO] [stderr] 210 | if self.worker_info.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.worker_info.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server.rs:231:24 [INFO] [stderr] | [INFO] [stderr] 231 | if self.worker_info.len()== 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.worker_info.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/server.rs:244:17 [INFO] [stderr] | [INFO] [stderr] 244 | let _ = try!(self.report_processed(n)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/server.rs:248:17 [INFO] [stderr] | [INFO] [stderr] 248 | let _ = try!(self.report_failed(n)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/server.rs:270:64 [INFO] [stderr] | [INFO] [stderr] 270 | "hostname": rust_gethostname().unwrap_or("unknown".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "unknown".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/server.rs:282:30 [INFO] [stderr] | [INFO] [stderr] 282 | now.timestamp_subsec_micros() as f64 / 1000000f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(now.timestamp_subsec_micros())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/server.rs:298:9 [INFO] [stderr] | [INFO] [stderr] 298 | / let _: () = Pipeline::new().incr(self.with_namespace(&format!("stat:processed:{}", [INFO] [stderr] 299 | | UTC::now().format("%Y-%m-%d"))), [INFO] [stderr] 300 | | n) [INFO] [stderr] 301 | | .incr(self.with_namespace(&format!("stat:processed")), n) [INFO] [stderr] 302 | | .query(&*connection)?; [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:301:40 [INFO] [stderr] | [INFO] [stderr] 301 | .incr(self.with_namespace(&format!("stat:processed")), n) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"stat:processed".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/server.rs:310:9 [INFO] [stderr] | [INFO] [stderr] 310 | / let _: () = Pipeline::new() [INFO] [stderr] 311 | | .incr(self.with_namespace(&format!("stat:failed:{}", UTC::now().format("%Y-%m-%d"))), [INFO] [stderr] 312 | | n) [INFO] [stderr] 313 | | .incr(self.with_namespace(&format!("stat:failed")), n) [INFO] [stderr] 314 | | .query(&*connection)?; [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:313:40 [INFO] [stderr] | [INFO] [stderr] 313 | .incr(self.with_namespace(&format!("stat:failed")), n) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"stat:failed".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/server.rs:320:39 [INFO] [stderr] | [INFO] [stderr] 320 | let host = rust_gethostname().unwrap_or("unknown".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "unknown".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/job.rs:64:18 [INFO] [stderr] | [INFO] [stderr] 64 | .ok_or(D::Error::custom("no member 'retry'"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| D::Error::custom("no member 'retry'"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/job.rs:120:33 [INFO] [stderr] | [INFO] [stderr] 120 | created_at.timestamp_subsec_nanos() as f64 / 1e9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(created_at.timestamp_subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/job.rs:126:27 [INFO] [stderr] | [INFO] [stderr] 126 | self.enqueued_at.timestamp_subsec_nanos() as f64 / 1e9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.enqueued_at.timestamp_subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/job.rs:131:57 [INFO] [stderr] | [INFO] [stderr] 131 | let timestamp = at.timestamp() as f64 + at.timestamp_subsec_nanos() as f64 / 1e9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(at.timestamp_subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/job.rs:150:29 [INFO] [stderr] | [INFO] [stderr] 150 | retry_info.failed_at.timestamp_subsec_nanos() as f64 / 1e9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(retry_info.failed_at.timestamp_subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/job.rs:154:34 [INFO] [stderr] | [INFO] [stderr] 154 | retried_at.timestamp_subsec_nanos() as f64 / 1e9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(retried_at.timestamp_subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/job.rs:196:14 [INFO] [stderr] | [INFO] [stderr] 196 | .ok_or(D::Error::custom(format!("no member '{}'", key))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| D::Error::custom(format!("no member '{}'", key)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/job.rs:227:14 [INFO] [stderr] | [INFO] [stderr] 227 | .ok_or(D::Error::custom(format!("no member '{}'", key))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| D::Error::custom(format!("no member '{}'", key)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/worker.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub fn new(server_id: &str, [INFO] [stderr] 45 | | pool: RedisPool, [INFO] [stderr] 46 | | tx: Sender, [INFO] [stderr] 47 | | rx: Receiver, [INFO] [stderr] ... | [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/worker.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | / let _: () = Pipeline::new().hset(&self.with_namespace(&self.with_server_id("workers")), [INFO] [stderr] 208 | | &self.id, [INFO] [stderr] 209 | | to_string(&payload).unwrap()) [INFO] [stderr] 210 | | .expire(&self.with_namespace(&self.with_server_id("workers")), 5) [INFO] [stderr] 211 | | .query(&*conn)?; [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/worker.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | / let _: () = self.pool [INFO] [stderr] 219 | | .get()? [INFO] [stderr] 220 | | .hdel(&self.with_namespace(&self.with_server_id("workers")), [INFO] [stderr] 221 | | &self.id)?; [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/middleware.rs:55:30 [INFO] [stderr] | [INFO] [stderr] 55 | .unwrap_or(vec![]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/middleware.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | let _: () = conn.lpush(job.queue_name(), to_string(job).unwrap())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/middleware.rs:28:57 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn peek_middleware(job: &mut Job, redis: RedisPool, mut next: NextFunc) -> MiddleWareResult { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/middleware.rs:35:58 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn retry_middleware(job: &mut Job, redis: RedisPool, mut next: NextFunc) -> MiddleWareResult { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/middleware.rs:71:31 [INFO] [stderr] | [INFO] [stderr] 71 | mut next: NextFunc) [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/server.rs:75:50 [INFO] [stderr] | [INFO] [stderr] 75 | started_at: now.timestamp() as f64 + now.timestamp_subsec_micros() as f64 / 1000000f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(now.timestamp_subsec_micros())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server.rs:102:12 [INFO] [stderr] | [INFO] [stderr] 102 | if self.queues.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.queues.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server.rs:210:24 [INFO] [stderr] | [INFO] [stderr] 210 | if self.worker_info.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.worker_info.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server.rs:231:24 [INFO] [stderr] | [INFO] [stderr] 231 | if self.worker_info.len()== 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.worker_info.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/server.rs:244:17 [INFO] [stderr] | [INFO] [stderr] 244 | let _ = try!(self.report_processed(n)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/server.rs:248:17 [INFO] [stderr] | [INFO] [stderr] 248 | let _ = try!(self.report_failed(n)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/server.rs:270:64 [INFO] [stderr] | [INFO] [stderr] 270 | "hostname": rust_gethostname().unwrap_or("unknown".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "unknown".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/server.rs:282:30 [INFO] [stderr] | [INFO] [stderr] 282 | now.timestamp_subsec_micros() as f64 / 1000000f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(now.timestamp_subsec_micros())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/server.rs:298:9 [INFO] [stderr] | [INFO] [stderr] 298 | / let _: () = Pipeline::new().incr(self.with_namespace(&format!("stat:processed:{}", [INFO] [stderr] 299 | | UTC::now().format("%Y-%m-%d"))), [INFO] [stderr] 300 | | n) [INFO] [stderr] 301 | | .incr(self.with_namespace(&format!("stat:processed")), n) [INFO] [stderr] 302 | | .query(&*connection)?; [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:301:40 [INFO] [stderr] | [INFO] [stderr] 301 | .incr(self.with_namespace(&format!("stat:processed")), n) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"stat:processed".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/server.rs:310:9 [INFO] [stderr] | [INFO] [stderr] 310 | / let _: () = Pipeline::new() [INFO] [stderr] 311 | | .incr(self.with_namespace(&format!("stat:failed:{}", UTC::now().format("%Y-%m-%d"))), [INFO] [stderr] 312 | | n) [INFO] [stderr] 313 | | .incr(self.with_namespace(&format!("stat:failed")), n) [INFO] [stderr] 314 | | .query(&*connection)?; [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:313:40 [INFO] [stderr] | [INFO] [stderr] 313 | .incr(self.with_namespace(&format!("stat:failed")), n) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"stat:failed".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/server.rs:320:39 [INFO] [stderr] | [INFO] [stderr] 320 | let host = rust_gethostname().unwrap_or("unknown".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "unknown".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/job.rs:64:18 [INFO] [stderr] | [INFO] [stderr] 64 | .ok_or(D::Error::custom("no member 'retry'"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| D::Error::custom("no member 'retry'"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/job.rs:120:33 [INFO] [stderr] | [INFO] [stderr] 120 | created_at.timestamp_subsec_nanos() as f64 / 1e9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(created_at.timestamp_subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/job.rs:126:27 [INFO] [stderr] | [INFO] [stderr] 126 | self.enqueued_at.timestamp_subsec_nanos() as f64 / 1e9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.enqueued_at.timestamp_subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/job.rs:131:57 [INFO] [stderr] | [INFO] [stderr] 131 | let timestamp = at.timestamp() as f64 + at.timestamp_subsec_nanos() as f64 / 1e9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(at.timestamp_subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/job.rs:150:29 [INFO] [stderr] | [INFO] [stderr] 150 | retry_info.failed_at.timestamp_subsec_nanos() as f64 / 1e9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(retry_info.failed_at.timestamp_subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/job.rs:154:34 [INFO] [stderr] | [INFO] [stderr] 154 | retried_at.timestamp_subsec_nanos() as f64 / 1e9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(retried_at.timestamp_subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/job.rs:196:14 [INFO] [stderr] | [INFO] [stderr] 196 | .ok_or(D::Error::custom(format!("no member '{}'", key))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| D::Error::custom(format!("no member '{}'", key)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/job.rs:227:14 [INFO] [stderr] | [INFO] [stderr] 227 | .ok_or(D::Error::custom(format!("no member '{}'", key))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| D::Error::custom(format!("no member '{}'", key)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/worker.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub fn new(server_id: &str, [INFO] [stderr] 45 | | pool: RedisPool, [INFO] [stderr] 46 | | tx: Sender, [INFO] [stderr] 47 | | rx: Receiver, [INFO] [stderr] ... | [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/worker.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | / let _: () = Pipeline::new().hset(&self.with_namespace(&self.with_server_id("workers")), [INFO] [stderr] 208 | | &self.id, [INFO] [stderr] 209 | | to_string(&payload).unwrap()) [INFO] [stderr] 210 | | .expire(&self.with_namespace(&self.with_server_id("workers")), 5) [INFO] [stderr] 211 | | .query(&*conn)?; [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/worker.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | / let _: () = self.pool [INFO] [stderr] 219 | | .get()? [INFO] [stderr] 220 | | .hdel(&self.with_namespace(&self.with_server_id("workers")), [INFO] [stderr] 221 | | &self.id)?; [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/middleware.rs:55:30 [INFO] [stderr] | [INFO] [stderr] 55 | .unwrap_or(vec![]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/middleware.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | let _: () = conn.lpush(job.queue_name(), to_string(job).unwrap())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.76s [INFO] running `"docker" "inspect" "142b0312d5296131fab09a5f4f0c9053b9f70107b19da26075514436610c5861"` [INFO] running `"docker" "rm" "-f" "142b0312d5296131fab09a5f4f0c9053b9f70107b19da26075514436610c5861"` [INFO] [stdout] 142b0312d5296131fab09a5f4f0c9053b9f70107b19da26075514436610c5861