[INFO] updating cached repository dovahcrow/nextaction-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dovahcrow/nextaction-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dovahcrow/nextaction-rs" "work/ex/clippy-test-run/sources/stable/gh/dovahcrow/nextaction-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dovahcrow/nextaction-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dovahcrow/nextaction-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dovahcrow/nextaction-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dovahcrow/nextaction-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3a16f77d19c1a9e016856e8a444300fe46525d49 [INFO] sha for GitHub repo dovahcrow/nextaction-rs: 3a16f77d19c1a9e016856e8a444300fe46525d49 [INFO] validating manifest of dovahcrow/nextaction-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dovahcrow/nextaction-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dovahcrow/nextaction-rs [INFO] finished frobbing dovahcrow/nextaction-rs [INFO] frobbed toml for dovahcrow/nextaction-rs written to work/ex/clippy-test-run/sources/stable/gh/dovahcrow/nextaction-rs/Cargo.toml [INFO] started frobbing dovahcrow/nextaction-rs [INFO] finished frobbing dovahcrow/nextaction-rs [INFO] frobbed toml for dovahcrow/nextaction-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dovahcrow/nextaction-rs/Cargo.toml [INFO] crate dovahcrow/nextaction-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dovahcrow/nextaction-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dovahcrow/nextaction-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2511bdac94e7f407e072e963e2607f3fc51d5c5a564bbdc211d22199dc32d41b [INFO] running `"docker" "start" "-a" "2511bdac94e7f407e072e963e2607f3fc51d5c5a564bbdc211d22199dc32d41b"` [INFO] [stderr] Checking base64 v0.2.1 [INFO] [stderr] Checking serde v1.0.1 [INFO] [stderr] Checking toml v0.2.1 [INFO] [stderr] Compiling serde_derive_internals v0.15.0 [INFO] [stderr] Compiling ring v0.7.3 [INFO] [stderr] Checking env_logger v0.4.2 [INFO] [stderr] Checking config v0.4.1 [INFO] [stderr] Compiling serde_derive v1.0.1 [INFO] [stderr] Checking webpki v0.10.1 [INFO] [stderr] Checking rustls v0.5.8 [INFO] [stderr] Checking webpki-roots v0.7.0 [INFO] [stderr] Checking serde_json v1.0.0 [INFO] [stderr] Checking uuid v0.5.0 [INFO] [stderr] Checking hyper-rustls v0.3.2 [INFO] [stderr] Checking nextaction-rs v0.2.2-pre (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/protocol.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | pub const VERSION: &'static str = "v7"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/protocol.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | const ENDPOINT: &'static str = "https://todoist.com/API/v7/sync"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:35:24 [INFO] [stderr] | [INFO] [stderr] 35 | pub const NEXTACTION: &'static str = "NextAction"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | pub const SOMEDAY: &'static str = "Someday"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:189:20 [INFO] [stderr] | [INFO] [stderr] 189 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 190 | | if state == Active && [INFO] [stderr] 191 | | (node.nodes.len() == 0 || node.nodes.iter().all(|l| l.checked()) || [INFO] [stderr] 192 | | (!is_parallel && !is_sequential)) && [INFO] [stderr] ... | [INFO] [stderr] 205 | | } [INFO] [stderr] 206 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 189 | } else if state == Active && [INFO] [stderr] 190 | (node.nodes.len() == 0 || node.nodes.iter().all(|l| l.checked()) || [INFO] [stderr] 191 | (!is_parallel && !is_sequential)) && [INFO] [stderr] 192 | !rnode.labels.contains(&sdid) { [INFO] [stderr] 193 | if !rnode.labels.contains(&naid) { [INFO] [stderr] 194 | let mut v = vec![naid]; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:199:24 [INFO] [stderr] | [INFO] [stderr] 199 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 200 | | if rnode.labels.contains(&naid) { [INFO] [stderr] 201 | | let v: Vec = [INFO] [stderr] 202 | | rnode.labels.clone().into_iter().filter(|&u| u != naid).collect(); [INFO] [stderr] 203 | | manager.set_item_label(rnode.id, v); [INFO] [stderr] 204 | | } [INFO] [stderr] 205 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 199 | } else if rnode.labels.contains(&naid) { [INFO] [stderr] 200 | let v: Vec = [INFO] [stderr] 201 | rnode.labels.clone().into_iter().filter(|&u| u != naid).collect(); [INFO] [stderr] 202 | manager.set_item_label(rnode.id, v); [INFO] [stderr] 203 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/protocol.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | pub const VERSION: &'static str = "v7"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/protocol.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | const ENDPOINT: &'static str = "https://todoist.com/API/v7/sync"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:35:24 [INFO] [stderr] | [INFO] [stderr] 35 | pub const NEXTACTION: &'static str = "NextAction"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | pub const SOMEDAY: &'static str = "Someday"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:189:20 [INFO] [stderr] | [INFO] [stderr] 189 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 190 | | if state == Active && [INFO] [stderr] 191 | | (node.nodes.len() == 0 || node.nodes.iter().all(|l| l.checked()) || [INFO] [stderr] 192 | | (!is_parallel && !is_sequential)) && [INFO] [stderr] ... | [INFO] [stderr] 205 | | } [INFO] [stderr] 206 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 189 | } else if state == Active && [INFO] [stderr] 190 | (node.nodes.len() == 0 || node.nodes.iter().all(|l| l.checked()) || [INFO] [stderr] 191 | (!is_parallel && !is_sequential)) && [INFO] [stderr] 192 | !rnode.labels.contains(&sdid) { [INFO] [stderr] 193 | if !rnode.labels.contains(&naid) { [INFO] [stderr] 194 | let mut v = vec![naid]; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:199:24 [INFO] [stderr] | [INFO] [stderr] 199 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 200 | | if rnode.labels.contains(&naid) { [INFO] [stderr] 201 | | let v: Vec = [INFO] [stderr] 202 | | rnode.labels.clone().into_iter().filter(|&u| u != naid).collect(); [INFO] [stderr] 203 | | manager.set_item_label(rnode.id, v); [INFO] [stderr] 204 | | } [INFO] [stderr] 205 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 199 | } else if rnode.labels.contains(&naid) { [INFO] [stderr] 200 | let v: Vec = [INFO] [stderr] 201 | rnode.labels.clone().into_iter().filter(|&u| u != naid).collect(); [INFO] [stderr] 202 | manager.set_item_label(rnode.id, v); [INFO] [stderr] 203 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:113:18 [INFO] [stderr] | [INFO] [stderr] 113 | .ok_or("project_id not found in project".to_string())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "project_id not found in project".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:132:42 [INFO] [stderr] | [INFO] [stderr] 132 | self.nextaction_id.ok_or("nextaction_id is None".to_string())?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "nextaction_id is None".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:133:39 [INFO] [stderr] | [INFO] [stderr] 133 | self.someday_id.ok_or("nextaction_id is None".to_string())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "nextaction_id is None".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:150:46 [INFO] [stderr] | [INFO] [stderr] 150 | self.nextaction_id.ok_or("nextaction_id is None".to_string())?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "nextaction_id is None".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:151:43 [INFO] [stderr] | [INFO] [stderr] 151 | self.someday_id.ok_or("nextaction_id is None".to_string())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "nextaction_id is None".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:191:21 [INFO] [stderr] | [INFO] [stderr] 191 | (node.nodes.len() == 0 || node.nodes.iter().all(|l| l.checked()) || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `node.nodes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:293:9 [INFO] [stderr] | [INFO] [stderr] 293 | / match self { [INFO] [stderr] 294 | | &NodeType::ProjectNodeType(ref project) => project.id, [INFO] [stderr] 295 | | &NodeType::ItemNodeType(ref item) => item.id, [INFO] [stderr] 296 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 293 | match *self { [INFO] [stderr] 294 | NodeType::ProjectNodeType(ref project) => project.id, [INFO] [stderr] 295 | NodeType::ItemNodeType(ref item) => item.id, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:300:9 [INFO] [stderr] | [INFO] [stderr] 300 | / match self { [INFO] [stderr] 301 | | &NodeType::ProjectNodeType(ref project) => project.name.clone(), [INFO] [stderr] 302 | | &NodeType::ItemNodeType(ref item) => item.content.clone(), [INFO] [stderr] 303 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 300 | match *self { [INFO] [stderr] 301 | NodeType::ProjectNodeType(ref project) => project.name.clone(), [INFO] [stderr] 302 | NodeType::ItemNodeType(ref item) => item.content.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:307:9 [INFO] [stderr] | [INFO] [stderr] 307 | / match self { [INFO] [stderr] 308 | | &NodeType::ProjectNodeType(_) => false, [INFO] [stderr] 309 | | &NodeType::ItemNodeType(ref node) => node.checked == 1, [INFO] [stderr] 310 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 307 | match *self { [INFO] [stderr] 308 | NodeType::ProjectNodeType(_) => false, [INFO] [stderr] 309 | NodeType::ItemNodeType(ref node) => node.checked == 1, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:314:9 [INFO] [stderr] | [INFO] [stderr] 314 | / match self { [INFO] [stderr] 315 | | &NodeType::ProjectNodeType(_) => true, [INFO] [stderr] 316 | | &NodeType::ItemNodeType(_) => false, [INFO] [stderr] 317 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 314 | match *self { [INFO] [stderr] 315 | NodeType::ProjectNodeType(_) => true, [INFO] [stderr] 316 | NodeType::ItemNodeType(_) => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:113:18 [INFO] [stderr] | [INFO] [stderr] 113 | .ok_or("project_id not found in project".to_string())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "project_id not found in project".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:132:42 [INFO] [stderr] | [INFO] [stderr] 132 | self.nextaction_id.ok_or("nextaction_id is None".to_string())?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "nextaction_id is None".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:133:39 [INFO] [stderr] | [INFO] [stderr] 133 | self.someday_id.ok_or("nextaction_id is None".to_string())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "nextaction_id is None".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:150:46 [INFO] [stderr] | [INFO] [stderr] 150 | self.nextaction_id.ok_or("nextaction_id is None".to_string())?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "nextaction_id is None".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:151:43 [INFO] [stderr] | [INFO] [stderr] 151 | self.someday_id.ok_or("nextaction_id is None".to_string())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "nextaction_id is None".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:191:21 [INFO] [stderr] | [INFO] [stderr] 191 | (node.nodes.len() == 0 || node.nodes.iter().all(|l| l.checked()) || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `node.nodes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:293:9 [INFO] [stderr] | [INFO] [stderr] 293 | / match self { [INFO] [stderr] 294 | | &NodeType::ProjectNodeType(ref project) => project.id, [INFO] [stderr] 295 | | &NodeType::ItemNodeType(ref item) => item.id, [INFO] [stderr] 296 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 293 | match *self { [INFO] [stderr] 294 | NodeType::ProjectNodeType(ref project) => project.id, [INFO] [stderr] 295 | NodeType::ItemNodeType(ref item) => item.id, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:300:9 [INFO] [stderr] | [INFO] [stderr] 300 | / match self { [INFO] [stderr] 301 | | &NodeType::ProjectNodeType(ref project) => project.name.clone(), [INFO] [stderr] 302 | | &NodeType::ItemNodeType(ref item) => item.content.clone(), [INFO] [stderr] 303 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 300 | match *self { [INFO] [stderr] 301 | NodeType::ProjectNodeType(ref project) => project.name.clone(), [INFO] [stderr] 302 | NodeType::ItemNodeType(ref item) => item.content.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:307:9 [INFO] [stderr] | [INFO] [stderr] 307 | / match self { [INFO] [stderr] 308 | | &NodeType::ProjectNodeType(_) => false, [INFO] [stderr] 309 | | &NodeType::ItemNodeType(ref node) => node.checked == 1, [INFO] [stderr] 310 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 307 | match *self { [INFO] [stderr] 308 | NodeType::ProjectNodeType(_) => false, [INFO] [stderr] 309 | NodeType::ItemNodeType(ref node) => node.checked == 1, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:314:9 [INFO] [stderr] | [INFO] [stderr] 314 | / match self { [INFO] [stderr] 315 | | &NodeType::ProjectNodeType(_) => true, [INFO] [stderr] 316 | | &NodeType::ItemNodeType(_) => false, [INFO] [stderr] 317 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 314 | match *self { [INFO] [stderr] 315 | NodeType::ProjectNodeType(_) => true, [INFO] [stderr] 316 | NodeType::ItemNodeType(_) => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/bin/nextaction.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | c.get("NEXTACTION_NAME").map(|n| na.nextaction_name = n.into_str().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(n) = c.get("NEXTACTION_NAME") { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/bin/nextaction.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | c.get("SOMEDAY_NAME").map(|n| na.someday_name = n.into_str().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(n) = c.get("SOMEDAY_NAME") { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> tests/todoist-api.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | client [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> tests/todoist-api.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | let client = Todoist::new(&token); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/bin/nextaction.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | c.get("NEXTACTION_NAME").map(|n| na.nextaction_name = n.into_str().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(n) = c.get("NEXTACTION_NAME") { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/bin/nextaction.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | c.get("SOMEDAY_NAME").map(|n| na.someday_name = n.into_str().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(n) = c.get("SOMEDAY_NAME") { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 32.12s [INFO] running `"docker" "inspect" "2511bdac94e7f407e072e963e2607f3fc51d5c5a564bbdc211d22199dc32d41b"` [INFO] running `"docker" "rm" "-f" "2511bdac94e7f407e072e963e2607f3fc51d5c5a564bbdc211d22199dc32d41b"` [INFO] [stdout] 2511bdac94e7f407e072e963e2607f3fc51d5c5a564bbdc211d22199dc32d41b