[INFO] updating cached repository dovahcrow/keenio-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dovahcrow/keenio-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dovahcrow/keenio-rs" "work/ex/clippy-test-run/sources/stable/gh/dovahcrow/keenio-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dovahcrow/keenio-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dovahcrow/keenio-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dovahcrow/keenio-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dovahcrow/keenio-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0d201c9940f2bc5cd3c7591a40bfc398073c53cc [INFO] sha for GitHub repo dovahcrow/keenio-rs: 0d201c9940f2bc5cd3c7591a40bfc398073c53cc [INFO] validating manifest of dovahcrow/keenio-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dovahcrow/keenio-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dovahcrow/keenio-rs [INFO] finished frobbing dovahcrow/keenio-rs [INFO] frobbed toml for dovahcrow/keenio-rs written to work/ex/clippy-test-run/sources/stable/gh/dovahcrow/keenio-rs/Cargo.toml [INFO] started frobbing dovahcrow/keenio-rs [INFO] finished frobbing dovahcrow/keenio-rs [INFO] frobbed toml for dovahcrow/keenio-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dovahcrow/keenio-rs/Cargo.toml [INFO] crate dovahcrow/keenio-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dovahcrow/keenio-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dovahcrow/keenio-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fefd615528f89c8ac08fb84ce3c417f718aed91d74b7e1133799d5ee577fdbe5 [INFO] running `"docker" "start" "-a" "fefd615528f89c8ac08fb84ce3c417f718aed91d74b7e1133799d5ee577fdbe5"` [INFO] [stderr] Checking itertools v0.4.19 [INFO] [stderr] Checking clap v2.20.5 [INFO] [stderr] Compiling syn v0.11.8 [INFO] [stderr] Compiling rayon v0.6.0 [INFO] [stderr] Checking hyper v0.10.5 [INFO] [stderr] Compiling structopt-derive v0.0.3 [INFO] [stderr] Compiling ring v0.7.3 [INFO] [stderr] Checking structopt v0.0.3 [INFO] [stderr] Checking webpki v0.10.0 [INFO] [stderr] Checking rustls v0.5.8 [INFO] [stderr] Checking webpki-roots v0.7.0 [INFO] [stderr] Checking hyper-rustls v0.3.2 [INFO] [stderr] Checking keen v1.4.2-pre (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | timeframe: timeframe, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timeframe` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | timeframe: timeframe, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timeframe` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:417:34 [INFO] [stderr] | [INFO] [stderr] 417 | .filter(Filter::gt("id", 458888)) [INFO] [stderr] | ^^^^^^ help: consider: `458_888` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:418:35 [INFO] [stderr] | [INFO] [stderr] 418 | .filter(Filter::lte("id", 460000)) [INFO] [stderr] | ^^^^^^ help: consider: `460_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | timeout: self.timeout.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.timeout` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | self.interval.as_ref().map(|i| s.push_str(&format!("&interval={}", i))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(i) = self.interval.as_ref() { s.push_str(&format!("&interval={}", i)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | self.max_age.as_ref().map(|a| s.push_str(&format!("&max_age={}", a))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(a) = self.max_age.as_ref() { s.push_str(&format!("&max_age={}", a)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | / self.timeout [INFO] [stderr] 158 | | .map(|t| { [INFO] [stderr] 159 | | let mut client = [INFO] [stderr] 160 | | Client::with_connector(HttpsConnector::new(hyper_rustls::TlsClient::new())); [INFO] [stderr] ... | [INFO] [stderr] 164 | | }) [INFO] [stderr] 165 | | .unwrap_or(Client::new()) [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 157 | self.timeout [INFO] [stderr] 158 | .map(|t| { [INFO] [stderr] 159 | let mut client = [INFO] [stderr] 160 | Client::with_connector(HttpsConnector::new(hyper_rustls::TlsClient::new())); [INFO] [stderr] 161 | client.set_read_timeout(Some(t)); [INFO] [stderr] 162 | client.set_write_timeout(Some(t)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:410:20 [INFO] [stderr] | [INFO] [stderr] 410 | let from_str = format!("{}", from.to_rfc3339()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `from.to_rfc3339().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:412:18 [INFO] [stderr] | [INFO] [stderr] 412 | let to_str = format!("{}", to.to_rfc3339()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `to.to_rfc3339().to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | timeout: self.timeout.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.timeout` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | self.interval.as_ref().map(|i| s.push_str(&format!("&interval={}", i))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(i) = self.interval.as_ref() { s.push_str(&format!("&interval={}", i)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | self.max_age.as_ref().map(|a| s.push_str(&format!("&max_age={}", a))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(a) = self.max_age.as_ref() { s.push_str(&format!("&max_age={}", a)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | / self.timeout [INFO] [stderr] 158 | | .map(|t| { [INFO] [stderr] 159 | | let mut client = [INFO] [stderr] 160 | | Client::with_connector(HttpsConnector::new(hyper_rustls::TlsClient::new())); [INFO] [stderr] ... | [INFO] [stderr] 164 | | }) [INFO] [stderr] 165 | | .unwrap_or(Client::new()) [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 157 | self.timeout [INFO] [stderr] 158 | .map(|t| { [INFO] [stderr] 159 | let mut client = [INFO] [stderr] 160 | Client::with_connector(HttpsConnector::new(hyper_rustls::TlsClient::new())); [INFO] [stderr] 161 | client.set_read_timeout(Some(t)); [INFO] [stderr] 162 | client.set_write_timeout(Some(t)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 27.27s [INFO] running `"docker" "inspect" "fefd615528f89c8ac08fb84ce3c417f718aed91d74b7e1133799d5ee577fdbe5"` [INFO] running `"docker" "rm" "-f" "fefd615528f89c8ac08fb84ce3c417f718aed91d74b7e1133799d5ee577fdbe5"` [INFO] [stdout] fefd615528f89c8ac08fb84ce3c417f718aed91d74b7e1133799d5ee577fdbe5