[INFO] updating cached repository dottorblaster/siren
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/dottorblaster/siren
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/dottorblaster/siren" "work/ex/clippy-test-run/sources/stable/gh/dottorblaster/siren"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dottorblaster/siren'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/dottorblaster/siren" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dottorblaster/siren"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dottorblaster/siren'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 493b0eac37fd41d4122e9efe2638ef745f0415ef
[INFO] sha for GitHub repo dottorblaster/siren: 493b0eac37fd41d4122e9efe2638ef745f0415ef
[INFO] validating manifest of dottorblaster/siren on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dottorblaster/siren on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dottorblaster/siren
[INFO] finished frobbing dottorblaster/siren
[INFO] frobbed toml for dottorblaster/siren written to work/ex/clippy-test-run/sources/stable/gh/dottorblaster/siren/Cargo.toml
[INFO] started frobbing dottorblaster/siren
[INFO] finished frobbing dottorblaster/siren
[INFO] frobbed toml for dottorblaster/siren written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dottorblaster/siren/Cargo.toml
[INFO] crate dottorblaster/siren has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting dottorblaster/siren against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dottorblaster/siren:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b82e4832077a79491c9f56aa43d6086a07200a1ef25a636399d77cb18103053f
[INFO] running `"docker" "start" "-a" "b82e4832077a79491c9f56aa43d6086a07200a1ef25a636399d77cb18103053f"`
[INFO] [stderr]     Checking atty v0.2.11
[INFO] [stderr]     Checking clap v2.32.0
[INFO] [stderr]     Checking siren v1.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/parse_config.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 |     configuration
[INFO] [stderr]    |     ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/parse_config.rs:25:25
[INFO] [stderr]    |
[INFO] [stderr] 25 |       let configuration = match configparse(confstring) {
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 26 | |         Ok(c) => c,
[INFO] [stderr] 27 | |         Err(err) => {
[INFO] [stderr] 28 | |             println!("{}", err.description());
[INFO] [stderr] 29 | |             Config { switch_cwd: false, tasks: Vec::new() }
[INFO] [stderr] 30 | |         }
[INFO] [stderr] 31 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/parse_config.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 |     configuration
[INFO] [stderr]    |     ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/parse_config.rs:25:25
[INFO] [stderr]    |
[INFO] [stderr] 25 |       let configuration = match configparse(confstring) {
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 26 | |         Ok(c) => c,
[INFO] [stderr] 27 | |         Err(err) => {
[INFO] [stderr] 28 | |             println!("{}", err.description());
[INFO] [stderr] 29 | |             Config { switch_cwd: false, tasks: Vec::new() }
[INFO] [stderr] 30 | |         }
[INFO] [stderr] 31 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/execute.rs:16:8
[INFO] [stderr]    |
[INFO] [stderr] 16 |     if json == false {
[INFO] [stderr]    |        ^^^^^^^^^^^^^ help: try simplifying it as shown: `!json`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/execute.rs:21:26
[INFO] [stderr]    |
[INFO] [stderr] 21 |             Yellow.paint(format!("{}", task.name)),
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `task.name.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/execute.rs:28:8
[INFO] [stderr]    |
[INFO] [stderr] 28 |     if json == false {
[INFO] [stderr]    |        ^^^^^^^^^^^^^ help: try simplifying it as shown: `!json`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/execute.rs:33:26
[INFO] [stderr]    |
[INFO] [stderr] 33 |             Yellow.paint(format!("{}", task.name)),
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `task.name.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/execute.rs:40:8
[INFO] [stderr]    |
[INFO] [stderr] 40 |     if json == true {
[INFO] [stderr]    |        ^^^^^^^^^^^^ help: try simplifying it as shown: `json`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/execute.rs:16:8
[INFO] [stderr]    |
[INFO] [stderr] 16 |     if json == false {
[INFO] [stderr]    |        ^^^^^^^^^^^^^ help: try simplifying it as shown: `!json`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/execute.rs:21:26
[INFO] [stderr]    |
[INFO] [stderr] 21 |             Yellow.paint(format!("{}", task.name)),
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `task.name.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:17:39
[INFO] [stderr]    |
[INFO] [stderr] 17 |     let mut v: Vec<&str> = path.split("/").collect();
[INFO] [stderr]    |                                       ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/execute.rs:28:8
[INFO] [stderr]    |
[INFO] [stderr] 28 |     if json == false {
[INFO] [stderr]    |        ^^^^^^^^^^^^^ help: try simplifying it as shown: `!json`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/execute.rs:33:26
[INFO] [stderr]    |
[INFO] [stderr] 33 |             Yellow.paint(format!("{}", task.name)),
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `task.name.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/execute.rs:40:8
[INFO] [stderr]    |
[INFO] [stderr] 40 |     if json == true {
[INFO] [stderr]    |        ^^^^^^^^^^^^ help: try simplifying it as shown: `json`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:62:20
[INFO] [stderr]    |
[INFO] [stderr] 62 |       let cwd_path = match conf.switch_cwd {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 63 | |         true => parentpath(matches.value_of("file").unwrap_or("./Sirenfile.json").to_owned()),
[INFO] [stderr] 64 | |         false => String::from(".")
[INFO] [stderr] 65 | |     };
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if conf.switch_cwd { parentpath(matches.value_of("file").unwrap_or("./Sirenfile.json").to_owned()) } else { String::from(".") }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:17:39
[INFO] [stderr]    |
[INFO] [stderr] 17 |     let mut v: Vec<&str> = path.split("/").collect();
[INFO] [stderr]    |                                       ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:62:20
[INFO] [stderr]    |
[INFO] [stderr] 62 |       let cwd_path = match conf.switch_cwd {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 63 | |         true => parentpath(matches.value_of("file").unwrap_or("./Sirenfile.json").to_owned()),
[INFO] [stderr] 64 | |         false => String::from(".")
[INFO] [stderr] 65 | |     };
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if conf.switch_cwd { parentpath(matches.value_of("file").unwrap_or("./Sirenfile.json").to_owned()) } else { String::from(".") }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.56s
[INFO] running `"docker" "inspect" "b82e4832077a79491c9f56aa43d6086a07200a1ef25a636399d77cb18103053f"`
[INFO] running `"docker" "rm" "-f" "b82e4832077a79491c9f56aa43d6086a07200a1ef25a636399d77cb18103053f"`
[INFO] [stdout] b82e4832077a79491c9f56aa43d6086a07200a1ef25a636399d77cb18103053f