[INFO] updating cached repository dotboris/alt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dotboris/alt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dotboris/alt" "work/ex/clippy-test-run/sources/stable/gh/dotboris/alt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dotboris/alt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dotboris/alt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dotboris/alt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dotboris/alt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2dcf1fecd6df1d143df401002fc573ded9172c7a [INFO] sha for GitHub repo dotboris/alt: 2dcf1fecd6df1d143df401002fc573ded9172c7a [INFO] validating manifest of dotboris/alt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dotboris/alt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dotboris/alt [INFO] finished frobbing dotboris/alt [INFO] frobbed toml for dotboris/alt written to work/ex/clippy-test-run/sources/stable/gh/dotboris/alt/Cargo.toml [INFO] started frobbing dotboris/alt [INFO] finished frobbing dotboris/alt [INFO] frobbed toml for dotboris/alt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dotboris/alt/Cargo.toml [INFO] crate dotboris/alt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dotboris/alt against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dotboris/alt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2e0f7425e17d4ef2addd3e9b851a788c0544fc46403c4b9301a4c99ed9142dad [INFO] running `"docker" "start" "-a" "2e0f7425e17d4ef2addd3e9b851a788c0544fc46403c4b9301a4c99ed9142dad"` [INFO] [stderr] Compiling serde v1.0.80 [INFO] [stderr] Compiling escargot v0.3.1 [INFO] [stderr] Checking predicates-core v1.0.0 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking console v0.6.2 [INFO] [stderr] Checking predicates v1.0.0 [INFO] [stderr] Checking predicates-tree v1.0.0 [INFO] [stderr] Checking dialoguer v0.1.0 [INFO] [stderr] Checking serde_json v1.0.32 [INFO] [stderr] Checking toml v0.4.8 [INFO] [stderr] Checking alt v1.0.2 (/opt/crater/workdir) [INFO] [stderr] Checking assert_cmd v0.10.1 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/test_env.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/test_env.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `TestEnv` [INFO] [stderr] --> tests/test_env.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Self { [INFO] [stderr] 23 | | let rand_ns: String = thread_rng() [INFO] [stderr] 24 | | .sample_iter(&Alphanumeric) [INFO] [stderr] 25 | | .take(10) [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/test_env.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | .expect(&format!("failed to created tmp env {:?}", &root)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to created tmp env {:?}", &root))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/test_env.rs:87:14 [INFO] [stderr] | [INFO] [stderr] 87 | .expect(&format!("failed to remove {:?}", &self.root)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to remove {:?}", &self.root))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/test_env.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | .expect(&format!("failed to created tmp env {:?}", &root)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to created tmp env {:?}", &root))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/test_env.rs:87:14 [INFO] [stderr] | [INFO] [stderr] 87 | .expect(&format!("failed to remove {:?}", &self.root)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to remove {:?}", &self.root))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.86s [INFO] running `"docker" "inspect" "2e0f7425e17d4ef2addd3e9b851a788c0544fc46403c4b9301a4c99ed9142dad"` [INFO] running `"docker" "rm" "-f" "2e0f7425e17d4ef2addd3e9b851a788c0544fc46403c4b9301a4c99ed9142dad"` [INFO] [stdout] 2e0f7425e17d4ef2addd3e9b851a788c0544fc46403c4b9301a4c99ed9142dad