[INFO] updating cached repository doshmajhan/corrosion [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/doshmajhan/corrosion [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/doshmajhan/corrosion" "work/ex/clippy-test-run/sources/stable/gh/doshmajhan/corrosion"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/doshmajhan/corrosion'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/doshmajhan/corrosion" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/doshmajhan/corrosion"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/doshmajhan/corrosion'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1f01ba07937d651cc520c70acf1fe7e24cbb5e38 [INFO] sha for GitHub repo doshmajhan/corrosion: 1f01ba07937d651cc520c70acf1fe7e24cbb5e38 [INFO] validating manifest of doshmajhan/corrosion on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of doshmajhan/corrosion on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing doshmajhan/corrosion [INFO] finished frobbing doshmajhan/corrosion [INFO] frobbed toml for doshmajhan/corrosion written to work/ex/clippy-test-run/sources/stable/gh/doshmajhan/corrosion/Cargo.toml [INFO] started frobbing doshmajhan/corrosion [INFO] finished frobbing doshmajhan/corrosion [INFO] frobbed toml for doshmajhan/corrosion written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/doshmajhan/corrosion/Cargo.toml [INFO] crate doshmajhan/corrosion has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting doshmajhan/corrosion against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/doshmajhan/corrosion:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ae32b69d61a6a5558e95dee67bff7d281143547774425980efdb614f5f262b8e [INFO] running `"docker" "start" "-a" "ae32b69d61a6a5558e95dee67bff7d281143547774425980efdb614f5f262b8e"` [INFO] [stderr] Compiling regex-syntax v0.4.2 [INFO] [stderr] Compiling memchr v2.0.1 [INFO] [stderr] Checking pnet_sys v0.20.0 [INFO] [stderr] Compiling thread_local v0.3.5 [INFO] [stderr] Compiling syntex_errors v0.42.0 [INFO] [stderr] Checking pnet_datalink v0.20.0 [INFO] [stderr] Compiling aho-corasick v0.6.4 [INFO] [stderr] Compiling syntex_syntax v0.42.0 [INFO] [stderr] Compiling regex v0.2.6 [INFO] [stderr] Compiling syntex v0.42.2 [INFO] [stderr] Compiling pnet_macros v0.20.0 [INFO] [stderr] Compiling pnet_packet v0.20.0 [INFO] [stderr] Checking pnet_transport v0.20.0 [INFO] [stderr] Checking pnet v0.20.0 [INFO] [stderr] Checking corrosion v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused imports: `SocketAddr`, `ToSocketAddrs` [INFO] [stderr] --> src/query/mod.rs:1:16 [INFO] [stderr] | [INFO] [stderr] 1 | use std::net::{SocketAddr, ToSocketAddrs}; [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused variable: `domain_ip` [INFO] [stderr] --> src/main.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | let domain_ip = client.resolve_domain_to_ip().unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_domain_ip` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `SocketAddr`, `ToSocketAddrs` [INFO] [stderr] --> src/query/mod.rs:1:16 [INFO] [stderr] | [INFO] [stderr] 1 | use std::net::{SocketAddr, ToSocketAddrs}; [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client/mod.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / match args.get("command"){ [INFO] [stderr] 16 | | Some(command) => query.command = command.to_string(), [INFO] [stderr] 17 | | None => () [INFO] [stderr] 18 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(command) = args.get("command") { query.command = command.to_string() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client/mod.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / match args.get("domain") { [INFO] [stderr] 21 | | Some(domain) => { [INFO] [stderr] 22 | | query.domain = domain.to_string(); [INFO] [stderr] 23 | | query.domain.push_str(":53") [INFO] [stderr] 24 | | }, [INFO] [stderr] 25 | | None => (), [INFO] [stderr] 26 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | if let Some(domain) = args.get("domain") { [INFO] [stderr] 21 | query.domain = domain.to_string(); [INFO] [stderr] 22 | query.domain.push_str(":53") [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client/mod.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / match args.get("server") { [INFO] [stderr] 29 | | Some(server) => query.server = server.to_string(), [INFO] [stderr] 30 | | None => (), [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(server) = args.get("server") { query.server = server.to_string() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / match domain { [INFO] [stderr] 18 | | Some(d) => { [INFO] [stderr] 19 | | args_dict.insert(String::from("domain"), d); [INFO] [stderr] 20 | | () [INFO] [stderr] 21 | | }, [INFO] [stderr] 22 | | None => (), [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | if let Some(d) = domain { [INFO] [stderr] 18 | args_dict.insert(String::from("domain"), d); [INFO] [stderr] 19 | () [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / match server { [INFO] [stderr] 27 | | Some(s) => { [INFO] [stderr] 28 | | args_dict.insert(String::from("server"), s); [INFO] [stderr] 29 | | () [INFO] [stderr] 30 | | }, [INFO] [stderr] 31 | | None => (), [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | if let Some(s) = server { [INFO] [stderr] 27 | args_dict.insert(String::from("server"), s); [INFO] [stderr] 28 | () [INFO] [stderr] 29 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `domain_ip` [INFO] [stderr] --> src/main.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | let domain_ip = client.resolve_domain_to_ip().unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_domain_ip` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client/mod.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / match args.get("command"){ [INFO] [stderr] 16 | | Some(command) => query.command = command.to_string(), [INFO] [stderr] 17 | | None => () [INFO] [stderr] 18 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(command) = args.get("command") { query.command = command.to_string() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client/mod.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / match args.get("domain") { [INFO] [stderr] 21 | | Some(domain) => { [INFO] [stderr] 22 | | query.domain = domain.to_string(); [INFO] [stderr] 23 | | query.domain.push_str(":53") [INFO] [stderr] 24 | | }, [INFO] [stderr] 25 | | None => (), [INFO] [stderr] 26 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | if let Some(domain) = args.get("domain") { [INFO] [stderr] 21 | query.domain = domain.to_string(); [INFO] [stderr] 22 | query.domain.push_str(":53") [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client/mod.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / match args.get("server") { [INFO] [stderr] 29 | | Some(server) => query.server = server.to_string(), [INFO] [stderr] 30 | | None => (), [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(server) = args.get("server") { query.server = server.to_string() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / match domain { [INFO] [stderr] 18 | | Some(d) => { [INFO] [stderr] 19 | | args_dict.insert(String::from("domain"), d); [INFO] [stderr] 20 | | () [INFO] [stderr] 21 | | }, [INFO] [stderr] 22 | | None => (), [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | if let Some(d) = domain { [INFO] [stderr] 18 | args_dict.insert(String::from("domain"), d); [INFO] [stderr] 19 | () [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / match server { [INFO] [stderr] 27 | | Some(s) => { [INFO] [stderr] 28 | | args_dict.insert(String::from("server"), s); [INFO] [stderr] 29 | | () [INFO] [stderr] 30 | | }, [INFO] [stderr] 31 | | None => (), [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | if let Some(s) = server { [INFO] [stderr] 27 | args_dict.insert(String::from("server"), s); [INFO] [stderr] 28 | () [INFO] [stderr] 29 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 03s [INFO] running `"docker" "inspect" "ae32b69d61a6a5558e95dee67bff7d281143547774425980efdb614f5f262b8e"` [INFO] running `"docker" "rm" "-f" "ae32b69d61a6a5558e95dee67bff7d281143547774425980efdb614f5f262b8e"` [INFO] [stdout] ae32b69d61a6a5558e95dee67bff7d281143547774425980efdb614f5f262b8e