[INFO] updating cached repository donflopez/clitask [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/donflopez/clitask [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/donflopez/clitask" "work/ex/clippy-test-run/sources/stable/gh/donflopez/clitask"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/donflopez/clitask'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/donflopez/clitask" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/donflopez/clitask"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/donflopez/clitask'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0e114eddaf90a36bf02abaae54ea6d694f4f139a [INFO] sha for GitHub repo donflopez/clitask: 0e114eddaf90a36bf02abaae54ea6d694f4f139a [INFO] validating manifest of donflopez/clitask on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of donflopez/clitask on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing donflopez/clitask [INFO] finished frobbing donflopez/clitask [INFO] frobbed toml for donflopez/clitask written to work/ex/clippy-test-run/sources/stable/gh/donflopez/clitask/Cargo.toml [INFO] started frobbing donflopez/clitask [INFO] finished frobbing donflopez/clitask [INFO] frobbed toml for donflopez/clitask written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/donflopez/clitask/Cargo.toml [INFO] crate donflopez/clitask has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting donflopez/clitask against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/donflopez/clitask:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 95fd8565c545e3ccc9eb89d5dc85bfb4c6f04bd7edfb7932d4c9cc3dafa22559 [INFO] running `"docker" "start" "-a" "95fd8565c545e3ccc9eb89d5dc85bfb4c6f04bd7edfb7932d4c9cc3dafa22559"` [INFO] [stderr] Checking curl v0.4.18 [INFO] [stderr] Checking preferences v1.1.0 [INFO] [stderr] Checking clitask v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/main.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | Err(e) => Settings { [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/main.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | Err(e) => Settings { [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/command.rs:58:44 [INFO] [stderr] | [INFO] [stderr] 58 | let wt_path = wt.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/command.rs:96:20 [INFO] [stderr] | [INFO] [stderr] 96 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/command.rs:110:25 [INFO] [stderr] | [INFO] [stderr] 110 | String::from(format!("{} {}", "No webtask found with the name ", wt_name)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{} {}", "No webtask found with the name ", wt_name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/settings.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | self.save(&APP_INFO, ".config"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/settings.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | self.save(&APP_INFO, ".config"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/command.rs:58:44 [INFO] [stderr] | [INFO] [stderr] 58 | let wt_path = wt.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/command.rs:96:20 [INFO] [stderr] | [INFO] [stderr] 96 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/command.rs:110:25 [INFO] [stderr] | [INFO] [stderr] 110 | String::from(format!("{} {}", "No webtask found with the name ", wt_name)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{} {}", "No webtask found with the name ", wt_name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/settings.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | self.save(&APP_INFO, ".config"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/settings.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | self.save(&APP_INFO, ".config"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.96s [INFO] running `"docker" "inspect" "95fd8565c545e3ccc9eb89d5dc85bfb4c6f04bd7edfb7932d4c9cc3dafa22559"` [INFO] running `"docker" "rm" "-f" "95fd8565c545e3ccc9eb89d5dc85bfb4c6f04bd7edfb7932d4c9cc3dafa22559"` [INFO] [stdout] 95fd8565c545e3ccc9eb89d5dc85bfb4c6f04bd7edfb7932d4c9cc3dafa22559