[INFO] updating cached repository donaldacmartin/rust_servers
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/donaldacmartin/rust_servers
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/donaldacmartin/rust_servers" "work/ex/clippy-test-run/sources/stable/gh/donaldacmartin/rust_servers"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/donaldacmartin/rust_servers'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/donaldacmartin/rust_servers" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/donaldacmartin/rust_servers"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/donaldacmartin/rust_servers'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 7547384cd6262de244a34f7dc997ea0ddbeb5a92
[INFO] sha for GitHub repo donaldacmartin/rust_servers: 7547384cd6262de244a34f7dc997ea0ddbeb5a92
[INFO] validating manifest of donaldacmartin/rust_servers on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of donaldacmartin/rust_servers on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing donaldacmartin/rust_servers
[INFO] finished frobbing donaldacmartin/rust_servers
[INFO] frobbed toml for donaldacmartin/rust_servers written to work/ex/clippy-test-run/sources/stable/gh/donaldacmartin/rust_servers/Cargo.toml
[INFO] started frobbing donaldacmartin/rust_servers
[INFO] finished frobbing donaldacmartin/rust_servers
[INFO] frobbed toml for donaldacmartin/rust_servers written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/donaldacmartin/rust_servers/Cargo.toml
[INFO] crate donaldacmartin/rust_servers has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting donaldacmartin/rust_servers against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/donaldacmartin/rust_servers:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8be5d0eadfb4930db7a3a6835956ec68cf0c71deabf3d3d767b24e1a04ac8ada
[INFO] running `"docker" "start" "-a" "8be5d0eadfb4930db7a3a6835956ec68cf0c71deabf3d3d767b24e1a04ac8ada"`
[INFO] [stderr]     Checking network v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/bin/echo.rs:17:12
[INFO] [stderr]    |
[INFO] [stderr] 17 |         if !stream.write(&buffer).is_ok() {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `stream.write(&buffer).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/bin/time.rs:12:31
[INFO] [stderr]    |
[INFO] [stderr] 12 | const SECONDS_TO_EPOCH: u64 = 2208988800;
[INFO] [stderr]    |                               ^^^^^^^^^^ help: consider: `2_208_988_800`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/time.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     return (now_utc().to_timespec().sec as u64) + SECONDS_TO_EPOCH;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(now_utc().to_timespec().sec as u64) + SECONDS_TO_EPOCH`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/time.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     return bytes;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `bytes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/chargen.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 |     return chars;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `chars`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/daytime.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     return now_utc().asctime().to_string().into_bytes();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `now_utc().asctime().to_string().into_bytes()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/bin/echo.rs:17:12
[INFO] [stderr]    |
[INFO] [stderr] 17 |         if !stream.write(&buffer).is_ok() {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `stream.write(&buffer).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/daytime.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     return now_utc().asctime().to_string().into_bytes();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `now_utc().asctime().to_string().into_bytes()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/bin/daytime.rs:24:12
[INFO] [stderr]    |
[INFO] [stderr] 24 |         if !result.is_ok() || result.unwrap() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `result.is_err() || result.unwrap() == 0`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `index` is only used to index `chars`.
[INFO] [stderr]   --> src/bin/chargen.rs:18:18
[INFO] [stderr]    |
[INFO] [stderr] 18 |     for index in 0..72 {
[INFO] [stderr]    |                  ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 18 |     for <item> in chars.iter_mut().take(72) {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/chargen.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 |     return chars;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `chars`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/bin/daytime.rs:24:12
[INFO] [stderr]    |
[INFO] [stderr] 24 |         if !result.is_ok() || result.unwrap() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `result.is_err() || result.unwrap() == 0`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/bin/time.rs:33:8
[INFO] [stderr]    |
[INFO] [stderr] 33 |     if !result.is_ok() {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^ help: try: `result.is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `index` is only used to index `chars`.
[INFO] [stderr]   --> src/bin/chargen.rs:18:18
[INFO] [stderr]    |
[INFO] [stderr] 18 |     for index in 0..72 {
[INFO] [stderr]    |                  ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 18 |     for <item> in chars.iter_mut().take(72) {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/bin/time.rs:12:31
[INFO] [stderr]    |
[INFO] [stderr] 12 | const SECONDS_TO_EPOCH: u64 = 2208988800;
[INFO] [stderr]    |                               ^^^^^^^^^^ help: consider: `2_208_988_800`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/time.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     return (now_utc().to_timespec().sec as u64) + SECONDS_TO_EPOCH;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(now_utc().to_timespec().sec as u64) + SECONDS_TO_EPOCH`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/time.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     return bytes;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `bytes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/bin/time.rs:33:8
[INFO] [stderr]    |
[INFO] [stderr] 33 |     if !result.is_ok() {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^ help: try: `result.is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.88s
[INFO] running `"docker" "inspect" "8be5d0eadfb4930db7a3a6835956ec68cf0c71deabf3d3d767b24e1a04ac8ada"`
[INFO] running `"docker" "rm" "-f" "8be5d0eadfb4930db7a3a6835956ec68cf0c71deabf3d3d767b24e1a04ac8ada"`
[INFO] [stdout] 8be5d0eadfb4930db7a3a6835956ec68cf0c71deabf3d3d767b24e1a04ac8ada