[INFO] updating cached repository donachys/midpoint_displacement_2d_terrain [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/donachys/midpoint_displacement_2d_terrain [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/donachys/midpoint_displacement_2d_terrain" "work/ex/clippy-test-run/sources/stable/gh/donachys/midpoint_displacement_2d_terrain"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/donachys/midpoint_displacement_2d_terrain'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/donachys/midpoint_displacement_2d_terrain" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/donachys/midpoint_displacement_2d_terrain"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/donachys/midpoint_displacement_2d_terrain'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 649e1ef34a71b4ec2d4b077d7a52cc16c05d5cdd [INFO] sha for GitHub repo donachys/midpoint_displacement_2d_terrain: 649e1ef34a71b4ec2d4b077d7a52cc16c05d5cdd [INFO] validating manifest of donachys/midpoint_displacement_2d_terrain on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of donachys/midpoint_displacement_2d_terrain on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing donachys/midpoint_displacement_2d_terrain [INFO] finished frobbing donachys/midpoint_displacement_2d_terrain [INFO] frobbed toml for donachys/midpoint_displacement_2d_terrain written to work/ex/clippy-test-run/sources/stable/gh/donachys/midpoint_displacement_2d_terrain/Cargo.toml [INFO] started frobbing donachys/midpoint_displacement_2d_terrain [INFO] finished frobbing donachys/midpoint_displacement_2d_terrain [INFO] frobbed toml for donachys/midpoint_displacement_2d_terrain written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/donachys/midpoint_displacement_2d_terrain/Cargo.toml [INFO] crate donachys/midpoint_displacement_2d_terrain has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting donachys/midpoint_displacement_2d_terrain against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/donachys/midpoint_displacement_2d_terrain:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0ece2c8b7b3fe6bc39227d175c09a3f2ec4900a7f8a7223e6f8b113c8d1e9002 [INFO] running `"docker" "start" "-a" "0ece2c8b7b3fe6bc39227d175c09a3f2ec4900a7f8a7223e6f8b113c8d1e9002"` [INFO] [stderr] Compiling miniz-sys v0.1.7 [INFO] [stderr] Checking deque v0.3.1 [INFO] [stderr] Checking enum_primitive v0.1.0 [INFO] [stderr] Checking rayon v0.6.0 [INFO] [stderr] Checking flate2 v0.2.14 [INFO] [stderr] Checking jpeg-decoder v0.1.10 [INFO] [stderr] Checking png v0.5.2 [INFO] [stderr] Checking image v0.10.4 [INFO] [stderr] Checking midpoint_displacement_2d v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | let mut pixel = imgbuf.get_pixel_mut(wheel_center.x, wheel_center.y); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | let mut pixel = imgbuf.get_pixel_mut(wheel_center.x, wheel_center.y); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | let ref mut fout = File::create(&Path::new("terrain.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^---------------------------------------------------- help: try: `let fout = &mut File::create(&Path::new("terrain.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:108:21 [INFO] [stderr] | [INFO] [stderr] 108 | fn in_bounds(point: &Point2d, bound_x: u32, bound_y: u32) -> bool { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Point2d` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / let mut reversed = false; [INFO] [stderr] 124 | | if x1 > x2 { [INFO] [stderr] 125 | | std::mem::swap(&mut x1, &mut x2); [INFO] [stderr] 126 | | std::mem::swap(&mut y1, &mut y2); [INFO] [stderr] 127 | | reversed = true; [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let reversed = if x1 > x2 { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | / let ystep: i32; [INFO] [stderr] 134 | | if y1 < y2 { [INFO] [stderr] 135 | | ystep = 1; [INFO] [stderr] 136 | | } else { [INFO] [stderr] 137 | | ystep = -1; [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let ystep = if y1 < y2 { 1 } else { -1 };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:139:14 [INFO] [stderr] | [INFO] [stderr] 139 | for x in x1..(x2+1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `x1..=x2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | let ref mut fout = File::create(&Path::new("terrain.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^---------------------------------------------------- help: try: `let fout = &mut File::create(&Path::new("terrain.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:108:21 [INFO] [stderr] | [INFO] [stderr] 108 | fn in_bounds(point: &Point2d, bound_x: u32, bound_y: u32) -> bool { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Point2d` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / let mut reversed = false; [INFO] [stderr] 124 | | if x1 > x2 { [INFO] [stderr] 125 | | std::mem::swap(&mut x1, &mut x2); [INFO] [stderr] 126 | | std::mem::swap(&mut y1, &mut y2); [INFO] [stderr] 127 | | reversed = true; [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let reversed = if x1 > x2 { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | / let ystep: i32; [INFO] [stderr] 134 | | if y1 < y2 { [INFO] [stderr] 135 | | ystep = 1; [INFO] [stderr] 136 | | } else { [INFO] [stderr] 137 | | ystep = -1; [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let ystep = if y1 < y2 { 1 } else { -1 };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:139:14 [INFO] [stderr] | [INFO] [stderr] 139 | for x in x1..(x2+1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `x1..=x2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.45s [INFO] running `"docker" "inspect" "0ece2c8b7b3fe6bc39227d175c09a3f2ec4900a7f8a7223e6f8b113c8d1e9002"` [INFO] running `"docker" "rm" "-f" "0ece2c8b7b3fe6bc39227d175c09a3f2ec4900a7f8a7223e6f8b113c8d1e9002"` [INFO] [stdout] 0ece2c8b7b3fe6bc39227d175c09a3f2ec4900a7f8a7223e6f8b113c8d1e9002