[INFO] updating cached repository don-smith/rusty-chain [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/don-smith/rusty-chain [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/don-smith/rusty-chain" "work/ex/clippy-test-run/sources/stable/gh/don-smith/rusty-chain"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/don-smith/rusty-chain'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/don-smith/rusty-chain" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/don-smith/rusty-chain"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/don-smith/rusty-chain'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5749ba512b72f51c9be38e157cdc16aee63a0711 [INFO] sha for GitHub repo don-smith/rusty-chain: 5749ba512b72f51c9be38e157cdc16aee63a0711 [INFO] validating manifest of don-smith/rusty-chain on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of don-smith/rusty-chain on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing don-smith/rusty-chain [INFO] finished frobbing don-smith/rusty-chain [INFO] frobbed toml for don-smith/rusty-chain written to work/ex/clippy-test-run/sources/stable/gh/don-smith/rusty-chain/Cargo.toml [INFO] started frobbing don-smith/rusty-chain [INFO] finished frobbing don-smith/rusty-chain [INFO] frobbed toml for don-smith/rusty-chain written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/don-smith/rusty-chain/Cargo.toml [INFO] crate don-smith/rusty-chain has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting don-smith/rusty-chain against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/don-smith/rusty-chain:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f6ddf8b140080263dc5cb945078888271e967243efaa312f6e87b8096bd34ddb [INFO] running `"docker" "start" "-a" "f6ddf8b140080263dc5cb945078888271e967243efaa312f6e87b8096bd34ddb"` [INFO] [stderr] Checking bincode v1.0.0 [INFO] [stderr] Checking rusty-chain v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/factory.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | prev_hash: prev_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prev_hash` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/factory.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | prev_hash: prev_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prev_hash` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/block/hash.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | count = count - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/block/hash.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | count = count - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.67s [INFO] running `"docker" "inspect" "f6ddf8b140080263dc5cb945078888271e967243efaa312f6e87b8096bd34ddb"` [INFO] running `"docker" "rm" "-f" "f6ddf8b140080263dc5cb945078888271e967243efaa312f6e87b8096bd34ddb"` [INFO] [stdout] f6ddf8b140080263dc5cb945078888271e967243efaa312f6e87b8096bd34ddb