[INFO] updating cached repository domsj/rust-sd [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/domsj/rust-sd [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/domsj/rust-sd" "work/ex/clippy-test-run/sources/stable/gh/domsj/rust-sd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/domsj/rust-sd'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/domsj/rust-sd" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/domsj/rust-sd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/domsj/rust-sd'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 756a9ebeb6ab0ce986538fe45cc345d8383220ac [INFO] sha for GitHub repo domsj/rust-sd: 756a9ebeb6ab0ce986538fe45cc345d8383220ac [INFO] validating manifest of domsj/rust-sd on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of domsj/rust-sd on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing domsj/rust-sd [INFO] finished frobbing domsj/rust-sd [INFO] frobbed toml for domsj/rust-sd written to work/ex/clippy-test-run/sources/stable/gh/domsj/rust-sd/Cargo.toml [INFO] started frobbing domsj/rust-sd [INFO] finished frobbing domsj/rust-sd [INFO] frobbed toml for domsj/rust-sd written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/domsj/rust-sd/Cargo.toml [INFO] crate domsj/rust-sd has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting domsj/rust-sd against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/domsj/rust-sd:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b60656277cfe52758da584ead9239f36b0f5b6e77d56e669b66a404e0a364277 [INFO] running `"docker" "start" "-a" "b60656277cfe52758da584ead9239f36b0f5b6e77d56e669b66a404e0a364277"` [INFO] [stderr] Checking iovec v0.1.1 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Checking serde_json v1.0.7 [INFO] [stderr] Checking futures-cpupool v0.1.7 [INFO] [stderr] Checking bytes v0.4.5 [INFO] [stderr] Checking mio v0.6.11 [INFO] [stderr] Checking tokio-io v0.1.4 [INFO] [stderr] Checking tokio-core v0.1.10 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking rust_sd v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | thread_queues: thread_queues, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `thread_queues` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | thread_queues: thread_queues, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `thread_queues` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:143:70 [INFO] [stderr] | [INFO] [stderr] 143 | fn start_thread(queue: futures::sync::mpsc::Receiver) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:194:90 [INFO] [stderr] | [INFO] [stderr] 194 | pub extern "C" fn handover_fd(service: PartialReadService, fd: std::os::unix::io::RawFd) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tcp_stream` [INFO] [stderr] --> src/main.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | let tcp_stream = [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_tcp_stream` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `MessageCodec` [INFO] [stderr] --> src/main.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | struct MessageCodec; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:86:20 [INFO] [stderr] | [INFO] [stderr] 86 | res += ((b & 0x7f) as u64) << shift; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(b & 0x7f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:90:15 [INFO] [stderr] | [INFO] [stderr] 90 | res + (b << shift) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(b << shift)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `into_buf` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:126:38 [INFO] [stderr] | [INFO] [stderr] 126 | let request_id = (&mut buf[..]).into_buf().get_u64::(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `into_buf` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:131:38 [INFO] [stderr] | [INFO] [stderr] 131 | let request_id = (&mut buf[..]).into_buf().get_u64::(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:143:70 [INFO] [stderr] | [INFO] [stderr] 143 | fn start_thread(queue: futures::sync::mpsc::Receiver) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:194:90 [INFO] [stderr] | [INFO] [stderr] 194 | pub extern "C" fn handover_fd(service: PartialReadService, fd: std::os::unix::io::RawFd) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tcp_stream` [INFO] [stderr] --> src/main.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | let tcp_stream = [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_tcp_stream` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `MessageCodec` [INFO] [stderr] --> src/main.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | struct MessageCodec; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:86:20 [INFO] [stderr] | [INFO] [stderr] 86 | res += ((b & 0x7f) as u64) << shift; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(b & 0x7f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:90:15 [INFO] [stderr] | [INFO] [stderr] 90 | res + (b << shift) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(b << shift)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `into_buf` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:126:38 [INFO] [stderr] | [INFO] [stderr] 126 | let request_id = (&mut buf[..]).into_buf().get_u64::(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `into_buf` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:131:38 [INFO] [stderr] | [INFO] [stderr] 131 | let request_id = (&mut buf[..]).into_buf().get_u64::(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.71s [INFO] running `"docker" "inspect" "b60656277cfe52758da584ead9239f36b0f5b6e77d56e669b66a404e0a364277"` [INFO] running `"docker" "rm" "-f" "b60656277cfe52758da584ead9239f36b0f5b6e77d56e669b66a404e0a364277"` [INFO] [stdout] b60656277cfe52758da584ead9239f36b0f5b6e77d56e669b66a404e0a364277