[INFO] updating cached repository domoritz/line-density-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/domoritz/line-density-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/domoritz/line-density-rust" "work/ex/clippy-test-run/sources/stable/gh/domoritz/line-density-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/domoritz/line-density-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/domoritz/line-density-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/domoritz/line-density-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/domoritz/line-density-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b55066007f6925c6e0fd672048815ed3d6a58468 [INFO] sha for GitHub repo domoritz/line-density-rust: b55066007f6925c6e0fd672048815ed3d6a58468 [INFO] validating manifest of domoritz/line-density-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of domoritz/line-density-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing domoritz/line-density-rust [INFO] finished frobbing domoritz/line-density-rust [INFO] frobbed toml for domoritz/line-density-rust written to work/ex/clippy-test-run/sources/stable/gh/domoritz/line-density-rust/Cargo.toml [INFO] started frobbing domoritz/line-density-rust [INFO] finished frobbing domoritz/line-density-rust [INFO] frobbed toml for domoritz/line-density-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/domoritz/line-density-rust/Cargo.toml [INFO] crate domoritz/line-density-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting domoritz/line-density-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/domoritz/line-density-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6c6efba750f0f2a3d1adf0478a73d7694286bfdedf48ba75af53b34e4bb7219d [INFO] running `"docker" "start" "-a" "6c6efba750f0f2a3d1adf0478a73d7694286bfdedf48ba75af53b34e4bb7219d"` [INFO] [stderr] Compiling typenum v1.9.0 [INFO] [stderr] Checking num-complex v0.1.42 [INFO] [stderr] Checking num-bigint v0.1.43 [INFO] [stderr] Checking ordered-float v0.5.0 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Compiling palette v0.3.0 [INFO] [stderr] Checking rusttype v0.4.1 [INFO] [stderr] Checking quickcheck v0.6.1 [INFO] [stderr] Checking alga v0.5.2 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking generic-array v0.8.3 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking nalgebra v0.13.1 [INFO] [stderr] Checking imageproc v0.14.0 [INFO] [stderr] Checking line-density v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | y [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | let y = heightf/4.0 * (xf/20.0).sin() + heightf/2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | y [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | let y = heightf/4.0 * (xf/20.0).sin() + heightf/2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:17:23 [INFO] [stderr] | [INFO] [stderr] 17 | fn run_series(series: &Vec, width: u32, height: u32) -> Image { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / let mut iterations = 100; [INFO] [stderr] 66 | | [INFO] [stderr] 67 | | if args.len() == 2 { [INFO] [stderr] 68 | | iterations = match args[1].parse() { [INFO] [stderr] ... | [INFO] [stderr] 76 | | }; [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 65 | let iterations = if args.len() == 2 { match args[1].parse() { [INFO] [stderr] 66 | Ok(n) => { [INFO] [stderr] 67 | n [INFO] [stderr] 68 | }, [INFO] [stderr] 69 | Err(_) => { [INFO] [stderr] 70 | println!("error: argument not an integer"); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `/` [INFO] [stderr] --> src/main.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | 0./0., [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: constant division of 0.0 with 0.0 will always result in NaN [INFO] [stderr] --> src/main.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | 0./0., [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_divided_by_zero)] on by default [INFO] [stderr] = help: Consider using `std::f32::NAN` if you would like a constant representing NaN [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_divided_by_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:17:23 [INFO] [stderr] | [INFO] [stderr] 17 | fn run_series(series: &Vec, width: u32, height: u32) -> Image { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: Could not compile `line-density`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / let mut iterations = 100; [INFO] [stderr] 66 | | [INFO] [stderr] 67 | | if args.len() == 2 { [INFO] [stderr] 68 | | iterations = match args[1].parse() { [INFO] [stderr] ... | [INFO] [stderr] 76 | | }; [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 65 | let iterations = if args.len() == 2 { match args[1].parse() { [INFO] [stderr] 66 | Ok(n) => { [INFO] [stderr] 67 | n [INFO] [stderr] 68 | }, [INFO] [stderr] 69 | Err(_) => { [INFO] [stderr] 70 | println!("error: argument not an integer"); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `/` [INFO] [stderr] --> src/main.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | 0./0., [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: constant division of 0.0 with 0.0 will always result in NaN [INFO] [stderr] --> src/main.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | 0./0., [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_divided_by_zero)] on by default [INFO] [stderr] = help: Consider using `std::f32::NAN` if you would like a constant representing NaN [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_divided_by_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `line-density`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6c6efba750f0f2a3d1adf0478a73d7694286bfdedf48ba75af53b34e4bb7219d"` [INFO] running `"docker" "rm" "-f" "6c6efba750f0f2a3d1adf0478a73d7694286bfdedf48ba75af53b34e4bb7219d"` [INFO] [stdout] 6c6efba750f0f2a3d1adf0478a73d7694286bfdedf48ba75af53b34e4bb7219d