[INFO] updating cached repository dominikdosoudil/rpc-server-example [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dominikdosoudil/rpc-server-example [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dominikdosoudil/rpc-server-example" "work/ex/clippy-test-run/sources/stable/gh/dominikdosoudil/rpc-server-example"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dominikdosoudil/rpc-server-example'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dominikdosoudil/rpc-server-example" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dominikdosoudil/rpc-server-example"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dominikdosoudil/rpc-server-example'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8dd22e836e26ad88653553b399eae885929c9747 [INFO] sha for GitHub repo dominikdosoudil/rpc-server-example: 8dd22e836e26ad88653553b399eae885929c9747 [INFO] validating manifest of dominikdosoudil/rpc-server-example on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dominikdosoudil/rpc-server-example on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dominikdosoudil/rpc-server-example [INFO] finished frobbing dominikdosoudil/rpc-server-example [INFO] frobbed toml for dominikdosoudil/rpc-server-example written to work/ex/clippy-test-run/sources/stable/gh/dominikdosoudil/rpc-server-example/Cargo.toml [INFO] started frobbing dominikdosoudil/rpc-server-example [INFO] finished frobbing dominikdosoudil/rpc-server-example [INFO] frobbed toml for dominikdosoudil/rpc-server-example written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dominikdosoudil/rpc-server-example/Cargo.toml [INFO] crate dominikdosoudil/rpc-server-example has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dominikdosoudil/rpc-server-example against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dominikdosoudil/rpc-server-example:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 246dbc95ca97587acc17bf1c9d3458e9b423f9c68b9738a7712211027a14b331 [INFO] running `"docker" "start" "-a" "246dbc95ca97587acc17bf1c9d3458e9b423f9c68b9738a7712211027a14b331"` [INFO] [stderr] Checking log v0.4.0 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking tokio-io v0.1.4 [INFO] [stderr] Checking mio v0.6.11 [INFO] [stderr] Checking tokio-core v0.1.11 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking hyper v0.11.9 [INFO] [stderr] Checking hello_cargo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server/api/mod.rs:9:16 [INFO] [stderr] | [INFO] [stderr] 9 | Some(x) => return x(), [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `x()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server/api/mod.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | None => return "Internal error".to_string() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Internal error".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server/api/mod.rs:13:8 [INFO] [stderr] | [INFO] [stderr] 13 | _ => return "method not found".to_string() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"method not found".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server/api/mod.rs:18:2 [INFO] [stderr] | [INFO] [stderr] 18 | return "Hello!".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Hello!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server/mod.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | return Box::new(FutureOk( [INFO] [stderr] | _________^ [INFO] [stderr] 30 | | Response::new() [INFO] [stderr] 31 | | .with_header(ContentLength(response.len() as u64)) [INFO] [stderr] 32 | | .with_body(response) [INFO] [stderr] 33 | | )) [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 29 | Box::new(FutureOk( [INFO] [stderr] 30 | Response::new() [INFO] [stderr] 31 | .with_header(ContentLength(response.len() as u64)) [INFO] [stderr] 32 | .with_body(response) [INFO] [stderr] 33 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server/api/mod.rs:9:16 [INFO] [stderr] | [INFO] [stderr] 9 | Some(x) => return x(), [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `x()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server/api/mod.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | None => return "Internal error".to_string() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Internal error".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server/api/mod.rs:13:8 [INFO] [stderr] | [INFO] [stderr] 13 | _ => return "method not found".to_string() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"method not found".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server/api/mod.rs:18:2 [INFO] [stderr] | [INFO] [stderr] 18 | return "Hello!".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Hello!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server/mod.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | return Box::new(FutureOk( [INFO] [stderr] | _________^ [INFO] [stderr] 30 | | Response::new() [INFO] [stderr] 31 | | .with_header(ContentLength(response.len() as u64)) [INFO] [stderr] 32 | | .with_body(response) [INFO] [stderr] 33 | | )) [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 29 | Box::new(FutureOk( [INFO] [stderr] 30 | Response::new() [INFO] [stderr] 31 | .with_header(ContentLength(response.len() as u64)) [INFO] [stderr] 32 | .with_body(response) [INFO] [stderr] 33 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/server/api/mod.rs:6:2 [INFO] [stderr] | [INFO] [stderr] 6 | match methods.contains_key(request) { [INFO] [stderr] | _____^ [INFO] [stderr] 7 | | true => { [INFO] [stderr] 8 | | match methods.get(request) { [INFO] [stderr] 9 | | Some(x) => return x(), [INFO] [stderr] ... | [INFO] [stderr] 13 | | _ => return "method not found".to_string() [INFO] [stderr] 14 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 6 | if methods.contains_key(request) { [INFO] [stderr] 7 | match methods.get(request) { [INFO] [stderr] 8 | Some(x) => return x(), [INFO] [stderr] 9 | None => return "Internal error".to_string() [INFO] [stderr] 10 | } [INFO] [stderr] 11 | } else { return "method not found".to_string() }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/server/api/mod.rs:6:2 [INFO] [stderr] | [INFO] [stderr] 6 | match methods.contains_key(request) { [INFO] [stderr] | _____^ [INFO] [stderr] 7 | | true => { [INFO] [stderr] 8 | | match methods.get(request) { [INFO] [stderr] 9 | | Some(x) => return x(), [INFO] [stderr] ... | [INFO] [stderr] 13 | | _ => return "method not found".to_string() [INFO] [stderr] 14 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 6 | if methods.contains_key(request) { [INFO] [stderr] 7 | match methods.get(request) { [INFO] [stderr] 8 | Some(x) => return x(), [INFO] [stderr] 9 | None => return "Internal error".to_string() [INFO] [stderr] 10 | } [INFO] [stderr] 11 | } else { return "method not found".to_string() }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.30s [INFO] running `"docker" "inspect" "246dbc95ca97587acc17bf1c9d3458e9b423f9c68b9738a7712211027a14b331"` [INFO] running `"docker" "rm" "-f" "246dbc95ca97587acc17bf1c9d3458e9b423f9c68b9738a7712211027a14b331"` [INFO] [stdout] 246dbc95ca97587acc17bf1c9d3458e9b423f9c68b9738a7712211027a14b331