[INFO] updating cached repository dogHere/rust-bst
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/dogHere/rust-bst
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/dogHere/rust-bst" "work/ex/clippy-test-run/sources/stable/gh/dogHere/rust-bst"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dogHere/rust-bst'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/dogHere/rust-bst" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dogHere/rust-bst"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dogHere/rust-bst'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 39ad6b0b42bd5f4095800d2a1eb99f8492716f88
[INFO] sha for GitHub repo dogHere/rust-bst: 39ad6b0b42bd5f4095800d2a1eb99f8492716f88
[INFO] validating manifest of dogHere/rust-bst on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dogHere/rust-bst on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dogHere/rust-bst
[INFO] finished frobbing dogHere/rust-bst
[INFO] frobbed toml for dogHere/rust-bst written to work/ex/clippy-test-run/sources/stable/gh/dogHere/rust-bst/Cargo.toml
[INFO] started frobbing dogHere/rust-bst
[INFO] finished frobbing dogHere/rust-bst
[INFO] frobbed toml for dogHere/rust-bst written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dogHere/rust-bst/Cargo.toml
[INFO] crate dogHere/rust-bst has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting dogHere/rust-bst against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dogHere/rust-bst:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 70b41d2c8bca1011a1e04f9067bfc3694dab6d3d2ed2a739a9bd650c6c0eb99e
[INFO] running `"docker" "start" "-a" "70b41d2c8bca1011a1e04f9067bfc3694dab6d3d2ed2a739a9bd650c6c0eb99e"`
[INFO] [stderr]     Checking bst_rs v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/tree.rs:87:24
[INFO] [stderr]     |
[INFO] [stderr] 87  |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 88  | |                     if value > &r.value() {
[INFO] [stderr] 89  | |                         Node::delete(&mut r.right, value);
[INFO] [stderr] 90  | |                     } else if value < &r.value() {
[INFO] [stderr] ...   |
[INFO] [stderr] 106 | |                     }
[INFO] [stderr] 107 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 87  |                 } else if value > &r.value() {
[INFO] [stderr] 88  |     Node::delete(&mut r.right, value);
[INFO] [stderr] 89  | } else if value < &r.value() {
[INFO] [stderr] 90  |     Node::delete(&mut r.left, value);
[INFO] [stderr] 91  | } else {
[INFO] [stderr] 92  |     if r.right.is_none() {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/tree.rs:92:28
[INFO] [stderr]     |
[INFO] [stderr] 92  |                       } else {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 93  | |                         if r.right.is_none() {
[INFO] [stderr] 94  | |                             let t = r.left.take();
[INFO] [stderr] 95  | |                             swap(&mut r.value, &mut t.unwrap().value);
[INFO] [stderr] ...   |
[INFO] [stderr] 105 | |                         }
[INFO] [stderr] 106 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 92  |                     } else if r.right.is_none() {
[INFO] [stderr] 93  |     let t = r.left.take();
[INFO] [stderr] 94  |     swap(&mut r.value, &mut t.unwrap().value);
[INFO] [stderr] 95  |     swap(&mut None, &mut r.left);
[INFO] [stderr] 96  | } else if r.left.is_none() {
[INFO] [stderr] 97  |     let t = r.right.take();
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/tree.rs:87:24
[INFO] [stderr]     |
[INFO] [stderr] 87  |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 88  | |                     if value > &r.value() {
[INFO] [stderr] 89  | |                         Node::delete(&mut r.right, value);
[INFO] [stderr] 90  | |                     } else if value < &r.value() {
[INFO] [stderr] ...   |
[INFO] [stderr] 106 | |                     }
[INFO] [stderr] 107 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 87  |                 } else if value > &r.value() {
[INFO] [stderr] 88  |     Node::delete(&mut r.right, value);
[INFO] [stderr] 89  | } else if value < &r.value() {
[INFO] [stderr] 90  |     Node::delete(&mut r.left, value);
[INFO] [stderr] 91  | } else {
[INFO] [stderr] 92  |     if r.right.is_none() {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/tree.rs:92:28
[INFO] [stderr]     |
[INFO] [stderr] 92  |                       } else {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 93  | |                         if r.right.is_none() {
[INFO] [stderr] 94  | |                             let t = r.left.take();
[INFO] [stderr] 95  | |                             swap(&mut r.value, &mut t.unwrap().value);
[INFO] [stderr] ...   |
[INFO] [stderr] 105 | |                         }
[INFO] [stderr] 106 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 92  |                     } else if r.right.is_none() {
[INFO] [stderr] 93  |     let t = r.left.take();
[INFO] [stderr] 94  |     swap(&mut r.value, &mut t.unwrap().value);
[INFO] [stderr] 95  |     swap(&mut None, &mut r.left);
[INFO] [stderr] 96  | } else if r.left.is_none() {
[INFO] [stderr] 97  |     let t = r.right.take();
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/tree.rs:85:20
[INFO] [stderr]    |
[INFO] [stderr] 85 |                 if !r.left.is_some() && !r.right.is_some() {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `r.left.is_none() && r.right.is_none()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `tree::Tree<T>`
[INFO] [stderr]    --> src/tree.rs:136:5
[INFO] [stderr]     |
[INFO] [stderr] 136 | /     pub fn new() -> Tree<T> {
[INFO] [stderr] 137 | |         Tree {
[INFO] [stderr] 138 | |             root: None
[INFO] [stderr] 139 | |         }
[INFO] [stderr] 140 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 117 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/tree.rs:85:20
[INFO] [stderr]    |
[INFO] [stderr] 85 |                 if !r.left.is_some() && !r.right.is_some() {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `r.left.is_none() && r.right.is_none()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `tree::Tree<T>`
[INFO] [stderr]    --> src/tree.rs:136:5
[INFO] [stderr]     |
[INFO] [stderr] 136 | /     pub fn new() -> Tree<T> {
[INFO] [stderr] 137 | |         Tree {
[INFO] [stderr] 138 | |             root: None
[INFO] [stderr] 139 | |         }
[INFO] [stderr] 140 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 117 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.06s
[INFO] running `"docker" "inspect" "70b41d2c8bca1011a1e04f9067bfc3694dab6d3d2ed2a739a9bd650c6c0eb99e"`
[INFO] running `"docker" "rm" "-f" "70b41d2c8bca1011a1e04f9067bfc3694dab6d3d2ed2a739a9bd650c6c0eb99e"`
[INFO] [stdout] 70b41d2c8bca1011a1e04f9067bfc3694dab6d3d2ed2a739a9bd650c6c0eb99e