[INFO] updating cached repository dns2utf8/windd [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dns2utf8/windd [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dns2utf8/windd" "work/ex/clippy-test-run/sources/stable/gh/dns2utf8/windd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dns2utf8/windd'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dns2utf8/windd" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dns2utf8/windd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dns2utf8/windd'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1426f922caa9a9b0e72abb5609bd58d9efe242aa [INFO] sha for GitHub repo dns2utf8/windd: 1426f922caa9a9b0e72abb5609bd58d9efe242aa [INFO] validating manifest of dns2utf8/windd on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dns2utf8/windd on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dns2utf8/windd [INFO] finished frobbing dns2utf8/windd [INFO] frobbed toml for dns2utf8/windd written to work/ex/clippy-test-run/sources/stable/gh/dns2utf8/windd/Cargo.toml [INFO] started frobbing dns2utf8/windd [INFO] finished frobbing dns2utf8/windd [INFO] frobbed toml for dns2utf8/windd written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dns2utf8/windd/Cargo.toml [INFO] crate dns2utf8/windd has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting dns2utf8/windd against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dns2utf8/windd:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2ee5816c1a39b6b06a2f94ec82cfe9ccd405f00a55183bb38bd0da7dafa74587 [INFO] running `"docker" "start" "-a" "2ee5816c1a39b6b06a2f94ec82cfe9ccd405f00a55183bb38bd0da7dafa74587"` [INFO] [stderr] Checking ctrlc v2.0.1 [INFO] [stderr] Checking windd v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:17:38 [INFO] [stderr] | [INFO] [stderr] 17 | let file_name = arguments().nth(1).unwrap_or("empty.bin".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "empty.bin".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:36:28 [INFO] [stderr] | [INFO] [stderr] 36 | fn create_empty_file(name: &String) -> std::io::Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:17:38 [INFO] [stderr] | [INFO] [stderr] 17 | let file_name = arguments().nth(1).unwrap_or("empty.bin".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "empty.bin".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:36:28 [INFO] [stderr] | [INFO] [stderr] 36 | fn create_empty_file(name: &String) -> std::io::Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.99s [INFO] running `"docker" "inspect" "2ee5816c1a39b6b06a2f94ec82cfe9ccd405f00a55183bb38bd0da7dafa74587"` [INFO] running `"docker" "rm" "-f" "2ee5816c1a39b6b06a2f94ec82cfe9ccd405f00a55183bb38bd0da7dafa74587"` [INFO] [stdout] 2ee5816c1a39b6b06a2f94ec82cfe9ccd405f00a55183bb38bd0da7dafa74587