[INFO] updating cached repository dmorigin/simpermut-rc
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/dmorigin/simpermut-rc
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/dmorigin/simpermut-rc" "work/ex/clippy-test-run/sources/stable/gh/dmorigin/simpermut-rc"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dmorigin/simpermut-rc'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/dmorigin/simpermut-rc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmorigin/simpermut-rc"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmorigin/simpermut-rc'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 53b1ad874083dd64bacb5451c43482f30decefd0
[INFO] sha for GitHub repo dmorigin/simpermut-rc: 53b1ad874083dd64bacb5451c43482f30decefd0
[INFO] validating manifest of dmorigin/simpermut-rc on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dmorigin/simpermut-rc on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dmorigin/simpermut-rc
[INFO] finished frobbing dmorigin/simpermut-rc
[INFO] frobbed toml for dmorigin/simpermut-rc written to work/ex/clippy-test-run/sources/stable/gh/dmorigin/simpermut-rc/Cargo.toml
[INFO] started frobbing dmorigin/simpermut-rc
[INFO] finished frobbing dmorigin/simpermut-rc
[INFO] frobbed toml for dmorigin/simpermut-rc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmorigin/simpermut-rc/Cargo.toml
[INFO] crate dmorigin/simpermut-rc has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting dmorigin/simpermut-rc against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dmorigin/simpermut-rc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7afc334f67752f22f94452f677bb3dd00e4f0271b7c55a7a5264588a0fa1e5e3
[INFO] running `"docker" "start" "-a" "7afc334f67752f22f94452f677bb3dd00e4f0271b7c55a7a5264588a0fa1e5e3"`
[INFO] [stderr]     Checking parking_lot v0.6.3
[INFO] [stderr]    Compiling syn v0.14.8
[INFO] [stderr]     Checking console v0.6.1
[INFO] [stderr]     Checking indicatif v0.9.0
[INFO] [stderr]    Compiling serde_derive v1.0.71
[INFO] [stderr]     Checking sim_permut v0.3.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/simcraft/slot.rs:73:13
[INFO] [stderr]    |
[INFO] [stderr] 73 |             slot: slot,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `slot`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/simcraft/slot.rs:73:13
[INFO] [stderr]    |
[INFO] [stderr] 73 |             slot: slot,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `slot`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/template.rs:70:9
[INFO] [stderr]    |
[INFO] [stderr] 70 |         return false;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/template.rs:70:9
[INFO] [stderr]    |
[INFO] [stderr] 70 |         return false;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/simcraft/mod.rs:186:15
[INFO] [stderr]     |
[INFO] [stderr] 186 |         while permutation.len() > 0 {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!permutation.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/simcraft/mod.rs:341:16
[INFO] [stderr]     |
[INFO] [stderr] 341 |         stack: &Vec<Item>,
[INFO] [stderr]     |                ^^^^^^^^^^ help: change this to: `&[Item]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/simcraft/mod.rs:597:43
[INFO] [stderr]     |
[INFO] [stderr] 597 |     fn has_multiple_of_them(&self, stack: &Vec<Item>) -> bool {
[INFO] [stderr]     |                                           ^^^^^^^^^^ help: change this to: `&[Item]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/main.rs:88:8
[INFO] [stderr]    |
[INFO] [stderr] 88 |     if accept == false {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!accept`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/simcraft/mod.rs:186:15
[INFO] [stderr]     |
[INFO] [stderr] 186 |         while permutation.len() > 0 {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!permutation.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/simcraft/mod.rs:341:16
[INFO] [stderr]     |
[INFO] [stderr] 341 |         stack: &Vec<Item>,
[INFO] [stderr]     |                ^^^^^^^^^^ help: change this to: `&[Item]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/simcraft/mod.rs:597:43
[INFO] [stderr]     |
[INFO] [stderr] 597 |     fn has_multiple_of_them(&self, stack: &Vec<Item>) -> bool {
[INFO] [stderr]     |                                           ^^^^^^^^^^ help: change this to: `&[Item]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/main.rs:88:8
[INFO] [stderr]    |
[INFO] [stderr] 88 |     if accept == false {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!accept`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 23.52s
[INFO] running `"docker" "inspect" "7afc334f67752f22f94452f677bb3dd00e4f0271b7c55a7a5264588a0fa1e5e3"`
[INFO] running `"docker" "rm" "-f" "7afc334f67752f22f94452f677bb3dd00e4f0271b7c55a7a5264588a0fa1e5e3"`
[INFO] [stdout] 7afc334f67752f22f94452f677bb3dd00e4f0271b7c55a7a5264588a0fa1e5e3