[INFO] updating cached repository dmitryvm/websocket-server [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dmitryvm/websocket-server [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dmitryvm/websocket-server" "work/ex/clippy-test-run/sources/stable/gh/dmitryvm/websocket-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dmitryvm/websocket-server'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dmitryvm/websocket-server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmitryvm/websocket-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmitryvm/websocket-server'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5fda1e9e9a03494a4e2296c3462d51a4481118b9 [INFO] sha for GitHub repo dmitryvm/websocket-server: 5fda1e9e9a03494a4e2296c3462d51a4481118b9 [INFO] validating manifest of dmitryvm/websocket-server on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dmitryvm/websocket-server on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dmitryvm/websocket-server [INFO] finished frobbing dmitryvm/websocket-server [INFO] frobbed toml for dmitryvm/websocket-server written to work/ex/clippy-test-run/sources/stable/gh/dmitryvm/websocket-server/Cargo.toml [INFO] started frobbing dmitryvm/websocket-server [INFO] finished frobbing dmitryvm/websocket-server [INFO] frobbed toml for dmitryvm/websocket-server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmitryvm/websocket-server/Cargo.toml [INFO] crate dmitryvm/websocket-server has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dmitryvm/websocket-server against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dmitryvm/websocket-server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 098d63527db1d092a8dead78baa1d568f9fef5752a8421b3c6e14a1e82d8b67f [INFO] running `"docker" "start" "-a" "098d63527db1d092a8dead78baa1d568f9fef5752a8421b3c6e14a1e82d8b67f"` [INFO] [stderr] Checking bytes v0.2.11 [INFO] [stderr] Compiling http-muncher v0.2.5 [INFO] [stderr] Checking winapi v0.1.23 [INFO] [stderr] Checking nix v0.3.10 [INFO] [stderr] Checking sha1 v0.1.1 [INFO] [stderr] Checking mio v0.4.4 [INFO] [stderr] Checking mudgate v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | opcode: opcode [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | payload: payload, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `payload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | opcode: opcode [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | payload: payload, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `payload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::error::Error` [INFO] [stderr] --> src/frame.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::error::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | / return match payload_len { [INFO] [stderr] 184 | | PAYLOAD_LEN_U64 => input.read_u64::().map(|v| v as usize).map_err(|e| io::Error::from(e)), [INFO] [stderr] 185 | | PAYLOAD_LEN_U16 => input.read_u16::().map(|v| v as usize).map_err(|e| io::Error::from(e)), [INFO] [stderr] 186 | | _ => Ok(payload_len as usize) // payload_len < 126 [INFO] [stderr] 187 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 183 | match payload_len { [INFO] [stderr] 184 | PAYLOAD_LEN_U64 => input.read_u64::().map(|v| v as usize).map_err(|e| io::Error::from(e)), [INFO] [stderr] 185 | PAYLOAD_LEN_U16 => input.read_u16::().map(|v| v as usize).map_err(|e| io::Error::from(e)), [INFO] [stderr] 186 | _ => Ok(payload_len as usize) // payload_len < 126 [INFO] [stderr] 187 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::error::Error` [INFO] [stderr] --> src/frame.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::error::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | / return match payload_len { [INFO] [stderr] 184 | | PAYLOAD_LEN_U64 => input.read_u64::().map(|v| v as usize).map_err(|e| io::Error::from(e)), [INFO] [stderr] 185 | | PAYLOAD_LEN_U16 => input.read_u16::().map(|v| v as usize).map_err(|e| io::Error::from(e)), [INFO] [stderr] 186 | | _ => Ok(payload_len as usize) // payload_len < 126 [INFO] [stderr] 187 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 183 | match payload_len { [INFO] [stderr] 184 | PAYLOAD_LEN_U64 => input.read_u64::().map(|v| v as usize).map_err(|e| io::Error::from(e)), [INFO] [stderr] 185 | PAYLOAD_LEN_U16 => input.read_u16::().map(|v| v as usize).map_err(|e| io::Error::from(e)), [INFO] [stderr] 186 | _ => Ok(payload_len as usize) // payload_len < 126 [INFO] [stderr] 187 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:209:17 [INFO] [stderr] | [INFO] [stderr] 209 | let mut client = self.clients.get_mut(&token).unwrap(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_opcode` [INFO] [stderr] --> src/frame.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | pub fn get_opcode(&self) -> OpCode { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/frame.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | try!(output.write(&self.payload)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/frame.rs:111:10 [INFO] [stderr] | [INFO] [stderr] 111 | ((b1 as u16) << 8) | (b2 as u16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(b1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/frame.rs:111:30 [INFO] [stderr] | [INFO] [stderr] 111 | ((b1 as u16) << 8) | (b2 as u16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(b2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/frame.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | self.header.opcode.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.header.opcode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/frame.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | *c = *c ^ mask[idx % 4]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*c ^= mask[idx % 4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/frame.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | try!(input.read(&mut buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/frame.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 176 | let mut payload: Vec = Vec::with_capacity(payload_len); [INFO] [stderr] | ------------------------------- help: consider replace allocation with: `vec![0; payload_len]` [INFO] [stderr] 177 | payload.extend(iter::repeat(0).take(payload_len)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/frame.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | try!(input.read(&mut payload)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/frame.rs:184:90 [INFO] [stderr] | [INFO] [stderr] 184 | PAYLOAD_LEN_U64 => input.read_u64::().map(|v| v as usize).map_err(|e| io::Error::from(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `io::Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/frame.rs:184:94 [INFO] [stderr] | [INFO] [stderr] 184 | PAYLOAD_LEN_U64 => input.read_u64::().map(|v| v as usize).map_err(|e| io::Error::from(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `io::Error::from()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/frame.rs:185:90 [INFO] [stderr] | [INFO] [stderr] 185 | PAYLOAD_LEN_U16 => input.read_u16::().map(|v| v as usize).map_err(|e| io::Error::from(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `io::Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/frame.rs:185:94 [INFO] [stderr] | [INFO] [stderr] 185 | PAYLOAD_LEN_U16 => input.read_u16::().map(|v| v as usize).map_err(|e| io::Error::from(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `io::Error::from()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | fn gen_key(key: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:24:14 [INFO] [stderr] | [INFO] [stderr] 24 | m.update("258EAFA5-E914-47DA-95CA-C5AB0DC85B11".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"258EAFA5-E914-47DA-95CA-C5AB0DC85B11"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | self.socket.write(response.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:234:5 [INFO] [stderr] | [INFO] [stderr] 234 | event_loop.run(&mut server); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `mudgate`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:209:17 [INFO] [stderr] | [INFO] [stderr] 209 | let mut client = self.clients.get_mut(&token).unwrap(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_opcode` [INFO] [stderr] --> src/frame.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | pub fn get_opcode(&self) -> OpCode { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/frame.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | try!(output.write(&self.payload)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/frame.rs:111:10 [INFO] [stderr] | [INFO] [stderr] 111 | ((b1 as u16) << 8) | (b2 as u16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(b1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/frame.rs:111:30 [INFO] [stderr] | [INFO] [stderr] 111 | ((b1 as u16) << 8) | (b2 as u16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(b2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/frame.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | self.header.opcode.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.header.opcode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/frame.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | *c = *c ^ mask[idx % 4]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*c ^= mask[idx % 4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/frame.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | try!(input.read(&mut buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/frame.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 176 | let mut payload: Vec = Vec::with_capacity(payload_len); [INFO] [stderr] | ------------------------------- help: consider replace allocation with: `vec![0; payload_len]` [INFO] [stderr] 177 | payload.extend(iter::repeat(0).take(payload_len)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/frame.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | try!(input.read(&mut payload)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/frame.rs:184:90 [INFO] [stderr] | [INFO] [stderr] 184 | PAYLOAD_LEN_U64 => input.read_u64::().map(|v| v as usize).map_err(|e| io::Error::from(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `io::Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/frame.rs:184:94 [INFO] [stderr] | [INFO] [stderr] 184 | PAYLOAD_LEN_U64 => input.read_u64::().map(|v| v as usize).map_err(|e| io::Error::from(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `io::Error::from()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/frame.rs:185:90 [INFO] [stderr] | [INFO] [stderr] 185 | PAYLOAD_LEN_U16 => input.read_u16::().map(|v| v as usize).map_err(|e| io::Error::from(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `io::Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/frame.rs:185:94 [INFO] [stderr] | [INFO] [stderr] 185 | PAYLOAD_LEN_U16 => input.read_u16::().map(|v| v as usize).map_err(|e| io::Error::from(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `io::Error::from()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | fn gen_key(key: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:24:14 [INFO] [stderr] | [INFO] [stderr] 24 | m.update("258EAFA5-E914-47DA-95CA-C5AB0DC85B11".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"258EAFA5-E914-47DA-95CA-C5AB0DC85B11"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | self.socket.write(response.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:234:5 [INFO] [stderr] | [INFO] [stderr] 234 | event_loop.run(&mut server); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `mudgate`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "098d63527db1d092a8dead78baa1d568f9fef5752a8421b3c6e14a1e82d8b67f"` [INFO] running `"docker" "rm" "-f" "098d63527db1d092a8dead78baa1d568f9fef5752a8421b3c6e14a1e82d8b67f"` [INFO] [stdout] 098d63527db1d092a8dead78baa1d568f9fef5752a8421b3c6e14a1e82d8b67f