[INFO] updating cached repository dmitryvk/rs-credentials-manager
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/dmitryvk/rs-credentials-manager
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/dmitryvk/rs-credentials-manager" "work/ex/clippy-test-run/sources/stable/gh/dmitryvk/rs-credentials-manager"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dmitryvk/rs-credentials-manager'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/dmitryvk/rs-credentials-manager" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmitryvk/rs-credentials-manager"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmitryvk/rs-credentials-manager'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 524ad0c135ac1fc75d08b3f1ff3b236335d4c6da
[INFO] sha for GitHub repo dmitryvk/rs-credentials-manager: 524ad0c135ac1fc75d08b3f1ff3b236335d4c6da
[INFO] validating manifest of dmitryvk/rs-credentials-manager on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dmitryvk/rs-credentials-manager on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dmitryvk/rs-credentials-manager
[INFO] finished frobbing dmitryvk/rs-credentials-manager
[INFO] frobbed toml for dmitryvk/rs-credentials-manager written to work/ex/clippy-test-run/sources/stable/gh/dmitryvk/rs-credentials-manager/Cargo.toml
[INFO] started frobbing dmitryvk/rs-credentials-manager
[INFO] finished frobbing dmitryvk/rs-credentials-manager
[INFO] frobbed toml for dmitryvk/rs-credentials-manager written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmitryvk/rs-credentials-manager/Cargo.toml
[INFO] crate dmitryvk/rs-credentials-manager has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting dmitryvk/rs-credentials-manager against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dmitryvk/rs-credentials-manager:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d33321d3e66cdb11c1be14b4d078678d5db3c017c403246284e70af430c83f20
[INFO] running `"docker" "start" "-a" "d33321d3e66cdb11c1be14b4d078678d5db3c017c403246284e70af430c83f20"`
[INFO] [stderr]    Compiling rustdoc-stripper v0.1.5
[INFO] [stderr]    Compiling num-iter v0.1.37
[INFO] [stderr]    Compiling glib-sys v0.3.4
[INFO] [stderr]    Compiling gobject-sys v0.3.4
[INFO] [stderr]    Compiling gio-sys v0.3.4
[INFO] [stderr]    Compiling gdk-pixbuf-sys v0.3.4
[INFO] [stderr]    Compiling pango-sys v0.3.4
[INFO] [stderr]    Compiling cairo-sys-rs v0.3.4
[INFO] [stderr]    Compiling gdk-sys v0.3.4
[INFO] [stderr]    Compiling atk-sys v0.3.4
[INFO] [stderr]    Compiling gtk-sys v0.3.4
[INFO] [stderr]    Compiling linenoise-rust v0.1.15
[INFO] [stderr]    Compiling gtk-rs-lgpl-docs v0.1.6
[INFO] [stderr]     Checking num v0.1.42
[INFO] [stderr]     Checking chrono v0.2.25
[INFO] [stderr]    Compiling gio v0.1.3
[INFO] [stderr]    Compiling cairo-rs v0.1.3
[INFO] [stderr]    Compiling gdk-pixbuf v0.1.3
[INFO] [stderr]    Compiling gdk v0.5.3
[INFO] [stderr]    Compiling gtk v0.1.3
[INFO] [stderr]     Checking glib v0.1.3
[INFO] [stderr]     Checking pango v0.1.3
[INFO] [stderr]     Checking cred-man v1.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/encrypted_file.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 |         salt: salt,
[INFO] [stderr]    |         ^^^^^^^^^^ help: replace it with: `salt`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/encrypted_file.rs:50:9
[INFO] [stderr]    |
[INFO] [stderr] 50 |         nonce: nonce,
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `nonce`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/encrypted_file.rs:51:9
[INFO] [stderr]    |
[INFO] [stderr] 51 |         tag: tag,
[INFO] [stderr]    |         ^^^^^^^^ help: replace it with: `tag`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/encrypted_file.rs:52:9
[INFO] [stderr]    |
[INFO] [stderr] 52 |         ciphertext: ciphertext,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ciphertext`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/encrypted_file.rs:114:9
[INFO] [stderr]     |
[INFO] [stderr] 114 |         salt: salt,
[INFO] [stderr]     |         ^^^^^^^^^^ help: replace it with: `salt`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/encrypted_file.rs:115:9
[INFO] [stderr]     |
[INFO] [stderr] 115 |         nonce: nonce,
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `nonce`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/encrypted_file.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 |         salt: salt,
[INFO] [stderr]    |         ^^^^^^^^^^ help: replace it with: `salt`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/encrypted_file.rs:50:9
[INFO] [stderr]    |
[INFO] [stderr] 50 |         nonce: nonce,
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `nonce`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/encrypted_file.rs:51:9
[INFO] [stderr]    |
[INFO] [stderr] 51 |         tag: tag,
[INFO] [stderr]    |         ^^^^^^^^ help: replace it with: `tag`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/encrypted_file.rs:52:9
[INFO] [stderr]    |
[INFO] [stderr] 52 |         ciphertext: ciphertext,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ciphertext`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/encrypted_file.rs:114:9
[INFO] [stderr]     |
[INFO] [stderr] 114 |         salt: salt,
[INFO] [stderr]     |         ^^^^^^^^^^ help: replace it with: `salt`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/encrypted_file.rs:115:9
[INFO] [stderr]     |
[INFO] [stderr] 115 |         nonce: nonce,
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `nonce`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/encrypted_file.rs:116:9
[INFO] [stderr]     |
[INFO] [stderr] 116 |         tag: tag,
[INFO] [stderr]     |         ^^^^^^^^ help: replace it with: `tag`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/encrypted_file.rs:117:9
[INFO] [stderr]     |
[INFO] [stderr] 117 |         ciphertext: ciphertext,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ciphertext`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             password: password,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `password`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 |             location: location,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `location`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/encrypted_file.rs:116:9
[INFO] [stderr]     |
[INFO] [stderr] 116 |         tag: tag,
[INFO] [stderr]     |         ^^^^^^^^ help: replace it with: `tag`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/encrypted_file.rs:117:9
[INFO] [stderr]     |
[INFO] [stderr] 117 |         ciphertext: ciphertext,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ciphertext`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             password: password,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `password`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 |             location: location,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `location`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/encrypted_file.rs:64:24
[INFO] [stderr]    |
[INFO] [stderr] 64 | const CRED_MAN_MAGIC: &'static [u8] = b"CREDMAN";
[INFO] [stderr]    |                       -^^^^^^^----- help: consider removing `'static`: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/lib.rs:45:25
[INFO] [stderr]    |
[INFO] [stderr] 45 | const DTO_TIME_FORMAT: &'static str = "%Y-%m-%dT%H:%M:%S";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/lib.rs:64:20
[INFO] [stderr]    |
[INFO] [stderr] 64 |             path = std::env::home_dir().unwrap();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/encrypted_file.rs:64:24
[INFO] [stderr]    |
[INFO] [stderr] 64 | const CRED_MAN_MAGIC: &'static [u8] = b"CREDMAN";
[INFO] [stderr]    |                       -^^^^^^^----- help: consider removing `'static`: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/lib.rs:45:25
[INFO] [stderr]    |
[INFO] [stderr] 45 | const DTO_TIME_FORMAT: &'static str = "%Y-%m-%dT%H:%M:%S";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/lib.rs:64:20
[INFO] [stderr]    |
[INFO] [stderr] 64 |             path = std::env::home_dir().unwrap();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/encrypted_file.rs:36:19
[INFO] [stderr]    |
[INFO] [stderr] 36 |     let mut rng = OsRng::new().ok().expect("Unable to open crypto RNG");
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/encrypted_file.rs:107:21
[INFO] [stderr]     |
[INFO] [stderr] 107 |     let ver: i32 = ((ver_bytes[0] as i32) << 24) | ((ver_bytes[1] as i32) << 16) | ((ver_bytes[2] as i32) << 8) | (ver_bytes[3] as i32);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ver_bytes[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/encrypted_file.rs:107:53
[INFO] [stderr]     |
[INFO] [stderr] 107 |     let ver: i32 = ((ver_bytes[0] as i32) << 24) | ((ver_bytes[1] as i32) << 16) | ((ver_bytes[2] as i32) << 8) | (ver_bytes[3] as i32);
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ver_bytes[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/encrypted_file.rs:107:85
[INFO] [stderr]     |
[INFO] [stderr] 107 |     let ver: i32 = ((ver_bytes[0] as i32) << 24) | ((ver_bytes[1] as i32) << 16) | ((ver_bytes[2] as i32) << 8) | (ver_bytes[3] as i32);
[INFO] [stderr]     |                                                                                     ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ver_bytes[2])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/encrypted_file.rs:107:115
[INFO] [stderr]     |
[INFO] [stderr] 107 |     let ver: i32 = ((ver_bytes[0] as i32) << 24) | ((ver_bytes[1] as i32) << 16) | ((ver_bytes[2] as i32) << 8) | (ver_bytes[3] as i32);
[INFO] [stderr]     |                                                                                                                   ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ver_bytes[3])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/lib.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 | /     match location {
[INFO] [stderr] 63 | |         &DbLocation::DotLocal => {
[INFO] [stderr] 64 | |             path = std::env::home_dir().unwrap();
[INFO] [stderr] 65 | |             path.push(".local");
[INFO] [stderr] ...  |
[INFO] [stderr] 71 | |         },
[INFO] [stderr] 72 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 62 |     match *location {
[INFO] [stderr] 63 |         DbLocation::DotLocal => {
[INFO] [stderr] 64 |             path = std::env::home_dir().unwrap();
[INFO] [stderr] 65 |             path.push(".local");
[INFO] [stderr] 66 |             path.push("share");
[INFO] [stderr] 67 |             path.push("cred-man");
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/encrypted_file.rs:36:19
[INFO] [stderr]    |
[INFO] [stderr] 36 |     let mut rng = OsRng::new().ok().expect("Unable to open crypto RNG");
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/encrypted_file.rs:107:21
[INFO] [stderr]     |
[INFO] [stderr] 107 |     let ver: i32 = ((ver_bytes[0] as i32) << 24) | ((ver_bytes[1] as i32) << 16) | ((ver_bytes[2] as i32) << 8) | (ver_bytes[3] as i32);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ver_bytes[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/encrypted_file.rs:107:53
[INFO] [stderr]     |
[INFO] [stderr] 107 |     let ver: i32 = ((ver_bytes[0] as i32) << 24) | ((ver_bytes[1] as i32) << 16) | ((ver_bytes[2] as i32) << 8) | (ver_bytes[3] as i32);
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ver_bytes[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/encrypted_file.rs:107:85
[INFO] [stderr]     |
[INFO] [stderr] 107 |     let ver: i32 = ((ver_bytes[0] as i32) << 24) | ((ver_bytes[1] as i32) << 16) | ((ver_bytes[2] as i32) << 8) | (ver_bytes[3] as i32);
[INFO] [stderr]     |                                                                                     ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ver_bytes[2])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/encrypted_file.rs:107:115
[INFO] [stderr]     |
[INFO] [stderr] 107 |     let ver: i32 = ((ver_bytes[0] as i32) << 24) | ((ver_bytes[1] as i32) << 16) | ((ver_bytes[2] as i32) << 8) | (ver_bytes[3] as i32);
[INFO] [stderr]     |                                                                                                                   ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ver_bytes[3])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/lib.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 | /     match location {
[INFO] [stderr] 63 | |         &DbLocation::DotLocal => {
[INFO] [stderr] 64 | |             path = std::env::home_dir().unwrap();
[INFO] [stderr] 65 | |             path.push(".local");
[INFO] [stderr] ...  |
[INFO] [stderr] 71 | |         },
[INFO] [stderr] 72 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 62 |     match *location {
[INFO] [stderr] 63 |         DbLocation::DotLocal => {
[INFO] [stderr] 64 |             path = std::env::home_dir().unwrap();
[INFO] [stderr] 65 |             path.push(".local");
[INFO] [stderr] 66 |             path.push("share");
[INFO] [stderr] 67 |             path.push("cred-man");
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/bin/cred_man.rs:129:57
[INFO] [stderr]     |
[INFO] [stderr] 129 |                             Some(x) => KvResult::Some { key: key, val: x },
[INFO] [stderr]     |                                                         ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/bin/cred_man.rs:208:30
[INFO] [stderr]     |
[INFO] [stderr] 208 |         Some(RenameCmdArgs { from: from, to: to })
[INFO] [stderr]     |                              ^^^^^^^^^^ help: replace it with: `from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/bin/cred_man.rs:208:42
[INFO] [stderr]     |
[INFO] [stderr] 208 |         Some(RenameCmdArgs { from: from, to: to })
[INFO] [stderr]     |                                          ^^^^^^ help: replace it with: `to`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/bin/cred_man.rs:275:39
[INFO] [stderr]     |
[INFO] [stderr] 275 |                 return Some(EditCmd { key: key, op: EditCmdOperation::Del(subkey) });
[INFO] [stderr]     |                                       ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/bin/cred_man.rs:282:39
[INFO] [stderr]     |
[INFO] [stderr] 282 |                 return Some(EditCmd { key: key, op: EditCmdOperation::Add(subkey, value) });
[INFO] [stderr]     |                                       ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/bin/cred_man.rs:289:39
[INFO] [stderr]     |
[INFO] [stderr] 289 |                 return Some(EditCmd { key: key, op: EditCmdOperation::Update(subkey, value) });
[INFO] [stderr]     |                                       ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/bin/cred_man.rs:296:39
[INFO] [stderr]     |
[INFO] [stderr] 296 |                 return Some(EditCmd { key: key, op: EditCmdOperation::Rename(subkey, new_subkey) });
[INFO] [stderr]     |                                       ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/bin/cred_man.rs:129:57
[INFO] [stderr]     |
[INFO] [stderr] 129 |                             Some(x) => KvResult::Some { key: key, val: x },
[INFO] [stderr]     |                                                         ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/bin/cred_man.rs:208:30
[INFO] [stderr]     |
[INFO] [stderr] 208 |         Some(RenameCmdArgs { from: from, to: to })
[INFO] [stderr]     |                              ^^^^^^^^^^ help: replace it with: `from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/bin/cred_man.rs:208:42
[INFO] [stderr]     |
[INFO] [stderr] 208 |         Some(RenameCmdArgs { from: from, to: to })
[INFO] [stderr]     |                                          ^^^^^^ help: replace it with: `to`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/bin/cred_man.rs:275:39
[INFO] [stderr]     |
[INFO] [stderr] 275 |                 return Some(EditCmd { key: key, op: EditCmdOperation::Del(subkey) });
[INFO] [stderr]     |                                       ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/bin/cred_man.rs:282:39
[INFO] [stderr]     |
[INFO] [stderr] 282 |                 return Some(EditCmd { key: key, op: EditCmdOperation::Add(subkey, value) });
[INFO] [stderr]     |                                       ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/bin/cred_man.rs:289:39
[INFO] [stderr]     |
[INFO] [stderr] 289 |                 return Some(EditCmd { key: key, op: EditCmdOperation::Update(subkey, value) });
[INFO] [stderr]     |                                       ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/bin/cred_man.rs:296:39
[INFO] [stderr]     |
[INFO] [stderr] 296 |                 return Some(EditCmd { key: key, op: EditCmdOperation::Rename(subkey, new_subkey) });
[INFO] [stderr]     |                                       ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/bin/cred_man.rs:42:25
[INFO] [stderr]    |
[INFO] [stderr] 42 | const DTO_TIME_FORMAT: &'static str = "%Y-%m-%dT%H:%M:%S";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bin/cred_man.rs:275:17
[INFO] [stderr]     |
[INFO] [stderr] 275 |                 return Some(EditCmd { key: key, op: EditCmdOperation::Del(subkey) });
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(EditCmd { key: key, op: EditCmdOperation::Del(subkey) })`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bin/cred_man.rs:282:17
[INFO] [stderr]     |
[INFO] [stderr] 282 |                 return Some(EditCmd { key: key, op: EditCmdOperation::Add(subkey, value) });
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(EditCmd { key: key, op: EditCmdOperation::Add(subkey, value) })`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bin/cred_man.rs:289:17
[INFO] [stderr]     |
[INFO] [stderr] 289 |                 return Some(EditCmd { key: key, op: EditCmdOperation::Update(subkey, value) });
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(EditCmd { key: key, op: EditCmdOperation::Update(subkey, value) })`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bin/cred_man.rs:296:17
[INFO] [stderr]     |
[INFO] [stderr] 296 |                 return Some(EditCmd { key: key, op: EditCmdOperation::Rename(subkey, new_subkey) });
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(EditCmd { key: key, op: EditCmdOperation::Rename(subkey, new_subkey) })`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bin/cred_man.rs:299:17
[INFO] [stderr]     |
[INFO] [stderr] 299 |                 return None;
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/bin/cred_man.rs:575:9
[INFO] [stderr]     |
[INFO] [stderr] 575 | /         if cmd.len() > 0 {
[INFO] [stderr] 576 | |             if !execute_cmd(&mut db, &cmd) {
[INFO] [stderr] 577 | |                 return;
[INFO] [stderr] 578 | |             }
[INFO] [stderr] 579 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 575 |         if cmd.len() > 0 && !execute_cmd(&mut db, &cmd) {
[INFO] [stderr] 576 |     return;
[INFO] [stderr] 577 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/bin/cred_man.rs:42:25
[INFO] [stderr]    |
[INFO] [stderr] 42 | const DTO_TIME_FORMAT: &'static str = "%Y-%m-%dT%H:%M:%S";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/bin/decrypt_db.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 | /         match self {
[INFO] [stderr] 50 | |             &DecryptError::WrongPassword => write!(f, "Wrong password"),
[INFO] [stderr] 51 | |             &DecryptError::IoError(ref e) => write!(f, "{}", e),
[INFO] [stderr] 52 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bin/cred_man.rs:275:17
[INFO] [stderr]     |
[INFO] [stderr] 275 |                 return Some(EditCmd { key: key, op: EditCmdOperation::Del(subkey) });
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(EditCmd { key: key, op: EditCmdOperation::Del(subkey) })`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bin/cred_man.rs:282:17
[INFO] [stderr]     |
[INFO] [stderr] 282 |                 return Some(EditCmd { key: key, op: EditCmdOperation::Add(subkey, value) });
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(EditCmd { key: key, op: EditCmdOperation::Add(subkey, value) })`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bin/cred_man.rs:289:17
[INFO] [stderr]     |
[INFO] [stderr] 289 |                 return Some(EditCmd { key: key, op: EditCmdOperation::Update(subkey, value) });
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(EditCmd { key: key, op: EditCmdOperation::Update(subkey, value) })`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bin/cred_man.rs:296:17
[INFO] [stderr]     |
[INFO] [stderr] 296 |                 return Some(EditCmd { key: key, op: EditCmdOperation::Rename(subkey, new_subkey) });
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(EditCmd { key: key, op: EditCmdOperation::Rename(subkey, new_subkey) })`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bin/cred_man.rs:299:17
[INFO] [stderr]     |
[INFO] [stderr] 299 |                 return None;
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/bin/cred_man.rs:575:9
[INFO] [stderr]     |
[INFO] [stderr] 575 | /         if cmd.len() > 0 {
[INFO] [stderr] 576 | |             if !execute_cmd(&mut db, &cmd) {
[INFO] [stderr] 577 | |                 return;
[INFO] [stderr] 578 | |             }
[INFO] [stderr] 579 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 575 |         if cmd.len() > 0 && !execute_cmd(&mut db, &cmd) {
[INFO] [stderr] 576 |     return;
[INFO] [stderr] 577 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 49 |         match *self {
[INFO] [stderr] 50 |             DecryptError::WrongPassword => write!(f, "Wrong password"),
[INFO] [stderr] 51 |             DecryptError::IoError(ref e) => write!(f, "{}", e),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'core::str::<impl str>::slice_unchecked': use `get_unchecked(begin..end)` instead
[INFO] [stderr]   --> src/bin/cred_man.rs:29:33
[INFO] [stderr]    |
[INFO] [stderr] 29 |     let cmd = unsafe { cmd_line.slice_unchecked(0, idx) };
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/bin/decrypt_db.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 | /         match self {
[INFO] [stderr] 50 | |             &DecryptError::WrongPassword => write!(f, "Wrong password"),
[INFO] [stderr] 51 | |             &DecryptError::IoError(ref e) => write!(f, "{}", e),
[INFO] [stderr] 52 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 49 |         match *self {
[INFO] [stderr] 50 |             DecryptError::WrongPassword => write!(f, "Wrong password"),
[INFO] [stderr] 51 |             DecryptError::IoError(ref e) => write!(f, "{}", e),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'core::str::<impl str>::slice_unchecked': use `get_unchecked(begin..end)` instead
[INFO] [stderr]   --> src/bin/cred_man.rs:30:34
[INFO] [stderr]    |
[INFO] [stderr] 30 |     let rest = unsafe { cmd_line.slice_unchecked(cmp::min(cmd_line.len(), idx + 1), cmd_line.len()) }.trim();
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'core::str::<impl str>::slice_unchecked': use `get_unchecked(begin..end)` instead
[INFO] [stderr]   --> src/bin/cred_man.rs:29:33
[INFO] [stderr]    |
[INFO] [stderr] 29 |     let cmd = unsafe { cmd_line.slice_unchecked(0, idx) };
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'core::str::<impl str>::slice_unchecked': use `get_unchecked(begin..end)` instead
[INFO] [stderr]   --> src/bin/cred_man.rs:30:34
[INFO] [stderr]    |
[INFO] [stderr] 30 |     let rest = unsafe { cmd_line.slice_unchecked(cmp::min(cmd_line.len(), idx + 1), cmd_line.len()) }.trim();
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/bin/cred_man.rs:28:34
[INFO] [stderr]    |
[INFO] [stderr] 28 |     let idx = cmd_line.find(' ').unwrap_or(cmd_line.len());
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| cmd_line.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/bin/cred_man.rs:94:12
[INFO] [stderr]    |
[INFO] [stderr] 94 |         if key.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!key.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bin/cred_man.rs:145:12
[INFO] [stderr]     |
[INFO] [stderr] 145 |         if key.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!key.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bin/cred_man.rs:181:12
[INFO] [stderr]     |
[INFO] [stderr] 181 |         if args.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/bin/cred_man.rs:218:20
[INFO] [stderr]     |
[INFO] [stderr] 218 |               if let Some(_) = db.data.get(&to) {
[INFO] [stderr]     |  _____________-      ^^^^^^^
[INFO] [stderr] 219 | |                 println!("Key {} already exists, not renaming", to);
[INFO] [stderr] 220 | |             } else {
[INFO] [stderr] 221 | |                 let cur = db.data.remove(&from);
[INFO] [stderr] ...   |
[INFO] [stderr] 233 | |                 }
[INFO] [stderr] 234 | |             }
[INFO] [stderr]     | |_____________- help: try this: `if db.data.get(&to).is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/bin/cred_man.rs:28:34
[INFO] [stderr]    |
[INFO] [stderr] 28 |     let idx = cmd_line.find(' ').unwrap_or(cmd_line.len());
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| cmd_line.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/bin/cred_man.rs:94:12
[INFO] [stderr]    |
[INFO] [stderr] 94 |         if key.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!key.is_empty()`
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/bin/cred_man.rs:335:36
[INFO] [stderr]     |
[INFO] [stderr] 335 |                               if let None = entry.value.get(&subkey) {
[INFO] [stderr]     |  _____________________________-      ^^^^
[INFO] [stderr] 336 | |                                 entry.value.insert(subkey.clone(), value);
[INFO] [stderr] 337 | |                                 should_save = true;
[INFO] [stderr] 338 | |                                 msg = format!("Added subkey {} for {}", subkey, cmd.key);
[INFO] [stderr] ...   |
[INFO] [stderr] 341 | |                                 msg = format!("Subkey {} already exists", subkey);
[INFO] [stderr] 342 | |                             }
[INFO] [stderr]     | |_____________________________- help: try this: `if entry.value.get(&subkey).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bin/cred_man.rs:451:12
[INFO] [stderr]     |
[INFO] [stderr] 451 |         if key.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!key.is_empty()`
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bin/cred_man.rs:145:12
[INFO] [stderr]     |
[INFO] [stderr] 145 |         if key.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!key.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bin/cred_man.rs:476:12
[INFO] [stderr]     |
[INFO] [stderr] 476 |         if key.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!key.is_empty()`
[INFO] [stderr]    --> src/bin/cred_man.rs:181:12
[INFO] [stderr]     |
[INFO] [stderr] 181 |         if args.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/bin/cred_man.rs:218:20
[INFO] [stderr]     |
[INFO] [stderr] 218 |               if let Some(_) = db.data.get(&to) {
[INFO] [stderr]     |  _____________-      ^^^^^^^
[INFO] [stderr] 219 | |                 println!("Key {} already exists, not renaming", to);
[INFO] [stderr] 220 | |             } else {
[INFO] [stderr] 221 | |                 let cur = db.data.remove(&from);
[INFO] [stderr] ...   |
[INFO] [stderr] 233 | |                 }
[INFO] [stderr] 234 | |             }
[INFO] [stderr]     | |_____________- help: try this: `if db.data.get(&to).is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bin/cred_man.rs:495:12
[INFO] [stderr]     |
[INFO] [stderr] 495 |         if args.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bin/cred_man.rs:551:8
[INFO] [stderr]     |
[INFO] [stderr] 551 |     if args.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bin/cred_man.rs:575:12
[INFO] [stderr]     |
[INFO] [stderr] 575 |         if cmd.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!cmd.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/bin/cred_man.rs:335:36
[INFO] [stderr]     |
[INFO] [stderr] 335 |                               if let None = entry.value.get(&subkey) {
[INFO] [stderr]     |  _____________________________-      ^^^^
[INFO] [stderr] 336 | |                                 entry.value.insert(subkey.clone(), value);
[INFO] [stderr] 337 | |                                 should_save = true;
[INFO] [stderr] 338 | |                                 msg = format!("Added subkey {} for {}", subkey, cmd.key);
[INFO] [stderr] ...   |
[INFO] [stderr] 341 | |                                 msg = format!("Subkey {} already exists", subkey);
[INFO] [stderr] 342 | |                             }
[INFO] [stderr]     | |_____________________________- help: try this: `if entry.value.get(&subkey).is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bin/cred_man.rs:451:12
[INFO] [stderr]     |
[INFO] [stderr] 451 |         if key.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!key.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bin/cred_man.rs:476:12
[INFO] [stderr]     |
[INFO] [stderr] 476 |         if key.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!key.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bin/cred_man.rs:495:12
[INFO] [stderr]     |
[INFO] [stderr] 495 |         if args.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bin/cred_man.rs:551:8
[INFO] [stderr]     |
[INFO] [stderr] 551 |     if args.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bin/cred_man.rs:575:12
[INFO] [stderr]     |
[INFO] [stderr] 575 |         if cmd.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!cmd.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/bin/cred_man_gtk.rs:15:20
[INFO] [stderr]    |
[INFO] [stderr] 15 | const BUILDER_UI: &'static str = include_str!("cred_man_gtk.ui");
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `ui`
[INFO] [stderr]    --> src/bin/cred_man_gtk.rs:256:9
[INFO] [stderr]     |
[INFO] [stderr] 256 |     let ui = Ui::new();
[INFO] [stderr]     |         ^^ help: consider using `_ui` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/bin/cred_man_gtk.rs:201:17
[INFO] [stderr]     |
[INFO] [stderr] 201 |             let mut ui = &mut *ui_ref.borrow_mut();
[INFO] [stderr]     |                 ----^^
[INFO] [stderr]     |                 |
[INFO] [stderr]     |                 help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/bin/cred_man_gtk.rs:223:17
[INFO] [stderr]     |
[INFO] [stderr] 223 |             let mut ui = &mut *ui_ref.borrow_mut();
[INFO] [stderr]     |                 ----^^
[INFO] [stderr]     |                 |
[INFO] [stderr]     |                 help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: structure field `treeCredentials` should have a snake case name such as `tree_credentials`
[INFO] [stderr]   --> src/bin/cred_man_gtk.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 |     treeCredentials: gtk::TreeView,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: structure field `btnUnlock` should have a snake case name such as `btn_unlock`
[INFO] [stderr]   --> src/bin/cred_man_gtk.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 |     btnUnlock: gtk::ToolButton,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: structure field `dlgPassword` should have a snake case name such as `dlg_password`
[INFO] [stderr]   --> src/bin/cred_man_gtk.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 |     dlgPassword: gtk::Dialog,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: structure field `entryPassword` should have a snake case name such as `entry_password`
[INFO] [stderr]   --> src/bin/cred_man_gtk.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 |     entryPassword: gtk::Entry,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variable `treeCredentials` should have a snake case name such as `tree_credentials`
[INFO] [stderr]   --> src/bin/cred_man_gtk.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 |         let treeCredentials: gtk::TreeView = b.get_object("treeCredentials").expect("Unable to find treeCredentials");
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variable `btnUnlock` should have a snake case name such as `btn_unlock`
[INFO] [stderr]   --> src/bin/cred_man_gtk.rs:47:13
[INFO] [stderr]    |
[INFO] [stderr] 47 |         let btnUnlock: gtk::ToolButton = b.get_object("btnUnlock").expect("Unable to find btnUnlock");
[INFO] [stderr]    |             ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variable `dlgPassword` should have a snake case name such as `dlg_password`
[INFO] [stderr]   --> src/bin/cred_man_gtk.rs:49:13
[INFO] [stderr]    |
[INFO] [stderr] 49 |         let dlgPassword: gtk::Dialog = b.get_object("dlgPassword").expect("Unable to find dlgPassword");
[INFO] [stderr]    |             ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variable `entryPassword` should have a snake case name such as `entry_password`
[INFO] [stderr]   --> src/bin/cred_man_gtk.rs:51:13
[INFO] [stderr]    |
[INFO] [stderr] 51 |         let entryPassword: gtk::Entry = b.get_object("entryPassword").expect("Unable to find entryPassword");
[INFO] [stderr]    |             ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/bin/cred_man_gtk.rs:90:74
[INFO] [stderr]    |
[INFO] [stderr] 90 |                 let password = result2.borrow().entryPassword.get_text().unwrap_or("".to_owned());
[INFO] [stderr]    |                                                                          ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/bin/cred_man_gtk.rs:174:79
[INFO] [stderr]     |
[INFO] [stderr] 174 |         let search_criteria = ui.borrow().entry_search_credentials.get_text().unwrap_or("".to_owned()).trim().to_owned();
[INFO] [stderr]     |                                                                               ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bin/cred_man_gtk.rs:175:29
[INFO] [stderr]     |
[INFO] [stderr] 175 |         let filter_key = if search_criteria.len() > 0 { Some(&search_criteria) } else { None };
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!search_criteria.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/bin/cred_man_gtk.rs:210:25
[INFO] [stderr]     |
[INFO] [stderr] 210 |             let value = db.data.get(key).unwrap().value.get(attr).unwrap();
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&db.data.get(key).unwrap().value[attr]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/bin/cred_man_gtk.rs:210:25
[INFO] [stderr]     |
[INFO] [stderr] 210 |             let value = db.data.get(key).unwrap().value.get(attr).unwrap();
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&db.data[key]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/bin/cred_man_gtk.rs:15:20
[INFO] [stderr]    |
[INFO] [stderr] 15 | const BUILDER_UI: &'static str = include_str!("cred_man_gtk.ui");
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `ui`
[INFO] [stderr]    --> src/bin/cred_man_gtk.rs:256:9
[INFO] [stderr]     |
[INFO] [stderr] 256 |     let ui = Ui::new();
[INFO] [stderr]     |         ^^ help: consider using `_ui` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/bin/cred_man_gtk.rs:201:17
[INFO] [stderr]     |
[INFO] [stderr] 201 |             let mut ui = &mut *ui_ref.borrow_mut();
[INFO] [stderr]     |                 ----^^
[INFO] [stderr]     |                 |
[INFO] [stderr]     |                 help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/bin/cred_man_gtk.rs:223:17
[INFO] [stderr]     |
[INFO] [stderr] 223 |             let mut ui = &mut *ui_ref.borrow_mut();
[INFO] [stderr]     |                 ----^^
[INFO] [stderr]     |                 |
[INFO] [stderr]     |                 help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: structure field `treeCredentials` should have a snake case name such as `tree_credentials`
[INFO] [stderr]   --> src/bin/cred_man_gtk.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 |     treeCredentials: gtk::TreeView,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: structure field `btnUnlock` should have a snake case name such as `btn_unlock`
[INFO] [stderr]   --> src/bin/cred_man_gtk.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 |     btnUnlock: gtk::ToolButton,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: structure field `dlgPassword` should have a snake case name such as `dlg_password`
[INFO] [stderr]   --> src/bin/cred_man_gtk.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 |     dlgPassword: gtk::Dialog,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: structure field `entryPassword` should have a snake case name such as `entry_password`
[INFO] [stderr]   --> src/bin/cred_man_gtk.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 |     entryPassword: gtk::Entry,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variable `treeCredentials` should have a snake case name such as `tree_credentials`
[INFO] [stderr]   --> src/bin/cred_man_gtk.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 |         let treeCredentials: gtk::TreeView = b.get_object("treeCredentials").expect("Unable to find treeCredentials");
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variable `btnUnlock` should have a snake case name such as `btn_unlock`
[INFO] [stderr]   --> src/bin/cred_man_gtk.rs:47:13
[INFO] [stderr]    |
[INFO] [stderr] 47 |         let btnUnlock: gtk::ToolButton = b.get_object("btnUnlock").expect("Unable to find btnUnlock");
[INFO] [stderr]    |             ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variable `dlgPassword` should have a snake case name such as `dlg_password`
[INFO] [stderr]   --> src/bin/cred_man_gtk.rs:49:13
[INFO] [stderr]    |
[INFO] [stderr] 49 |         let dlgPassword: gtk::Dialog = b.get_object("dlgPassword").expect("Unable to find dlgPassword");
[INFO] [stderr]    |             ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variable `entryPassword` should have a snake case name such as `entry_password`
[INFO] [stderr]   --> src/bin/cred_man_gtk.rs:51:13
[INFO] [stderr]    |
[INFO] [stderr] 51 |         let entryPassword: gtk::Entry = b.get_object("entryPassword").expect("Unable to find entryPassword");
[INFO] [stderr]    |             ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/bin/cred_man_gtk.rs:90:74
[INFO] [stderr]    |
[INFO] [stderr] 90 |                 let password = result2.borrow().entryPassword.get_text().unwrap_or("".to_owned());
[INFO] [stderr]    |                                                                          ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/bin/cred_man_gtk.rs:174:79
[INFO] [stderr]     |
[INFO] [stderr] 174 |         let search_criteria = ui.borrow().entry_search_credentials.get_text().unwrap_or("".to_owned()).trim().to_owned();
[INFO] [stderr]     |                                                                               ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bin/cred_man_gtk.rs:175:29
[INFO] [stderr]     |
[INFO] [stderr] 175 |         let filter_key = if search_criteria.len() > 0 { Some(&search_criteria) } else { None };
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!search_criteria.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/bin/cred_man_gtk.rs:210:25
[INFO] [stderr]     |
[INFO] [stderr] 210 |             let value = db.data.get(key).unwrap().value.get(attr).unwrap();
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&db.data.get(key).unwrap().value[attr]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/bin/cred_man_gtk.rs:210:25
[INFO] [stderr]     |
[INFO] [stderr] 210 |             let value = db.data.get(key).unwrap().value.get(attr).unwrap();
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&db.data[key]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 58.78s
[INFO] running `"docker" "inspect" "d33321d3e66cdb11c1be14b4d078678d5db3c017c403246284e70af430c83f20"`
[INFO] running `"docker" "rm" "-f" "d33321d3e66cdb11c1be14b4d078678d5db3c017c403246284e70af430c83f20"`
[INFO] [stdout] d33321d3e66cdb11c1be14b4d078678d5db3c017c403246284e70af430c83f20