[INFO] updating cached repository dmitryvakulenko/xsdparser
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/dmitryvakulenko/xsdparser
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/dmitryvakulenko/xsdparser" "work/ex/clippy-test-run/sources/stable/gh/dmitryvakulenko/xsdparser"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dmitryvakulenko/xsdparser'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/dmitryvakulenko/xsdparser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmitryvakulenko/xsdparser"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmitryvakulenko/xsdparser'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b5bbd6f590ae8438a5622fcb1e3aeb38f9d9c8e4
[INFO] sha for GitHub repo dmitryvakulenko/xsdparser: b5bbd6f590ae8438a5622fcb1e3aeb38f9d9c8e4
[INFO] validating manifest of dmitryvakulenko/xsdparser on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dmitryvakulenko/xsdparser on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dmitryvakulenko/xsdparser
[INFO] finished frobbing dmitryvakulenko/xsdparser
[INFO] frobbed toml for dmitryvakulenko/xsdparser written to work/ex/clippy-test-run/sources/stable/gh/dmitryvakulenko/xsdparser/Cargo.toml
[INFO] started frobbing dmitryvakulenko/xsdparser
[INFO] finished frobbing dmitryvakulenko/xsdparser
[INFO] frobbed toml for dmitryvakulenko/xsdparser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmitryvakulenko/xsdparser/Cargo.toml
[INFO] crate dmitryvakulenko/xsdparser has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] [stderr]     Blocking waiting for file lock on the registry index
[INFO] linting dmitryvakulenko/xsdparser against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dmitryvakulenko/xsdparser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f9f5b11014412677921575d895f1cfc2c66af8fc7aabc5158f4c41f3d65f7543
[INFO] running `"docker" "start" "-a" "f9f5b11014412677921575d895f1cfc2c66af8fc7aabc5158f4c41f3d65f7543"`
[INFO] [stderr]     Checking simple_logger v1.0.1
[INFO] [stderr]     Checking xsdparser v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cmd_line.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 |     return res
[INFO] [stderr]    |     ^^^^^^^^^^ help: remove `return` as shown: `res`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cmd_line.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 |     return res
[INFO] [stderr]    |     ^^^^^^^^^^ help: remove `return` as shown: `res`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]  --> src/cmd_line.rs:9:31
[INFO] [stderr]   |
[INFO] [stderr] 9 |     while let Some(cur_arg) = args.next() {
[INFO] [stderr]   |                               ^^^^^^^^^^^ help: try: `for cur_arg in args { .. }`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/parser/mod.rs:9:30
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn build_tree(file_name: &String) {
[INFO] [stderr]   |                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]  --> src/cmd_line.rs:9:31
[INFO] [stderr]   |
[INFO] [stderr] 9 |     while let Some(cur_arg) = args.next() {
[INFO] [stderr]   |                               ^^^^^^^^^^^ help: try: `for cur_arg in args { .. }`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/parser/mod.rs:9:30
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn build_tree(file_name: &String) {
[INFO] [stderr]   |                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/parser/mod.rs:26:17
[INFO] [stderr]    |
[INFO] [stderr] 26 | /                 match parents.pop() {
[INFO] [stderr] 27 | |                     Some(n) =>
[INFO] [stderr] 28 | |                         match parents.last_mut() {
[INFO] [stderr] 29 | |                             Some(last) => last.add_child(n),
[INFO] [stderr] ...  |
[INFO] [stderr] 32 | |                     None => {}
[INFO] [stderr] 33 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 26 |                 if let Some(n) = parents.pop() { match parents.last_mut() {
[INFO] [stderr] 27 |     Some(last) => last.add_child(n),
[INFO] [stderr] 28 |     None => root.add_child(n)
[INFO] [stderr] 29 | } }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/main.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     let _ = parser::build_tree(&schemas[0]);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/parser/mod.rs:26:17
[INFO] [stderr]    |
[INFO] [stderr] 26 | /                 match parents.pop() {
[INFO] [stderr] 27 | |                     Some(n) =>
[INFO] [stderr] 28 | |                         match parents.last_mut() {
[INFO] [stderr] 29 | |                             Some(last) => last.add_child(n),
[INFO] [stderr] ...  |
[INFO] [stderr] 32 | |                     None => {}
[INFO] [stderr] 33 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 26 |                 if let Some(n) = parents.pop() { match parents.last_mut() {
[INFO] [stderr] 27 |     Some(last) => last.add_child(n),
[INFO] [stderr] 28 |     None => root.add_child(n)
[INFO] [stderr] 29 | } }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/main.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     let _ = parser::build_tree(&schemas[0]);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.76s
[INFO] running `"docker" "inspect" "f9f5b11014412677921575d895f1cfc2c66af8fc7aabc5158f4c41f3d65f7543"`
[INFO] running `"docker" "rm" "-f" "f9f5b11014412677921575d895f1cfc2c66af8fc7aabc5158f4c41f3d65f7543"`
[INFO] [stdout] f9f5b11014412677921575d895f1cfc2c66af8fc7aabc5158f4c41f3d65f7543