[INFO] updating cached repository dmit/tinyrenderer-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dmit/tinyrenderer-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dmit/tinyrenderer-rs" "work/ex/clippy-test-run/sources/stable/gh/dmit/tinyrenderer-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dmit/tinyrenderer-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dmit/tinyrenderer-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmit/tinyrenderer-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmit/tinyrenderer-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4bef0ed37be6e7057c39bf3d4892bfc66c70270f [INFO] sha for GitHub repo dmit/tinyrenderer-rs: 4bef0ed37be6e7057c39bf3d4892bfc66c70270f [INFO] validating manifest of dmit/tinyrenderer-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dmit/tinyrenderer-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dmit/tinyrenderer-rs [INFO] finished frobbing dmit/tinyrenderer-rs [INFO] frobbed toml for dmit/tinyrenderer-rs written to work/ex/clippy-test-run/sources/stable/gh/dmit/tinyrenderer-rs/Cargo.toml [INFO] started frobbing dmit/tinyrenderer-rs [INFO] finished frobbing dmit/tinyrenderer-rs [INFO] frobbed toml for dmit/tinyrenderer-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmit/tinyrenderer-rs/Cargo.toml [INFO] crate dmit/tinyrenderer-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dmit/tinyrenderer-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dmit/tinyrenderer-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4f812abfddae8368112589d2075e09a339e72f386c49b54b8fa2d40d870f39a4 [INFO] running `"docker" "start" "-a" "4f812abfddae8368112589d2075e09a339e72f386c49b54b8fa2d40d870f39a4"` [INFO] [stderr] Compiling rayon-core v1.2.0 [INFO] [stderr] Checking png v0.8.0 [INFO] [stderr] Checking rayon v0.8.1 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.14.0 [INFO] [stderr] Checking tiny v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wavefront.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wavefront.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | faces: faces, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `faces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/wavefront.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | let v = Vert { x: x, y: y, z: z }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wavefront.rs:79:24 [INFO] [stderr] | [INFO] [stderr] 79 | let v = Vert { x: x, y: y, z: z }; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wavefront.rs:79:30 [INFO] [stderr] | [INFO] [stderr] 79 | let v = Vert { x: x, y: y, z: z }; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wavefront.rs:79:36 [INFO] [stderr] | [INFO] [stderr] 79 | let v = Vert { x: x, y: y, z: z }; [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wavefront.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wavefront.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | faces: faces, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `faces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/wavefront.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | let v = Vert { x: x, y: y, z: z }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wavefront.rs:79:24 [INFO] [stderr] | [INFO] [stderr] 79 | let v = Vert { x: x, y: y, z: z }; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wavefront.rs:79:30 [INFO] [stderr] | [INFO] [stderr] 79 | let v = Vert { x: x, y: y, z: z }; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wavefront.rs:79:36 [INFO] [stderr] | [INFO] [stderr] 79 | let v = Vert { x: x, y: y, z: z }; [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/bin/lesson01_obj_render.rs:28:26 [INFO] [stderr] | [INFO] [stderr] 28 | s.parse::().expect(&format!("Invalid width: {}", s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Invalid width: {}", s))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/bin/lesson01_obj_render.rs:31:26 [INFO] [stderr] | [INFO] [stderr] 31 | s.parse::().expect(&format!("Invalid height: {}", s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Invalid height: {}", s))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/bin/lesson01_obj_render.rs:77:18 [INFO] [stderr] | [INFO] [stderr] 77 | let steep = (x0 as i64 - x1 as i64).abs() < (y0 as i64 - y1 as i64).abs(); [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(x0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/bin/lesson01_obj_render.rs:77:30 [INFO] [stderr] | [INFO] [stderr] 77 | let steep = (x0 as i64 - x1 as i64).abs() < (y0 as i64 - y1 as i64).abs(); [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/bin/lesson01_obj_render.rs:77:50 [INFO] [stderr] | [INFO] [stderr] 77 | let steep = (x0 as i64 - x1 as i64).abs() < (y0 as i64 - y1 as i64).abs(); [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(y0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/bin/lesson01_obj_render.rs:77:62 [INFO] [stderr] | [INFO] [stderr] 77 | let steep = (x0 as i64 - x1 as i64).abs() < (y0 as i64 - y1 as i64).abs(); [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(y1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/bin/lesson01_obj_render.rs:88:14 [INFO] [stderr] | [INFO] [stderr] 88 | let dx = x1 as i64 - x0 as i64; [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/bin/lesson01_obj_render.rs:88:26 [INFO] [stderr] | [INFO] [stderr] 88 | let dx = x1 as i64 - x0 as i64; [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(x0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/bin/lesson01_obj_render.rs:89:14 [INFO] [stderr] | [INFO] [stderr] 89 | let dy = y1 as i64 - y0 as i64; [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(y1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/bin/lesson01_obj_render.rs:89:26 [INFO] [stderr] | [INFO] [stderr] 89 | let dy = y1 as i64 - y0 as i64; [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(y0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/bin/lesson01_obj_render.rs:28:26 [INFO] [stderr] | [INFO] [stderr] 28 | s.parse::().expect(&format!("Invalid width: {}", s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Invalid width: {}", s))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/bin/lesson01_obj_render.rs:31:26 [INFO] [stderr] | [INFO] [stderr] 31 | s.parse::().expect(&format!("Invalid height: {}", s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Invalid height: {}", s))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/bin/lesson01_obj_render.rs:77:18 [INFO] [stderr] | [INFO] [stderr] 77 | let steep = (x0 as i64 - x1 as i64).abs() < (y0 as i64 - y1 as i64).abs(); [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(x0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/bin/lesson01_obj_render.rs:77:30 [INFO] [stderr] | [INFO] [stderr] 77 | let steep = (x0 as i64 - x1 as i64).abs() < (y0 as i64 - y1 as i64).abs(); [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/bin/lesson01_obj_render.rs:77:50 [INFO] [stderr] | [INFO] [stderr] 77 | let steep = (x0 as i64 - x1 as i64).abs() < (y0 as i64 - y1 as i64).abs(); [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(y0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/bin/lesson01_obj_render.rs:77:62 [INFO] [stderr] | [INFO] [stderr] 77 | let steep = (x0 as i64 - x1 as i64).abs() < (y0 as i64 - y1 as i64).abs(); [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(y1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/bin/lesson01_obj_render.rs:88:14 [INFO] [stderr] | [INFO] [stderr] 88 | let dx = x1 as i64 - x0 as i64; [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/bin/lesson01_obj_render.rs:88:26 [INFO] [stderr] | [INFO] [stderr] 88 | let dx = x1 as i64 - x0 as i64; [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(x0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/bin/lesson01_obj_render.rs:89:14 [INFO] [stderr] | [INFO] [stderr] 89 | let dy = y1 as i64 - y0 as i64; [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(y1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/bin/lesson01_obj_render.rs:89:26 [INFO] [stderr] | [INFO] [stderr] 89 | let dy = y1 as i64 - y0 as i64; [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(y0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.62s [INFO] running `"docker" "inspect" "4f812abfddae8368112589d2075e09a339e72f386c49b54b8fa2d40d870f39a4"` [INFO] running `"docker" "rm" "-f" "4f812abfddae8368112589d2075e09a339e72f386c49b54b8fa2d40d870f39a4"` [INFO] [stdout] 4f812abfddae8368112589d2075e09a339e72f386c49b54b8fa2d40d870f39a4