[INFO] updating cached repository dmhacker/dual-ec-drbg [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dmhacker/dual-ec-drbg [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dmhacker/dual-ec-drbg" "work/ex/clippy-test-run/sources/stable/gh/dmhacker/dual-ec-drbg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dmhacker/dual-ec-drbg'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dmhacker/dual-ec-drbg" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmhacker/dual-ec-drbg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmhacker/dual-ec-drbg'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 468a4b605eb4aaa2819ba61acb525656ea872f79 [INFO] sha for GitHub repo dmhacker/dual-ec-drbg: 468a4b605eb4aaa2819ba61acb525656ea872f79 [INFO] validating manifest of dmhacker/dual-ec-drbg on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dmhacker/dual-ec-drbg on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dmhacker/dual-ec-drbg [INFO] finished frobbing dmhacker/dual-ec-drbg [INFO] frobbed toml for dmhacker/dual-ec-drbg written to work/ex/clippy-test-run/sources/stable/gh/dmhacker/dual-ec-drbg/Cargo.toml [INFO] started frobbing dmhacker/dual-ec-drbg [INFO] finished frobbing dmhacker/dual-ec-drbg [INFO] frobbed toml for dmhacker/dual-ec-drbg written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmhacker/dual-ec-drbg/Cargo.toml [INFO] crate dmhacker/dual-ec-drbg has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dmhacker/dual-ec-drbg against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dmhacker/dual-ec-drbg:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2f23a025c9f56ab7bb5ebbd9620dd0bd350a188bec45d923018b66af3a4de6d3 [INFO] running `"docker" "start" "-a" "2f23a025c9f56ab7bb5ebbd9620dd0bd350a188bec45d923018b66af3a4de6d3"` [INFO] [stderr] Compiling gmp-mpfr-sys v1.1.8 [INFO] [stderr] Compiling rug v1.2.0 [INFO] [stderr] Checking dualecdrbg v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/math.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | let mut r = self.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/math.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | let mut t = self.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/math.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | let mut m = ss; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/math.rs:79:21 [INFO] [stderr] | [INFO] [stderr] 79 | let mut i = Integer::new(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/math.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | let mut b = c.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/math.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | let mut e = Integer::from(&m - &i); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/points.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | let mut i = m - 2; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prng.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | outsize: outsize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `outsize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prng.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | outmask: outmask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `outmask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/math.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | let mut r = self.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/math.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | let mut t = self.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/math.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | let mut m = ss; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/math.rs:79:21 [INFO] [stderr] | [INFO] [stderr] 79 | let mut i = Integer::new(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/math.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | let mut b = c.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/math.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | let mut e = Integer::from(&m - &i); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/points.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | let mut i = m - 2; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prng.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | outsize: outsize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `outsize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prng.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | outmask: outmask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `outmask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prng.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prng.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/prng.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn next(&mut self) -> Integer { [INFO] [stderr] 39 | | // Create a reference to a clone DRBG's curve parameters [INFO] [stderr] 40 | | let curve = Rc::new(self.curve.clone()); [INFO] [stderr] 41 | | [INFO] [stderr] ... | [INFO] [stderr] 55 | | tq.x & &self.outmask [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/backdoor.rs:27:37 [INFO] [stderr] | [INFO] [stderr] 27 | let halt_counter = Arc::new(Mutex::new(false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backdoor.rs:13:19 [INFO] [stderr] | [INFO] [stderr] 13 | ($e:expr) => (match $e { [INFO] [stderr] | ___________________^ [INFO] [stderr] 14 | | Ok(_) => (), [INFO] [stderr] 15 | | Err(_) => () [INFO] [stderr] 16 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 44 | / try_and_discard!(tx.send( [INFO] [stderr] 45 | | (work_result, "".to_string()) [INFO] [stderr] 46 | | )); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | ($e:expr) => (if let Ok(_) = tx.send( [INFO] [stderr] 14 | (work_result, "".to_string()) [INFO] [stderr] 15 | ) { try_and_discard!(tx.send( [INFO] [stderr] 16 | (work_result, "".to_string()) [INFO] [stderr] 17 | )); }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backdoor.rs:13:19 [INFO] [stderr] | [INFO] [stderr] 13 | ($e:expr) => (match $e { [INFO] [stderr] | ___________________^ [INFO] [stderr] 14 | | Ok(_) => (), [INFO] [stderr] 15 | | Err(_) => () [INFO] [stderr] 16 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 79 | / try_and_discard!(tx.send( [INFO] [stderr] 80 | | (None, format!("{}: {} ", message_prefix, debug_message)) [INFO] [stderr] 81 | | )); [INFO] [stderr] | |___________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | ($e:expr) => (if let Ok(_) = tx.send( [INFO] [stderr] 14 | (None, format!("{}: {} ", message_prefix, debug_message)) [INFO] [stderr] 15 | ) { try_and_discard!(tx.send( [INFO] [stderr] 16 | (None, format!("{}: {} ", message_prefix, debug_message)) [INFO] [stderr] 17 | )); }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backdoor.rs:109:21 [INFO] [stderr] | [INFO] [stderr] 109 | / match rqy2.sqrt_mod(&curve.p) { [INFO] [stderr] 110 | | Some(rqy) => { [INFO] [stderr] 111 | | // Now that we know rQ's x, y coordinates, we know the point itself [INFO] [stderr] 112 | | let rq = CurvePoint { [INFO] [stderr] ... | [INFO] [stderr] 133 | | None => () [INFO] [stderr] 134 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 109 | if let Some(rqy) = rqy2.sqrt_mod(&curve.p) { [INFO] [stderr] 110 | // Now that we know rQ's x, y coordinates, we know the point itself [INFO] [stderr] 111 | let rq = CurvePoint { [INFO] [stderr] 112 | x: rqx, [INFO] [stderr] 113 | y: rqy, [INFO] [stderr] 114 | curve: Rc::clone(&curve) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backdoor.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | / match rx.recv() { [INFO] [stderr] 155 | | Ok((result, message)) => { [INFO] [stderr] 156 | | // An empty message indicates that a work result was submitted [INFO] [stderr] 157 | | if message == "" { [INFO] [stderr] ... | [INFO] [stderr] 177 | | _ => () [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 154 | if let Ok((result, message)) = rx.recv() { [INFO] [stderr] 155 | // An empty message indicates that a work result was submitted [INFO] [stderr] 156 | if message == "" { [INFO] [stderr] 157 | match result { [INFO] [stderr] 158 | Some(ret) => { [INFO] [stderr] 159 | // Set the global result to be that child's work result [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backdoor.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | / match result { [INFO] [stderr] 159 | | Some(ret) => { [INFO] [stderr] 160 | | // Set the global result to be that child's work result [INFO] [stderr] 161 | | global_result = Some(ret); [INFO] [stderr] ... | [INFO] [stderr] 167 | | None => () [INFO] [stderr] 168 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 158 | if let Some(ret) = result { [INFO] [stderr] 159 | // Set the global result to be that child's work result [INFO] [stderr] 160 | global_result = Some(ret); [INFO] [stderr] 161 | [INFO] [stderr] 162 | // Any other active child threads should halt [INFO] [stderr] 163 | let mut halt = halt_counter.lock().unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / let seed : Integer; [INFO] [stderr] 83 | | if seed_str == "" { [INFO] [stderr] 84 | | seed = rng.gen_uint(curve.bitsize); [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | else { [INFO] [stderr] 87 | | seed = Integer::from_str_radix(&seed_str, 10).unwrap(); [INFO] [stderr] 88 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let seed = if seed_str == "" { rng.gen_uint(curve.bitsize) } else { Integer::from_str_radix(&seed_str, 10).unwrap() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/prng.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn next(&mut self) -> Integer { [INFO] [stderr] 39 | | // Create a reference to a clone DRBG's curve parameters [INFO] [stderr] 40 | | let curve = Rc::new(self.curve.clone()); [INFO] [stderr] 41 | | [INFO] [stderr] ... | [INFO] [stderr] 55 | | tq.x & &self.outmask [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/backdoor.rs:27:37 [INFO] [stderr] | [INFO] [stderr] 27 | let halt_counter = Arc::new(Mutex::new(false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backdoor.rs:13:19 [INFO] [stderr] | [INFO] [stderr] 13 | ($e:expr) => (match $e { [INFO] [stderr] | ___________________^ [INFO] [stderr] 14 | | Ok(_) => (), [INFO] [stderr] 15 | | Err(_) => () [INFO] [stderr] 16 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 44 | / try_and_discard!(tx.send( [INFO] [stderr] 45 | | (work_result, "".to_string()) [INFO] [stderr] 46 | | )); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | ($e:expr) => (if let Ok(_) = tx.send( [INFO] [stderr] 14 | (work_result, "".to_string()) [INFO] [stderr] 15 | ) { try_and_discard!(tx.send( [INFO] [stderr] 16 | (work_result, "".to_string()) [INFO] [stderr] 17 | )); }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backdoor.rs:13:19 [INFO] [stderr] | [INFO] [stderr] 13 | ($e:expr) => (match $e { [INFO] [stderr] | ___________________^ [INFO] [stderr] 14 | | Ok(_) => (), [INFO] [stderr] 15 | | Err(_) => () [INFO] [stderr] 16 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 79 | / try_and_discard!(tx.send( [INFO] [stderr] 80 | | (None, format!("{}: {} ", message_prefix, debug_message)) [INFO] [stderr] 81 | | )); [INFO] [stderr] | |___________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | ($e:expr) => (if let Ok(_) = tx.send( [INFO] [stderr] 14 | (None, format!("{}: {} ", message_prefix, debug_message)) [INFO] [stderr] 15 | ) { try_and_discard!(tx.send( [INFO] [stderr] 16 | (None, format!("{}: {} ", message_prefix, debug_message)) [INFO] [stderr] 17 | )); }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backdoor.rs:109:21 [INFO] [stderr] | [INFO] [stderr] 109 | / match rqy2.sqrt_mod(&curve.p) { [INFO] [stderr] 110 | | Some(rqy) => { [INFO] [stderr] 111 | | // Now that we know rQ's x, y coordinates, we know the point itself [INFO] [stderr] 112 | | let rq = CurvePoint { [INFO] [stderr] ... | [INFO] [stderr] 133 | | None => () [INFO] [stderr] 134 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 109 | if let Some(rqy) = rqy2.sqrt_mod(&curve.p) { [INFO] [stderr] 110 | // Now that we know rQ's x, y coordinates, we know the point itself [INFO] [stderr] 111 | let rq = CurvePoint { [INFO] [stderr] 112 | x: rqx, [INFO] [stderr] 113 | y: rqy, [INFO] [stderr] 114 | curve: Rc::clone(&curve) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backdoor.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | / match rx.recv() { [INFO] [stderr] 155 | | Ok((result, message)) => { [INFO] [stderr] 156 | | // An empty message indicates that a work result was submitted [INFO] [stderr] 157 | | if message == "" { [INFO] [stderr] ... | [INFO] [stderr] 177 | | _ => () [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 154 | if let Ok((result, message)) = rx.recv() { [INFO] [stderr] 155 | // An empty message indicates that a work result was submitted [INFO] [stderr] 156 | if message == "" { [INFO] [stderr] 157 | match result { [INFO] [stderr] 158 | Some(ret) => { [INFO] [stderr] 159 | // Set the global result to be that child's work result [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/backdoor.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | / match result { [INFO] [stderr] 159 | | Some(ret) => { [INFO] [stderr] 160 | | // Set the global result to be that child's work result [INFO] [stderr] 161 | | global_result = Some(ret); [INFO] [stderr] ... | [INFO] [stderr] 167 | | None => () [INFO] [stderr] 168 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 158 | if let Some(ret) = result { [INFO] [stderr] 159 | // Set the global result to be that child's work result [INFO] [stderr] 160 | global_result = Some(ret); [INFO] [stderr] 161 | [INFO] [stderr] 162 | // Any other active child threads should halt [INFO] [stderr] 163 | let mut halt = halt_counter.lock().unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / let seed : Integer; [INFO] [stderr] 83 | | if seed_str == "" { [INFO] [stderr] 84 | | seed = rng.gen_uint(curve.bitsize); [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | else { [INFO] [stderr] 87 | | seed = Integer::from_str_radix(&seed_str, 10).unwrap(); [INFO] [stderr] 88 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let seed = if seed_str == "" { rng.gen_uint(curve.bitsize) } else { Integer::from_str_radix(&seed_str, 10).unwrap() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 49s [INFO] running `"docker" "inspect" "2f23a025c9f56ab7bb5ebbd9620dd0bd350a188bec45d923018b66af3a4de6d3"` [INFO] running `"docker" "rm" "-f" "2f23a025c9f56ab7bb5ebbd9620dd0bd350a188bec45d923018b66af3a4de6d3"` [INFO] [stdout] 2f23a025c9f56ab7bb5ebbd9620dd0bd350a188bec45d923018b66af3a4de6d3