[INFO] updating cached repository dmerejkowsky/rusync
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/dmerejkowsky/rusync
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/dmerejkowsky/rusync" "work/ex/clippy-test-run/sources/stable/gh/dmerejkowsky/rusync"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dmerejkowsky/rusync'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/dmerejkowsky/rusync" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmerejkowsky/rusync"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmerejkowsky/rusync'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 992bb083699da5cec2e547044e49675677058ab9
[INFO] sha for GitHub repo dmerejkowsky/rusync: 992bb083699da5cec2e547044e49675677058ab9
[INFO] validating manifest of dmerejkowsky/rusync on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dmerejkowsky/rusync on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dmerejkowsky/rusync
[INFO] finished frobbing dmerejkowsky/rusync
[INFO] frobbed toml for dmerejkowsky/rusync written to work/ex/clippy-test-run/sources/stable/gh/dmerejkowsky/rusync/Cargo.toml
[INFO] started frobbing dmerejkowsky/rusync
[INFO] finished frobbing dmerejkowsky/rusync
[INFO] frobbed toml for dmerejkowsky/rusync written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmerejkowsky/rusync/Cargo.toml
[INFO] crate dmerejkowsky/rusync has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting dmerejkowsky/rusync against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dmerejkowsky/rusync:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c45796c52e9dd6499a887dd41688d00d4c0ae59e39697fed4b4560baef29d409
[INFO] running `"docker" "start" "-a" "c45796c52e9dd6499a887dd41688d00d4c0ae59e39697fed4b4560baef29d409"`
[INFO] [stderr]     Checking term_size v0.3.1
[INFO] [stderr]     Checking filetime v0.1.15
[INFO] [stderr]     Checking clap v2.31.2
[INFO] [stderr]    Compiling syn v0.13.9
[INFO] [stderr]    Compiling structopt-derive v0.2.8
[INFO] [stderr]     Checking structopt v0.2.8
[INFO] [stderr]     Checking rusync v0.5.0 (/opt/crater/workdir)
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/console_info.rs:110:47
[INFO] [stderr]     |
[INFO] [stderr] 110 |         assert_eq!("200:00:02", human_seconds(720002));
[INFO] [stderr]     |                                               ^^^^^^ help: consider: `720_002`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `console_info::ConsoleProgressInfo`
[INFO] [stderr]   --> src/console_info.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 | /     pub fn new() -> ConsoleProgressInfo {
[INFO] [stderr] 16 | |         ConsoleProgressInfo {}
[INFO] [stderr] 17 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 12 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `sync::SyncOptions`
[INFO] [stderr]   --> src/sync.rs:71:5
[INFO] [stderr]    |
[INFO] [stderr] 71 | /     pub fn new() -> SyncOptions {
[INFO] [stderr] 72 | |         SyncOptions {
[INFO] [stderr] 73 | |             preserve_permissions: true,
[INFO] [stderr] 74 | |         }
[INFO] [stderr] 75 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 65 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/sync.rs:113:23
[INFO] [stderr]     |
[INFO] [stderr] 113 |         let options = self.options.clone();
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.options`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `console_info::ConsoleProgressInfo`
[INFO] [stderr]   --> src/console_info.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 | /     pub fn new() -> ConsoleProgressInfo {
[INFO] [stderr] 16 | |         ConsoleProgressInfo {}
[INFO] [stderr] 17 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 12 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/fsops.rs:318:42
[INFO] [stderr]     |
[INFO] [stderr] 318 |         let mut out = File::create(path).expect(&format!("could not open {:?} for writing", path));
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("could not open {:?} for writing", path))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/fsops.rs:323:40
[INFO] [stderr]     |
[INFO] [stderr] 323 |         unix::fs::symlink(&src, &dest).expect(&format!("could not link {:?} -> {:?}", src, dest));
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("could not link {:?} -> {:?}", src))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/fsops.rs:328:49
[INFO] [stderr]     |
[INFO] [stderr] 328 |         let link = std::fs::read_link(src_path).expect(&format!("could not read link {:?}", src));
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("could not read link {:?}", src))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `sync::SyncOptions`
[INFO] [stderr]   --> src/sync.rs:71:5
[INFO] [stderr]    |
[INFO] [stderr] 71 | /     pub fn new() -> SyncOptions {
[INFO] [stderr] 72 | |         SyncOptions {
[INFO] [stderr] 73 | |             preserve_permissions: true,
[INFO] [stderr] 74 | |         }
[INFO] [stderr] 75 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 65 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/sync.rs:113:23
[INFO] [stderr]     |
[INFO] [stderr] 113 |         let options = self.options.clone();
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.options`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> tests/integration_test.rs:32:34
[INFO] [stderr]    |
[INFO] [stderr] 32 |         std::fs::metadata(&path).expect(&format!("Could not get metadata of {:?}", path));
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not get metadata of {:?}", path))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 12.67s
[INFO] running `"docker" "inspect" "c45796c52e9dd6499a887dd41688d00d4c0ae59e39697fed4b4560baef29d409"`
[INFO] running `"docker" "rm" "-f" "c45796c52e9dd6499a887dd41688d00d4c0ae59e39697fed4b4560baef29d409"`
[INFO] [stdout] c45796c52e9dd6499a887dd41688d00d4c0ae59e39697fed4b4560baef29d409